Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix the documentation about ActionController::ParameterMissing [ci skip] | Mehmet Emin İNAÇ | 2015-06-22 | 1 | -5/+5 |
| | |||||
* | Revert "Merge pull request #20584 from arthurnn/fix_url" | Arthur Neves | 2015-06-17 | 3 | -19/+4 |
| | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal. | ||||
* | Merge pull request #20584 from arthurnn/fix_url | Arthur Nogueira Neves | 2015-06-16 | 3 | -4/+19 |
|\ | | | | | Catch InvalidURIError on bad paths on redirect. | ||||
| * | Catch InvalidURIError on bad paths on redirect. | Arthur Neves | 2015-06-16 | 3 | -4/+19 |
| | | | | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given. | ||||
* | | Fix the comment about attr_reader of headers [ci skip] | Mehmet Emin İNAÇ | 2015-06-16 | 1 | -1/+1 |
|/ | |||||
* | remove `header=` on the response object. | Aaron Patterson | 2015-06-15 | 3 | -13/+16 |
| | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals. | ||||
* | set the default charset in response initialize | Aaron Patterson | 2015-06-15 | 1 | -4/+12 |
| | | | | | this way we don't have to mutate the instance (as much) when writing a rack response | ||||
* | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 5 | -12/+47 |
| | |||||
* | Fix flakyness. | Kasper Timm Hansen | 2015-06-15 | 1 | -0/+1 |
| | | | | Brought on by my own stupidity :) | ||||
* | A few documentation edits [ci skip] | Robin Dupret | 2015-06-15 | 2 | -10/+12 |
| | |||||
* | quick pass over changelogs. [ci skip] | Yves Senn | 2015-06-15 | 1 | -4/+4 |
| | |||||
* | Merge pull request #20559 from mtsmfm/fix-header-modification-by-ssl | Guillermo Iguaran | 2015-06-14 | 2 | -1/+12 |
|\ | | | | | ActionDispatch::SSL should keep original header's behavior | ||||
| * | ActionDispatch::SSL should keep original header's behavior | Fumiaki MATSUSHIMA | 2015-06-14 | 2 | -1/+12 |
| | | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`. | ||||
* | | Merge pull request #20558 from prathamesh-sonpatki/missing-header-word | Kasper Timm Hansen | 2015-06-14 | 1 | -1/+1 |
|\ \ | |/ |/| | Add missing "header" word in documentation of Token#authentication_request [ci skip] | ||||
| * | Add missing "header" word in documentation of Token#authentication_request ↵ | Prathamesh Sonpatki | 2015-06-14 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
* | | don't hold a reference to `env` in the options object | Aaron Patterson | 2015-06-13 | 1 | -13/+11 |
| | | | | | | | | | | I want to decouple Rails from the rack ENV as much as possible. We should try to keep as few references to the env as possible | ||||
* | | Handle param-parsing errors from Rack in ExceptionWrapper | Grey Baker | 2015-06-12 | 2 | -1/+9 |
|/ | |||||
* | Merge pull request #20480 from senny/test_runner | Yves Senn | 2015-06-12 | 1 | -0/+4 |
|\ | | | | | use our own runner for Rails framework components `bin/test` | ||||
| * | select the AR adapter through `bin/test`. | Yves Senn | 2015-06-11 | 1 | -0/+1 |
| | | |||||
| * | use our runner (`bin/test`) for framework components. | Yves Senn | 2015-06-11 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | | | | | This adds a script `bin/test` to most Rails framework components. The script uses the rails minitest plugin to augment the runner. See https://github.com/rails/rails/pull/19571 for details about the plugin. I did not yet add `bin/test` for activerecord, activejob and railties. These components rely on specific setup performed in the rake-tasks. | ||||
* | | Update RDoc for ActionController::TestCase for kwargs. | Victor Costan | 2015-06-12 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #20522 from colby-swandale/doc-update | Sean Griffin | 2015-06-11 | 1 | -1/+1 |
|\ \ | | | | | | | fixed sring to be string in ActiveRecord::Base params documentation [ci skip] | ||||
| * | | fixed sring to be string in ActiveRecord::Base params documentation | Colby Swandale | 2015-06-12 | 1 | -1/+1 |
| | | | |||||
* | | | Mention that doing nothing in Rails API controllers returns 204 | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 |
| | | | |||||
* | | | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 5 | -6/+31 |
| | | | |||||
* | | | Add test coverage for implicit render in empty actions | Jorge Bejar | 2015-06-11 | 1 | -0/+14 |
| | | | |||||
* | | | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 2 | -1/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | ||||
* | | | Add CHANGELOG entries for API apps functionality | Santiago Pastorino | 2015-06-11 | 1 | -0/+6 |
| | | | |||||
* | | | Fix MimeResponds example in AC::API documentation | Santiago Pastorino | 2015-06-11 | 1 | -3/+5 |
| | | | |||||
* | | | Revert changes related with api apps in RouteWrapper | Jorge Bejar | 2015-06-11 | 1 | -11/+1 |
| | | | | | | | | | | | | | | | See the following commit to have context about this change: https://github.com/rails/rails/commit/757a2bc3e3e52a5d9418656928db993db42b741b | ||||
* | | | Rename test methods in api conditional get controller tests | Jorge Bejar | 2015-06-11 | 1 | -2/+2 |
| | | | |||||
* | | | Do not say that Api Controllers are faster than regular ones in docs | Jorge Bejar | 2015-06-11 | 1 | -4/+4 |
| | | | |||||
* | | | Remove Compatibility module since we don't remember why it was added :smile: | Jorge Bejar | 2015-06-11 | 2 | -20/+0 |
| | | | |||||
* | | | Routes resources avoid :new and :edit endpoints if api_only is enabled | Jorge Bejar | 2015-06-11 | 3 | -12/+110 |
| | | | |||||
* | | | Remove extra whitespaces | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 |
| | | | |||||
* | | | Use new hash syntax | Santiago Pastorino | 2015-06-11 | 2 | -7/+7 |
| | | | |||||
* | | | Refactor internal? to query internal_controller? and internal_asset? methods | Santiago Pastorino | 2015-06-11 | 1 | -1/+11 |
| | | | |||||
* | | | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵ | Santiago Pastorino | 2015-06-11 | 3 | -84/+0 |
| | | | | | | | | | | | | does the work | ||||
* | | | Remove api_rendering is not needed | Santiago Pastorino | 2015-06-11 | 3 | -19/+1 |
| | | | |||||
* | | | Adhere to Rails convention for private indentation | Santiago Pastorino | 2015-06-11 | 1 | -21/+20 |
| | | | |||||
* | | | Use nex hash syntax on tests | Santiago Pastorino | 2015-06-11 | 1 | -5/+5 |
| | | | |||||
* | | | Add ApiPublicException middleware | Santiago Pastorino | 2015-06-11 | 3 | -2/+87 |
| | | | |||||
* | | | Move Model test class inside RenderersApiController namespace | Santiago Pastorino | 2015-06-11 | 1 | -8/+8 |
| | | | |||||
* | | | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 10 | -0/+360 |
| | | | |||||
* | | | Merge pull request #20519 from colby-swandale/doc-update | Zachary Scott | 2015-06-11 | 1 | -3/+3 |
|\| | | | | | | | | better clarity of params source in ActionController::Base documentation | ||||
| * | | better clarity of params source in ActionController::Base documentation [ci ↵ | Colby Swandale | 2015-06-11 | 1 | -3/+3 |
| |/ | | | | | | | skip] | ||||
* / | Change the `index` arg of `ActionDispatch::Static#new` to a kwarg | Yuki Nishijima | 2015-06-11 | 2 | -5/+4 |
|/ | |||||
* | remove unused code | Aaron Patterson | 2015-06-08 | 1 | -2/+2 |
| | |||||
* | we only care about methods that the request object responds to | Aaron Patterson | 2015-06-08 | 1 | -2/+1 |
| | | | | | matches? should only deal with methods on the request object, so lets just filter out anything that the request object doesn't respond to | ||||
* | extract required_defaults from the conditions hash before constructing the route | Aaron Patterson | 2015-06-08 | 6 | -56/+56 |
| | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop |