| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
Fixes issue #15511.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
ActionController::Parameters#require now accepts FalseClass values
|
|/ / / /
| | | |
| | | |
| | | | |
Fixes #15685.
|
|\ \ \ \
| | | | |
| | | | | |
Set flash in test session when necessary.
|
| | | | |
| | | | |
| | | | |
| | | | | |
`to_session_value` returns nil when empty.
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The 401 status should be set first because setting the response body in
a live controller also closes the response to further changes.
Fixes #14229.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
if the subdomain wasn't specified, it's the same as if specifying
:subdomain as `true`, so we can default the value to `true` safely.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`normalize_host` already calls `named_host?`, so there is no reason to
test `named_host?` again in the `extract_domain` method.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before:
/Users/Juan/dev/rails/actionpack/lib/action_dispatch/http/url.rb:95: warning: shadowing outer local variable - port
After:
No warning
|
| | | |
| | | |
| | | |
| | | |
| | | | |
extract_subdomain always returns a string, and to_param calls to_s on a
string
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
irb(main):004:0> /foo/ !~ nil
=> true
irb(main):005:0> /foo/ !~ 'bar'
=> true
irb(main):006:0> /foo/ !~ 'foo'
=> false
|
| | | |
| | | |
| | | |
| | | |
| | | | |
remove the default parameter since the methods are always called with a
parameter
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 79469b4b0c05a50e19699bc9b568042add2d4987.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
remove warnings
|
| | | | |
| | | | |
| | | | |
| | | | | |
warning: assigned but unused variable - scope_called, path and strexp
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Restore test deliveries for ActionMailer.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
.. even when the producer is blocked for a write.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
This is a regression test for 29844dd.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We cannot cache keys because arrays are mutable. We rather want to cache
the arrays. This behaviour is tailor-made for the usage pattern strongs
params is designed for.
In a forthcoming commit I am going to add a test that covers why we need
to cache by value.
Every strong params instance has a live span of a request, the cache goes
away with the object. Since strong params have such a concrete intention,
it would be interesting to see if there are actually any real-world use
cases that are an actual leak, one that practically may matter.
I am not convinced that the theoretical leak has any practical consequences,
but if it can be shown there are, then I believe we should either get rid of
the cache (which is an optimization), or else wipe it in the mutating API.
This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
|/ / /
| | |
| | | |
Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
|
| | |
| | |
| | | |
Per convention, underscore-only argument names should be used for unused parameters.
|
|\ \ \
| | | |
| | | | |
Reset callbacks after test.
|
| | | |
| | | |
| | | |
| | | | |
Otherwise the state of callback chain is leaked.
|
|\ \ \ \
| | | | |
| | | | | |
Restore Response.default_headers after test.
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Make sure Mime::Type is not altered after tests.
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* 'master' of github.com:rails/rails:
For our build, stick with mail 2.5.x for now
Correct result, previously showing wrong result
Collapse PG default extractoin of most types to single regex
Change wording of explanation about precision & scale of decimal numbers [ci skip]
Cleaned up duplicated CHANGELOG entry [ci skip]
reuse available belongs_to? method
Convert StrongParameters cache to a hash. This fixes an unbounded memory leak demonstrated on @tenderlove's latest blog post:
Partially revert deprecation of *_filter
Pluralize params
Add default_i18n_subject to the guides
Fix regression on eager loading association based on SQL query rather than existing column.
Relax mail gem constraint from ~> 2.5.4 to ~> 2.5, >= 2.5.4
Keep column defaults in type cast form
Return a null column when no column exists for an attribute
Refactor XML serializer to not depend on `serialized_attributes`
Test the serialized types of virtual columns in XML
implement ActiveRecord::Base#pretty_print + changelog
Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
|