Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | adding a direct dispatch method to controller classes | Aaron Patterson | 2015-08-25 | 3 | -9/+13 | |
| | | | | | | | | | | | | This saves a lambda and request allocation on each request. | |||||
* | | | always dispatch to controllers the same way | Aaron Patterson | 2015-08-25 | 3 | -7/+26 | |
| | | | | | | | | | | | | | | | controllers should always go through the `action` class method so that their middleware is respected. | |||||
* | | | always return a controller class from the `controller_class` method | Aaron Patterson | 2015-08-25 | 2 | -9/+14 | |
| | | | | | | | | | | | | | | | now the caller can just treat it like a regular controller even though it will return a 404 | |||||
* | | | Merge pull request #21368 from rodzyn/remove_mocha | Kasper Timm Hansen | 2015-08-25 | 5 | -163/+209 | |
|\ \ \ | | | | | | | | | Get rid of mocha tests in actionpack - part 2 | |||||
| * | | | Get rid of mocha tests - part 2 | Marcin Olichwirowicz | 2015-08-25 | 5 | -163/+209 | |
| | | | | ||||||
* | | | | Merge pull request #21375 from rodzyn/unused_requires | Rafael Mendonça França | 2015-08-25 | 1 | -2/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove unused requires | |||||
| * | | | | Remove unused requires | Marcin Olichwirowicz | 2015-08-25 | 1 | -2/+0 | |
| | | | | | | | | | | | | | | | | | | | | They are already required in `actionpack/lib/action_dispatch.rb` (L25-L26) | |||||
* | | | | | Merge pull request #21366 from amitsuroliya/remove_unused_variable | Rafael Mendonça França | 2015-08-25 | 2 | -13/+13 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Remove more unused block arguments | |||||
| * | | | | Remove more unused block arguments | amitkumarsuroliya | 2015-08-25 | 2 | -13/+13 | |
| | | | | | ||||||
* | | | | | Make `assert_index` private | Marcin Olichwirowicz | 2015-08-25 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This `protected` keyword looks like some leftover, since we are not using explicit receiver, this should go under `private` | |||||
* | | | | | Merge pull request #21345 from aditya-kapoor/trim-ap | Rafael Mendonça França | 2015-08-25 | 2 | -6/+4 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Trim out least needed controllers from AP test suite | |||||
| * | | | | Trim out unneeded controllers from AP test suite | Aditya Kapoor | 2015-08-24 | 2 | -6/+4 | |
| | | | | | ||||||
* | | | | | remove unused require ‘set’ | NehaGautam | 2015-08-25 | 1 | -1/+0 | |
| | | | | | ||||||
* | | | | | Merge pull request #21094 from aditya-kapoor/add-missing-ap-tests | Rafael Mendonça França | 2015-08-25 | 1 | -0/+10 | |
|\ \ \ \ \ | | | | | | | | | | | | | add missing test for action regexp for routing | |||||
| * | | | | | add missing tests for action regexp | Aditya Kapoor | 2015-08-02 | 1 | -0/+10 | |
| | | | | | | ||||||
* | | | | | | Remove unused block arguments | Anshul Sharma | 2015-08-25 | 2 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Remove unused block arguments | amitkumarsuroliya | 2015-08-25 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | remove more direct `env` mutations | Aaron Patterson | 2015-08-24 | 2 | -2/+4 | |
| | | | | | | ||||||
* | | | | | | remove another `@env` access | Aaron Patterson | 2015-08-24 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | remove more direct access to `env` | Aaron Patterson | 2015-08-24 | 2 | -3/+4 | |
| | | | | | | ||||||
* | | | | | | fewer calls to `env` | Aaron Patterson | 2015-08-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | We don't want to directly access the env hash | |||||
* | | | | | | stop using `@env` in the GET / POST methods | Aaron Patterson | 2015-08-24 | 2 | -4/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I want to implement this with something besides `@env` in the future, so lets stop directly referencing it. | |||||
* | | | | | | rm useless method | Aaron Patterson | 2015-08-24 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | superclass already has this method, so remove this one | |||||
* | | | | | | remove dead code :bomb: | Aaron Patterson | 2015-08-24 | 1 | -2/+0 | |
| | | | | | | ||||||
* | | | | | | pull up dispatcher allocation | Aaron Patterson | 2015-08-24 | 2 | -5/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the dispatcher class isn't configurable anymore, so pull up allocation to the method that needs it. | |||||
* | | | | | | directly ask the request for the controller class | Aaron Patterson | 2015-08-24 | 1 | -6/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we don't have subclasses depending on this method (they augment the request class instead of the dispatch class) we can remove this method and directly ask the request object for the controller class | |||||
* | | | | | | use `make_set` helper method to generate route sets | Aaron Patterson | 2015-08-24 | 1 | -31/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | We should keep the route set generation logic in one place | |||||
* | | | | | | remove useless ivar | Aaron Patterson | 2015-08-24 | 1 | -2/+1 | |
| | | | | | | ||||||
* | | | | | | remove setter for the dispatcher class | Aaron Patterson | 2015-08-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | we don't need it anymore. We always use the same dispatcher in tests. | |||||
* | | | | | | subclass and delegate rather than mutating existing objects | Aaron Patterson | 2015-08-24 | 1 | -12/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we subclass and augment the superclass, then we don't need to have setters for particular things on the superclass. | |||||
* | | | | | | temp files are no more require | Gaurav Sharma | 2015-08-25 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | `:nail_care:` | |||||
* | | | | | | use a custom request class to determine the controller class | Aaron Patterson | 2015-08-24 | 2 | -25/+28 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class. | |||||
* | | | | | | Merge pull request #21339 from deepj/unused-block-arguments | Carlos Antonio da Silva | 2015-08-24 | 2 | -3/+3 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove unused block arguments | |||||
| * | | | | | | Remove unused block arguments | deepj | 2015-08-23 | 2 | -3/+3 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #21355 from akihiro17/remove-variables | Rafael Mendonça França | 2015-08-24 | 1 | -2/+2 | |
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | Remove unused variables | |||||
| * | | | | | | Remove unused variables | akihiro17 | 2015-08-24 | 1 | -2/+2 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #21321 from rodzyn/removing_mocha | Kasper Timm Hansen | 2015-08-24 | 10 | -78/+103 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Get rid of mocha tests in actionpack - part 1 | |||||
| * | | | | | | Get rid of mocha tests - part 1 | Marcin Olichwirowicz | 2015-08-24 | 10 | -78/+103 | |
| | | | | | | | ||||||
* | | | | | | | use methods on the request object instead of accessing env | Aaron Patterson | 2015-08-23 | 1 | -7/+7 | |
| | | | | | | | ||||||
* | | | | | | | use `Request#path_info` instead of direct ENV access | Aaron Patterson | 2015-08-23 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we already have a request, so we should use the methods on the request to access the path info information | |||||
* | | | | | | | remove env access from debug_exceptions | Aaron Patterson | 2015-08-23 | 1 | -10/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creates fewer request objects and helps to abstract away from internals | |||||
* | | | | | | | remove more `env` access | Aaron Patterson | 2015-08-23 | 1 | -11/+19 | |
| | | | | | | | ||||||
* | | | | | | | remove more env access | Aaron Patterson | 2015-08-23 | 1 | -3/+3 | |
| | | | | | | | ||||||
* | | | | | | | remove more env access | Aaron Patterson | 2015-08-23 | 1 | -4/+6 | |
| | | | | | | | ||||||
* | | | | | | | convert more `@env` access to get / set header | Aaron Patterson | 2015-08-23 | 2 | -12/+14 | |
| | | | | | | | ||||||
* | | | | | | | remove usage of `@env` | Aaron Patterson | 2015-08-23 | 1 | -3/+5 | |
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | try to remove dependencies on `@env` so we can have more flexible internals | |||||
* | | | | | | Another place to use a request object in NullSessionHash | Ronak Jangir | 2015-08-23 | 1 | -3/+3 | |
| |/ / / / |/| | | | | | | | | | | | | | | May be missed in 5fe141638f1243ac6ae187ae14aa398b4c1875a2 commit Also fixes the broken build | |||||
* | | | | | use a request object in the session middleware | Aaron Patterson | 2015-08-22 | 7 | -68/+74 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session. | |||||
* | | | | | move more `@env` access to method calls | Aaron Patterson | 2015-08-22 | 1 | -16/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | We're going to implement storing env values differently in the future, so let's disconnect these methods from the instance variables | |||||
* | | | | | move ORIGINAL_SCRIPT_NAME to the metaprogrammed methods | Aaron Patterson | 2015-08-22 | 1 | -4/+1 | |
| | | | | |