| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Eventually we don't want to expose the "options" hash from scope, only
read values from it. Lets start by adding a reader method.
|
|
|
|
|
| |
now we don't need to construct a Mapping object just to get an
ArgumentError if there is no `via` parameter provided.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
We're going to try pulling this up further, and check `via` validity
sooner. This way we don't have to do a bunch of processing on `options`
hashes only to find out that the route is incorrect
|
|
|
|
|
| |
If we do the Regexp verification in a second method, then the
`split_constraints` method gets much easier.
|
| |
|
| |
|
|
|
|
|
|
| |
I don't want `split_constraints` to mutate any instance variables. That
way it's easier to move the method around and understand what it does
(it has no side effects)
|
|
|
|
|
| |
I don't want to rely on mutating ivars. This gives me more freedom when
refactoring
|
| |
|
|
|
|
| |
we don't need to do it so many times.
|
| |
|
|
|
|
| |
Now we only need to call `split_constraints` possibly twice!
|
|
|
|
|
| |
apparently `format` can also come from the scope options, so we need to
extract it there too.
|
|\
| |
| | |
Authorization scheme should be case insensitive. Fixes #21199
|
| | |
|
| |
| |
| |
| |
| | |
this way we don't have to insert / delete it from the options hash so
many times.
|
| |
| |
| |
| |
| | |
eventually we'll remove the need to access `scope` inside the Mapping
object.
|
| | |
|
| |
| |
| |
| |
| |
| | |
`using_match_shorthand?` doesn't need to know that an options hash
exists. Also use this opportunity to make the boolean logic a little
more sane
|
| | |
|
| |
| |
| |
| |
| | |
this simplifies the "downstream" logic since we know we'll only be
dealing with one particular type
|
| | |
|
| |
| |
| |
| |
| | |
I think we can find the original place where `action` is added to the
options hash now.
|
| | |
|
| |
| |
| |
| |
| |
| | |
we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call. That way when
we're down the stack, we don't need to wonder "why are we doing this?"
|
| | |
|
| |
| |
| |
| |
| | |
There are some cases where :path is nil on option and we should respect
that.
|
| |
| |
| |
| | |
We already know how to handle `path`, so lets just handle it on our own.
|
| |
| |
| |
| |
| |
| |
| | |
All callers of `action_path` interpolate the return value in to a
string, so there is no need for the method to to_s it. to_sym on a
symbol will return the same symbol, though I think `action_path` may
always be called with a symbol so this might not be necessary.
|
| |
| |
| |
| | |
we only need to check for `path` once.
|
| |
| |
| |
| | |
Now we can see where `defaults` options originate
|
| | |
|
| |
| |
| |
| |
| | |
since `controller` and `controller_scope` were the same, just combine
them
|
| | |
|
| |
| |
| |
| |
| | |
This method isn't used internally, isn't tested, isn't documented. We
should delete it.
|
| |
| |
| |
| |
| | |
add a predicate method so that we can avoid is_a? calls on the resource
object.
|
| |
| |
| |
| |
| | |
calling `scope` isn't cheap, so try to call cheaper methods that do the
same thing for those particular parameters (in this case `path_scope`)
|
| |
| |
| |
| |
| | |
`resource_scope` should just put resource scopes on the stack, and
doesn't need to know what a `scope_level` is.
|
| |
| |
| |
| |
| | |
We just want to augment the scope level, not the frame itself, so just
copy the frame to the new scope object.
|
| |
| |
| |
| | |
this gives us an easier way to iterate the stack
|
| |
| |
| |
| |
| | |
The same information is stored in the `@scope` linked list, so just get
it from there.
|
| |
| |
| |
| | |
this lets us remove the setter and make the Resource object Read-Only
|
| |
| |
| |
| |
| | |
We don't need to ask `scope` for the resource because we already have it
right here.
|
| |
| |
| |
| |
| | |
This method raises conditionally not always so we should not documment
as it always raise.
|
| | |
|
| |
| |
| |
| |
| | |
We should return when the contoller key is not present or if the
controller doesn't exist and we didn't raised an error.
|
| |
| |
| |
| | |
Related with dc1b937db780155089fce522f03d340e62f5df36
|