aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Dynamically generaeted helpers on collection should not clobber resources ↵José Valim2010-11-252-0/+13
| | | | url helper [#6028 state:resolved]
* #:nodoc: internal methods.José Valim2010-11-251-31/+31
|
* Rakefiles are executables, and rake loads rake, not rakefile coderaggi2010-11-251-1/+1
|
* If a user wants json output then try best to render json output. In such ↵Neeraj Singh2010-11-243-1/+25
| | | | | | | | cases prefer kind_of(String) over respond_to?(to_str) [#5841 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* process text/* if it appears in the middle ofNeeraj Singh2010-11-252-1/+25
| | | | HTTP_ACCEPT parameter
* processing image/* is an odditity because there isNeeraj Singh2010-11-252-7/+1
| | | | | | a test case which expects image/* to not to be expanded. So I am leaving image/* as it is and process only text/* and application/*
* clean up test by using unregister methodNeeraj Singh2010-11-252-14/+7
|
* unregister method implementation and testNeeraj Singh2010-11-252-0/+29
|
* Remove the not needed setup and teardownNeeraj Singh2010-11-251-3/+0
|
* Allow template handlers to store temp data.José Valim2010-11-242-2/+32
|
* port_string bought back to life as it is part of the public apiJosh Kalderimis2010-11-242-4/+17
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* No need to return anythingNeeraj Singh2010-11-241-1/+0
|
* copy-edits RDoc of 2fe43b6Xavier Noria2010-11-231-2/+3
|
* Remove bazillion warnings from AP suite.José Valim2010-11-231-1/+1
|
* Speed up subdomain and domain calculus.José Valim2010-11-231-14/+6
|
* :subdomain, :domain and :tld_length options can now be used in url_for, ↵Josh Kalderimis2010-11-236-31/+105
| | | | | | allowing for easy manipulation of the host during link generation. Signed-off-by: José Valim <jose.valim@gmail.com>
* adding a test for the runner module [#6027 state:resolved]Aaron Patterson2010-11-221-0/+22
|
* sort lists before comparing themAaron Patterson2010-11-221-4/+4
|
* add respond_to? to ActionDispatch::Integration::RunnerSven Fuchs2010-11-221-0/+4
| | | | since Runner uses method_missing to delegate to the integration session it also should define respond_to? accordingly
* make test more resilient to future changes by notNeeraj Singh2010-11-221-2/+0
| | | | | | | | | | testing the count and not testing the internal value of the registered mime type. Ideally all mime type registration should be cleaned up in teardown. Signed-off-by: José Valim <jose.valim@gmail.com>
* remove select, collect and then inject withNeeraj Singh2010-11-221-1/+1
| | | | | | something better Signed-off-by: José Valim <jose.valim@gmail.com>
* string include method is 10x faster than creatingNeeraj Singh2010-11-221-1/+1
| | | | | | a new regex object every single time Signed-off-by: José Valim <jose.valim@gmail.com>
* Compile regex only onceNeeraj Singh2010-11-221-3/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* move the mime registration code to setup so thatNeeraj Singh2010-11-221-2/+19
| | | | | | | | | | | | | | | it could be cleaned up on teardown. Currently the test code test/controller/mime_responds_test.rb impacts test/dispatch/mime_type_test.rb. dispatch/mime_type_test.rb runs independently fine but when run as part of rake breaks because of new mime types registered in controller/mime_responds_test.rb Signed-off-by: José Valim <jose.valim@gmail.com>
* rename star star to just one starNeeraj Singh2010-11-221-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* cleanup Mime::LOOKUP after registering image/gifNeeraj Singh2010-11-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* fix testNeeraj Singh2010-11-221-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* implement code that handles text/*, appplication/*,Neeraj Singh2010-11-221-1/+16
| | | | | | and image/* Signed-off-by: José Valim <jose.valim@gmail.com>
* test for text/*, application/* and image/*Neeraj Singh2010-11-221-1/+27
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* declare regex as a constantNeeraj Singh2010-11-221-1/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* add the fixture fileNeeraj Singh2010-11-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* do not assume that there is no space betweenNeeraj Singh2010-11-222-1/+5
| | | | | | leading */* and comma Signed-off-by: José Valim <jose.valim@gmail.com>
* failing test for #6022Neeraj Singh2010-11-221-0/+34
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* current code ignores http header "Accept" if itNeeraj Singh2010-11-222-1/+7
| | | | | | | | | | | has ....,*/* . It is possible to a device to send request such that */* appear at the beginning of the "Accept" header. This patch ensures that "Accept" header is ignored for such cases too. Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove unused constantSantiago Pastorino2010-11-221-2/+0
|
* There's no need for ternary op hereSantiago Pastorino2010-11-221-1/+1
|
* Remove unneeded metaprogramming and method generation in favor of direct ↵Santiago Pastorino2010-11-221-24/+10
| | | | definition
* realigns a series of hash arrowsXavier Noria2010-11-211-10/+10
|
* use_accept_header is no longer supportedNeeraj Singh2010-11-211-1/+1
|
* Mention the case that `render` will return nil if given `:collection` is nil ↵Prem Sichanugrist2010-11-211-0/+5
| | | | or empty when rendering partial.
* Ensure calling reset session twice does not raise errors.José Valim2010-11-201-0/+12
|
* class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-203-6/+8
| | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix indentationSantiago Pastorino2010-11-201-24/+23
|
* Avoid range object creationSantiago Pastorino2010-11-201-1/+1
|
* do not require ruby-debug automatically. please require it if you have ↵Aaron Patterson2010-11-191-8/+0
| | | | declared it as a dependency
* Fix AssetIncludeTag ensuring that files are in the wrong directory [#6015 ↵Henning Koch2010-11-192-3/+47
| | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix indentationSantiago Pastorino2010-11-191-1/+1
|
* Don't merge just directly add to the action to the :partial keySantiago Pastorino2010-11-191-1/+1
|
* Useless assignationSantiago Pastorino2010-11-191-1/+1
|
* Revert "Quick fix for not escaping []s (not ideal)"Santiago Pastorino2010-11-181-3/+3
| | | | | | | | | According to http://www.ietf.org/rfc/rfc2616.txt and http://tools.ietf.org/rfc/rfc3986.txt [ and ] are reserved characters and should be escaped using "%" HEX HEX This reverts commit 856d2fd874d72dd9f83204affff4edfef3308361 and 1ee9b40b18a0bed5bb10a0785f7e2730bac983f6..