aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Changed css_select to not count on multiple selectors. Fixed bug in ↵Timm2014-06-161-8/+10
| | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document.
* Added a proper substitution context class. Changed ArgumentFilter to be a ↵Timm2014-06-161-34/+47
| | | | selector. It is now called HTMLSelector.
* Fixed nested assert_select bug. Trying to create a full document for a ↵Timm2014-06-161-1/+1
| | | | nested call that already had a document.
* Added implementation for substitution values via Nokogiri's custom pseudo ↵Timm2014-06-161-5/+35
| | | | classes.
* Readded some documentation about substitution values.Timm2014-06-161-2/+12
|
* Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError.Timm2014-06-151-2/+2
|
* Updated documentation to remove mention of HTML::Selector and clarify what ↵Timm2014-06-151-21/+9
| | | | is expected of a selector now.
* Changed tests to assert_kind_of Loofah::HTML::Document.Timm2014-06-151-3/+3
|
* Readded html_document method since it is used integration tests.Timm2014-06-151-1/+5
|
* Removed selector_test.rb since HTML::Selector will be removed. Soon.Timm2014-06-151-629/+0
|
* Changed filter_matches to return a new NodeSet instead of Array.Timm2014-06-151-1/+2
|
* Fixed Nokogiri::CSS::SyntaxErrors.Timm2014-06-151-2/+2
| | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters.
* Initialized @css_selector_is_second_argument in determine_root_from.Timm2014-06-151-0/+1
|
* Changed early return for filter_matches as well as reassigning matches. ↵Timm2014-06-151-6/+6
| | | | Meddled with initialize in ArgumentFilter.
* Removed redundant comments from assert_select.Timm2014-06-151-3/+1
| | | | Cleaned up a comment.
* Added assert_size_match! with the assertions for assert_select.Timm2014-06-151-14/+18
|
* Changed some documentation for css_select.Timm2014-06-151-1/+1
|
* Replaced fragment calls with document, since we assume the responses are ↵Timm2014-06-151-9/+8
| | | | complete documents.
* Added filter_matches to reduce line count in assert_select.Timm2014-06-151-24/+19
|
* Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵Timm2014-06-151-59/+39
| | | | ArgumentFilter.
* Removed the custom selected proc. It's no longer needed.Timm2014-06-151-10/+8
|
* Updated selector to not have reponse_from_page.Timm2014-06-151-5/+6
|
* Changed css_select and pulled out response_from_page from Selector.Timm2014-06-151-23/+17
|
* Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵Timm2014-06-151-1/+1
| | | | assert_select_encoded.
* Removed more redundant lines. Removed fix_content block that circumvented a ↵Timm2014-06-151-7/+1
| | | | bug in html-scanner.
* Removed more lines of code in assert_select.Timm2014-06-151-7/+6
|
* Simplified the first delete_if loop in assert_select to use Loofah's text ↵Timm2014-06-151-14/+13
| | | | method.
* Removed argument and root variable in assert_select proc.Timm2014-06-151-4/+2
|
* Changed name to selector. And a bunch of other things.Timm2014-06-151-60/+51
|
* The first attempt at abstracting argument parsing from selection methods.Timm2014-06-151-81/+114
|
* Removed tag.rb since it has been deprecated.Timm2014-06-154-321/+0
|
* Corrected documentation bug.Timm2014-06-151-10/+57
|
* Removed whitespace between dependencies.Timm2014-06-151-0/+1
|
* Added Loofah as a dependency in actionview.gemspec.Timm2014-06-112-9/+11
| | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah.
* Merge pull request #15545 from zuhao/refactor_actionpack_assert_select_testYves Senn2014-06-081-1/+4
|\ | | | | Restore test deliveries for ActionMailer.
| * Restore test deliveries for ActionMailer.Zuhao Wan2014-06-071-1/+4
| |
* | Handle client disconnect during live streamingMatthew Draper2014-06-084-13/+189
| | | | | | | | .. even when the producer is blocked for a write.
* | adds some details to the rationale of converted_arrays [ci skip]Xavier Noria2014-06-072-1/+5
| |
* | adds a regression test for the strong params converted arrays cacheXavier Noria2014-06-071-1/+18
| | | | | | | | This is a regression test for 29844dd.
* | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded"Xavier Noria2014-06-072-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
* | [ci skip] Fix capitalizationAkshay Vishnoi2014-06-072-3/+3
| |
* | remove another wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
| |
* | eliminate wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|/
* Use a frozen Set instance for CGI_VARIABLES.Nathaniel Bibler2014-06-051-8/+21
| | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
* Avoid misuse of underscore argumentCorey Ward2014-06-051-2/+2
| | | Per convention, underscore-only argument names should be used for unused parameters.
* Merge pull request #15530 from zuhao/refactor_actionpack_reloader_testMatthew Draper2014-06-061-0/+5
|\ | | | | Reset callbacks after test.
| * Reset callbacks after test.Zuhao Wan2014-06-051-0/+5
| | | | | | | | Otherwise the state of callback chain is leaked.
* | Merge pull request #15532 from zuhao/refactor_actionpack_response_testYves Senn2014-06-051-2/+4
|\ \ | | | | | | Restore Response.default_headers after test.
| * | Restore Response.default_headers after test.Zuhao Wan2014-06-051-2/+4
| | |
* | | Avoid hard-coded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ /
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-07 02:57:42 +0000