Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Properly initialize variables inside the initialize method. | José Valim | 2010-09-27 | 1 | -3/+8 | |
|/ | ||||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 2 | -2/+1 | |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 5 | -17/+17 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 6 | -13/+16 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Do not cache the script name outcome. | José Valim | 2010-09-27 | 1 | -9/+11 | |
| | ||||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 40 | -146/+173 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | |||||
| * | _routes must be inside @controller conditional. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Initialize @_routes if not defined yet, avoiding more warnings. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Rename duplicated test name. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Refactor method to avoid warnings and not run unnecessary code. | Emilio Tagua | 2010-09-27 | 1 | -11/+11 | |
| | | ||||||
| * | Avoid uninitialized variable warning. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Initialize @_request and @_response. | Emilio Tagua | 2010-09-27 | 1 | -1/+3 | |
| | | ||||||
| * | Remove method previous method if already defined. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Define @emitted_hidden_id if it doesn't exists and reuse it if it does. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Avoid uninitialized variable warning. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @cookies. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 5 | -17/+17 | |
| | | ||||||
| * | Don't shadow outer local variables. | Emilio Tagua | 2010-09-27 | 2 | -5/+5 | |
| | | ||||||
| * | Remove duplicated test. | Emilio Tagua | 2010-09-27 | 1 | -8/+0 | |
| | | ||||||
| * | Avoid uninitialized variable warning, reuse @integration_session. | Emilio Tagua | 2010-09-27 | 1 | -8/+14 | |
| | | ||||||
| * | Ask is @controller is defined to avoid warning. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Initialize @_routes if it doesn't exists. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove warning "too many arguments for format string" when interpolating ↵ | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | | | | | | | with empty hash. | |||||
| * | Initialize @_etag. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @as before plural method is called. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove old method before redefining it. | Emilio Tagua | 2010-09-27 | 1 | -0/+2 | |
| | | ||||||
| * | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 5 | -14/+34 | |
| | | ||||||
| * | Fix indentation. | Emilio Tagua | 2010-09-27 | 1 | -19/+18 | |
| | | ||||||
| * | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 17 | -58/+58 | |
| | | ||||||
* | | Call it compile_methods! and do the same on AM. | José Valim | 2010-09-27 | 1 | -2/+2 | |
| | | ||||||
* | | Assume compute_asset_host returns reasonable values. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | Convert unless/else into if/else. | thedarkone | 2010-09-27 | 1 | -4/+4 | |
| | | ||||||
* | | Performance: refactor convert_options_to_data_attributes. | thedarkone | 2010-09-27 | 1 | -10/+14 | |
| | | ||||||
* | | Remove dead code. | thedarkone | 2010-09-27 | 1 | -2/+2 | |
| | | ||||||
* | | Clean up url_for. | thedarkone | 2010-09-27 | 1 | -3/+1 | |
| | | ||||||
* | | Hash#empty? is faster than Enumerable#any? when used on a Hash. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | Do a single string interpolation. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | Simple .empty? test will do fine here (rails_asset_id returns nice strings). | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | options[:action] is very likely to be nil. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | Cache 2 of Request's commonly called methods. | thedarkone | 2010-09-27 | 1 | -2/+2 | |
| | | ||||||
* | | Cache url_options on a per-request basis. | thedarkone | 2010-09-27 | 1 | -9/+11 | |
| | | ||||||
* | | No need to create a separate lambda for each call. | thedarkone | 2010-09-27 | 1 | -15/+14 | |
| | | ||||||
* | | Make asset extension rewriting faster. | thedarkone | 2010-09-27 | 1 | -5/+11 | |
| | | ||||||
* | | Optimize relative_url_root rewriting code. | thedarkone | 2010-09-27 | 1 | -3/+5 | |
| | | ||||||
* | | Compile ActionController::Base.config's methods to avoid method_missing ↵ | thedarkone | 2010-09-27 | 2 | -2/+11 | |
|/ | | | | overhead. | |||||
* | Fix the precedence issue here | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | Not need to do this double ternary | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | port is appended twice to HTTP_HOST when host already has the port | Santiago Pastorino | 2010-09-26 | 1 | -3/+3 | |
| | ||||||
* | Bump up some deps | Santiago Pastorino | 2010-09-26 | 1 | -2/+2 | |
| | ||||||
* | Partial revert of #d650b71 'Remove deprecated stuff in ActionController' | Carlos Antonio da Silva | 2010-09-26 | 4 | -0/+11 | |
| | | | | | This brings back the deprecated modules from ActionController, because they didn't have any deprecation warning. |