aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | | | always pass a list to build_named_route_callAaron Patterson2014-05-121-10/+19
| | | | | | | | | | | |
* | | | | | | | | | | | add a test for passing two models to the polymorphic_url methodAaron Patterson2014-05-121-1/+1
| | | | | | | | | | | |
* | | | | | | | | | | | reduce conditionals in url_forAaron Patterson2014-05-121-3/+6
| | | | | | | | | | | |
* | | | | | | | | | | | extract route key translation to a method and reuse itAaron Patterson2014-05-121-17/+14
| | | | | | | | | | | |
* | | | | | | | | | | | make the module version quack the same as the instanceAaron Patterson2014-05-121-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this way we can stop checking respond_to on every call.
* | | | | | | | | | | | Hash#except is expensive and this is a hotspot, so use a dup + deleteAaron Patterson2014-05-121-1/+2
|/ / / / / / / / / / /
* | | | / / / / / / / Remove redundant tests method.Guo Xiang Tan2014-05-111-2/+0
| |_|_|/ / / / / / / |/| | | | | | | | |
* | | | | | | | | | docs, make `ActionNotFound` public API. [ci skip]Yves Senn2014-05-111-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems
* | | | | | | | | | adding complete message in documentation [ci skip]Gaurav Sharma2014-05-111-3/+4
| | | | | | | | | |
* | | | | | | | | | Always use the provided port for protocol relative urlsAndrew White2014-05-113-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided.
* | | | | | | | | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵Guilherme Cavalcanti2014-05-112-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | relative URL.
* | | | | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-05-101-1/+22
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | copy edits [ci skip]Vijay Dev2014-05-101-8/+8
| | | | | | | | | | |
| * | | | | | | | | | [ci skip] doc Http::Headers methodsschneems2014-05-091-1/+17
| | | | | | | | | | |
| * | | | | | | | | | copy edits [ci skip]Vijay Dev2014-05-081-2/+1
| | | | | | | | | | |
| * | | | | | | | | | [ci skip] document ActionDispatch::HTTP::Headersschneems2014-05-071-0/+6
| | | | | | | | | | |
* | | | | | | | | | | skip dealing with params if none are providedAaron Patterson2014-05-091-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us avoid 1. A slow call to Hash#slice 2. An is_a? test 3. Extra hash allocations (from slice) 4. String allocations etc.
* | | | | | | | | | | don't mutate the options hash, so we don't have to dupAaron Patterson2014-05-091-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | avoids extra hash allocations on each call
* | | | | | | | | | | use unless and || since these options are booleanAaron Patterson2014-05-091-1/+1
| | | | | | | | | | |
* | | | | | | | | | | just call the method and assert the return valueAaron Patterson2014-05-091-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | do not test internals
* | | | | | | | | | | HTTP::Headers#key? correctly convertsschneems2014-05-072-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence
* | | | | | | | | | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactorRafael Mendonça França2014-05-063-6/+34
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and...
| * | | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵Tom Kadwill2014-05-063-6/+34
| | |_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | improved tests.
* / | | | | | | | | | Only accept actions without File::SEPARATOR in the name.Rafael Mendonça França2014-05-062-4/+41
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb
* | | | | | | | | | Get rid of extra local var that does not add to the logicCarlos Antonio da Silva2014-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are too many "action name" variables around the process method.
* | | | | | | | | | Improve CHANGELOG entryRafael Mendonça França2014-05-041-2/+2
| | | | | | | | | |
* | | | | | | | | | Use assert_raisesRafael Mendonça França2014-05-041-3/+1
| | | | | | | | | |
* | | | | | | | | | Do not use short-circuit returnRafael Mendonça França2014-05-041-2/+3
| | | | | | | | | |
* | | | | | | | | | Merge pull request #11166 from xavier/callable_constraint_verificationRafael Mendonça França2014-05-043-0/+29
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Callable route constraint verification Conflicts: actionpack/CHANGELOG.md
| * | | | | | | | | | Verify that route constraints respond to the expected messages instead of ↵Xavier Defrang2013-06-283-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | silently failing to enforce the constraint
* | | | | | | | | | | Fix examples indent and improve #process docs a bit [ci skip]Carlos Antonio da Silva2014-05-041-16/+14
| | | | | | | | | | |
* | | | | | | | | | | Document ActionController::TestCase::Behavior#processGaurish Sharma2014-05-041-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | | Remove tests method for test cases when controller can be inferred.Guo Xiang2014-05-035-21/+1
| |_|/ / / / / / / / |/| | | | | | | | |
* | | | | | | | | | Use #include? instead of #any?, make it simplerAkshay Vishnoi2014-05-031-1/+1
| | | | | | | | | |
* | | | | | | | | | passing a nil in the polymorphic array is not supported. remove nils before ↵Aaron Patterson2014-05-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | you call the method
* | | | | | | | | | passing a nil should always raise an ArgumentErrorAaron Patterson2014-05-021-1/+0
| | | | | | | | | |
* | | | | | | | | | Tiny follow up to #14915 [ci skip]Robin Dupret2014-05-021-19/+18
| | | | | | | | | |
* | | | | | | | | | only add the optiosn if they are not emptyAaron Patterson2014-05-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think this is wrong, but it gets the build passing for now. We should always add options, but we need to make more guarantees about how the underlying url helper is called
* | | | | | | | | | always pass options to the _url methodAaron Patterson2014-05-011-3/+1
| | | | | | | | | |
* | | | | | | | | | never merge url options in to the first data hashAaron Patterson2014-05-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if you want options, don't mix them with the first hash, just pass them all in with the second hash
* | | | | | | | | | Merge pull request #14915 from juanpastas/patch-1Rafael Mendonça França2014-05-011-20/+37
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Update mapper.rb
| * | | | | | | | | | [skip ci] Document: required `via` option in `match` routing method.Juan David Pastas2014-04-301-20/+37
| | |/ / / / / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #12651 from cespare/ipv6-remote-ip-fixesRafael Mendonça França2014-05-013-2/+13
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make remote_ip detection properly handle private IPv6 addresses Conflicts: actionpack/CHANGELOG.md
| * | | | | | | | | | Make remote_ip detection properly handle private IPv6 addressesCaleb Spare2013-10-263-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #12638.
* | | | | | | | | | | avoid calling extract_record multiple timesAaron Patterson2014-04-301-3/+2
| | | | | | | | | | |
* | | | | | | | | | | eliminate conditional when sending the named route methodAaron Patterson2014-04-301-2/+4
| | | | | | | | | | |
* | | | | | | | | | | do not allocate strings while creating urlsAaron Patterson2014-04-301-1/+1
| | | | | | | | | | |
* | | | | | | | | | | don't allocate string on hash accessAaron Patterson2014-04-301-1/+1
| |/ / / / / / / / / |/| | | | | | | | |
* | | | | | | | | | Fixed an issue with migrating legacy json cookies.Godfrey Chan2014-04-233-2/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming cookies are marshal-encoded. This is not the case when `secret_token` is used in conjunction with the `:json` or `:hybrid` serializer. In those case, when upgrading to use `secret_key_base`, this would cause a `TypeError: incompatible marshal file format` and a 500 error for the user. Fixes #14774. *Godfrey Chan*
* | | | | | | | | | Merge pull request #10764 from mokevnin/replace_class_eval_by_define_methodRafael Mendonça França2014-04-221-35/+29
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | replace class_eval by define_method in abstract_controller/callbacks
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-08 22:38:30 +0000