aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | remove vestigial codeAaron Patterson2015-08-072-82/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looks like this was left over from converting Rails to Rack. I think it's safe to remove now.
* | | | | | | stop using @_env in the controller instanceAaron Patterson2015-08-074-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actions are processed through `dispatch`, so they should have the request set on them before any user land code can be executed. Lets stop setting _env on the controller, and give access to it through the `env` method.
* | | | | | | finish deprecating handling strings and symbolsAaron Patterson2015-08-076-80/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we only work with instances of classes, it greatly simplifies the `Middleware` implementation.
* | | | | | | Using strings or symbols for middleware class names is deprecated.Aaron Patterson2015-08-076-50/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert things like this: middleware.use "Foo::Bar" to this: middleware.use Foo::Bar
* | | | | | | move `valid?` conditional to the constructorAaron Patterson2015-08-071-11/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use a strategy pattern to calculate the conditional in `valid?` in advance.
* | | | | | | simplify the Middleware constructorAaron Patterson2015-08-073-57/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should do the hard work outside the constructor. Also fix the tests to not directly construct middleware objects, but to go through the stack object.
* | | | | | | use Proc.new to reduce some conditionalsAaron Patterson2015-08-071-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proc.new will pick up the passed in block, but since it's a default param, it won't get evaluated unless someone doesn't pass in an app. It will raise an exception if no block is provided.
* | | | | | | the request class is never changed, so just use it directly in the method bodyAaron Patterson2015-08-072-6/+6
|/ / / / / /
* | | | | | refactor param parsing middleware to use request objectsAaron Patterson2015-08-072-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this is another place that we should stop directly accessing the env hash and let the request object take care of that for us
* | | | | | move flash hash access to methods on the request objectAaron Patterson2015-08-071-2/+11
| | | | | |
* | | | | | Merge pull request #21153 from grosser/grosser/portsRafael Mendonça França2015-08-062-1/+24
|\ \ \ \ \ \ | | | | | | | | | | | | | | do not add common ports to HTTP_HOST
| * | | | | | do not add common ports to HTTP_HOSTMichael Grosser2015-08-062-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - webservers do not do it - it makes redirect urls ugly when request.host is used for redirection
* | | | | | | Fix documentation on ActionDispatch::RequestGabriel Sobrinho2015-08-061-1/+1
|/ / / / / /
* | | | | | use a request object to access info from env in GetIpAaron Patterson2015-08-062-11/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | again, we want to hide the contents of `env` from the implementation. Allocate a request object to access the contents of env, but save allocations due to string literal allocations when accessing the env hash.
* | | | | | ask the request if we should show exceptionsAaron Patterson2015-08-063-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hide the env key in the request object so that other code doesn't need to know.
* | | | | | ExceptionWrapper doesn't need to know about `env`Aaron Patterson2015-08-064-26/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ExceptionWrapper only cares about the backtrace cleaner, so lets just pass the cleaner to the wrapper. It does not need to know that env exists or what key the backtrace cleaner is stored in
* | | | | | prevent string allocationsAaron Patterson2015-08-061-1/+1
| | | | | |
* | | | | | reuse the request object in the File serving middlewareAaron Patterson2015-08-061-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement `serve` on the middleware. Nothing can be placed between the instance of FileHandler and Static because Static instantiates an instance of FileHandler. IOW there is no reason to implement the `call` API in this case.
* | | | | | get the underlying REQUEST_METHOD from the superclassAaron Patterson2015-08-061-1/+1
| | | | | |
* | | | | | use a request object to reduce string allocations and not know about ENV keysAaron Patterson2015-08-062-7/+8
| | | | | |
* | | | | | Merge pull request #21061 from yui-knk/refactor/route_setRafael Mendonça França2015-08-061-4/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove duplicated `Array#to_param`
| * | | | | | Remove duplicated `Array#to_param`yui-knk2015-08-011-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Array#to_param` is defind in active_support/core_ext/object/to_query.rb, so we can call `to_param` if value is_a Array.
* | | | | | | Merge pull request #21131 from eagletmt/percent-filenameRafael Mendonça França2015-08-063-1/+28
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix Encoding::UndefinedConversionError with multibyte UTF-8 filename containing "%" character
| * | | | | | | Assume uploaded filename is UTF-8Kohei Suzuki2015-08-051-1/+7
| | | | | | | |
| * | | | | | | Add failing spec on utf8 filename with percent characterKohei Suzuki2015-08-042-0/+21
| | |/ / / / / | |/| | | | |
* | | | | | | Adds missing argument handling for ActionController::TestSession toMatthew Gerrior2015-08-063-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | allow testing controllers that use session#fetch with a default value.
* | | | | | | remove dead codeAaron Patterson2015-08-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we don't recycle requests anymore, so we shouldn't need to recycle cookie jars
* | | | | | | ask the request for the cookie jarAaron Patterson2015-08-061-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this prevents the middleware from knowing the specific key for the jar
* | | | | | | add a setter for the cookie jarAaron Patterson2015-08-062-2/+8
| | | | | | |
* | | | | | | remove request reference from chained jarsAaron Patterson2015-08-061-22/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the chained jars to ask the parent jar for the request object which should eventually call back up to the original jar
* | | | | | | remove `@host` ivarAaron Patterson2015-08-052-13/+5
| | | | | | |
* | | | | | | remove @secure ivarAaron Patterson2015-08-052-7/+4
| | | | | | |
* | | | | | | CookieJar does not need the key_generator parameter anymoreAaron Patterson2015-08-052-5/+3
| | | | | | |
* | | | | | | eliminate key_generator ivarAaron Patterson2015-08-051-11/+14
| | | | | | |
* | | | | | | sop passing host and secure to the build methodAaron Patterson2015-08-052-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | eventually we will make the cookie jar derive these values from the request object rather than save a reference to the values
* | | | | | | stop using an options hash with the cookie jarAaron Patterson2015-08-052-39/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cookie jar can just ask the request object for the information it needs. This allows us to stop allocating hashes for options, and also allows us to delay calculating values in advance. Generating the options hash forced us to calculate values that we may never have needed at runtime
* | | | | | | move env access to the request object.Aaron Patterson2015-08-053-16/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Accessing a request object has nice advantages over accessing a hash. If you use a missing method name, you'll get an exception rather than a `nil` (is one nice feature)
* | | | | | | routes in the env via the request objectAaron Patterson2015-08-051-0/+4
| | | | | | |
* | | | | | | allocate a request object to avoid hash allocationsAaron Patterson2015-08-051-0/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | This decouples the `call` method from knowing the SCRIPT_NAME key and offloads decisions about how to access script_name
* | | | | | Merge pull request #21095 from aditya-kapoor/add-missing-assertionYves Senn2015-08-031-2/+4
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add missing assertion for test_route_with_colon_first
| * | | | | Add missing assertion for test_route_with_colon_firstAditya Kapoor2015-08-031-2/+4
| | |/ / / | |/| | |
* / | | | Use #start_with? and #[] for speedBenjamin Quorning2015-08-021-2/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While the readability may be slightly worse, the speed improvement is significant: Twice as fast when there's no leading "/" to remove, and over 4 times as fast when there is a leading "/". Benchmark: require 'benchmark/ips' def match(controller) if controller if m = controller.match(/\A\/(?<controller_without_leading_slash>.*)/) m[:controller_without_leading_slash] else controller end end end def start_with(controller) if controller if controller.start_with?('/'.freeze) controller[1..-1] else controller end end end Benchmark.ips do |x| x.report("match") { match("no_leading_slash") } x.report("start_with") { start_with("no_leading_slash") } x.compare! end Benchmark.ips do |x| x.report("match") { match("/a_leading_slash") } x.report("start_with") { start_with("/a_leading_slash") } x.compare! end Result (Ruby 2.2.2): Calculating ------------------------------------- match 70.324k i/100ms start_with 111.264k i/100ms ------------------------------------------------- match 1.468M (± 7.1%) i/s - 7.314M start_with 3.787M (± 3.5%) i/s - 18.915M Comparison: start_with: 3787389.4 i/s match: 1467636.4 i/s - 2.58x slower Calculating ------------------------------------- match 36.694k i/100ms start_with 86.071k i/100ms ------------------------------------------------- match 532.795k (± 4.7%) i/s - 2.679M start_with 2.518M (± 5.8%) i/s - 12.566M Comparison: start_with: 2518366.8 i/s match: 532794.5 i/s - 4.73x slower
* | | | Merge pull request #21088 from yui-knk/doc/to_paramRichard Schneeman2015-08-011-0/+15
|\ \ \ \ | | | | | | | | | | [ci skip]
| * | | | [ci skip]yui-knk2015-08-011-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add descriptions about `ActiveRecord::Base#to_param` to * `ActionDispatch::Routing::Base#match` * Overriding Named Route Parameters (guide) When passes `:param` to route definision, always `to_param` method of related model is overridden to constructe an URL by passing these model instance to named_helper.
* | | | | docs, custom api base controllers shoudl subclass metal. [ci skip]Yves Senn2015-08-011-1/+1
| | | | | | | | | | | | | | | | | | | | This is a follow up to #21008.
* | | | | Merge pull request #21008 from svenwin/patch-1Yves Senn2015-08-011-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | Add documentation to get a running custom base controller [ci skip]
| * | | | Add documentation to get a running custom base controller [ci skip]Sven Winkler2015-07-231-1/+1
| | | | |
* | | | | Array#any? is slower and not the inverse of Array#empty?Jean Boussier2015-07-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` empty_array = [] small_array = [1] * 30 bigger_array = [1] * 300 Benchmark.ips do |x| x.report('empty !empty?') { !empty_array.empty? } x.report('small !empty?') { !small_array.empty? } x.report('bigger !empty?') { !bigger_array.empty? } x.report('empty any?') { empty_array.any? } x.report('small any?') { small_array.any? } x.report('bigger any?') { bigger_array.any? } end ``` ``` Calculating ------------------------------------- empty !empty? 132.059k i/100ms small !empty? 133.974k i/100ms bigger !empty? 133.848k i/100ms empty any? 106.924k i/100ms small any? 85.525k i/100ms bigger any? 86.663k i/100ms ------------------------------------------------- empty !empty? 8.522M (± 7.9%) i/s - 42.391M small !empty? 8.501M (± 8.5%) i/s - 42.202M bigger !empty? 8.434M (± 8.6%) i/s - 41.894M empty any? 4.161M (± 8.3%) i/s - 20.743M small any? 2.654M (± 5.2%) i/s - 13.256M bigger any? 2.642M (± 6.4%) i/s - 13.173M ``` Ref: https://github.com/rails/rails/pull/21057#discussion_r35902468
* | | | | Use delete_if instead of each; delete(key)schneems2015-07-301-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is slightly faster: ``` Calculating ------------------------------------- each; delete 35.166k i/100ms delete_if 36.416k i/100ms ------------------------------------------------- each; delete 478.026k (± 8.5%) i/s - 2.391M delete_if 485.123k (± 7.9%) i/s - 2.440M ```
* | | | | Remove (another) array allocationschneems2015-07-301-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't always need an array when generating a url with the formatter. We can be lazy about allocating the `missing_keys` array. This saves us: 35,606 bytes and 889 objects per request
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-11 05:42:34 +0000