| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
[ci skip]
|
| |\
| |
| |
| | |
Now we're almost ready to remove this: https://github.com/rails/rails/blob/5294ad8/activesupport/lib/active_support/test_case.rb#L29
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
The [following pull request](https://github.com/rails/rails/pull/8916) fixed
the block being passed to the appropriate helper method. However, the content
being passed into the block is generating repeated markup on the page due to
some weird ERb evaluation.
This commit tries to capture the block's generated output so the page isn't
flooded with markup.
[Rafael França + José Mota]
Closes #8936
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Ruby 1.9 freezes Hash string keys by default so where a route is
defined like this:
get 'search' => 'search'
then the Mapper will derive the action from the key. This blows up
later when the action is added to the parameters hash and the
encoding is forced.
Closes #3429
|
| |\
| |
| | |
AR integration tests for form helpers
|
| | | |
|
| |\ \
| | |
| | | |
In Browser Path Matching with Javascript
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When debugging routes ,it can sometimes be difficult to understand exactly how the paths are matched. This PR adds a JS based path matching widget to the `/rails/info/routes` output. You can enter in a path, and it will tell you which of the routes that path matches, while preserving order (top match wins).
The matching widget in action:
Prior to this PR the only way to check matching paths is via mental math, or typing in a path in the url bar and seeing where it goes. This feature will be an invaluable debugging tool by dramatically decreasing the time needed to check a path match.
ATP actionpack
|
| | |/
|/|
| |
| | |
It was being set to nil instead due to the wrong assignment.
|
| |\ \
| |/
|/| |
Enhanced tests for AbstractController::Translation module
|
| | |
| |
| |
| | |
translation tests.
|
| | | |
|
| | | |
|
| |/ |
|
| |\
| |
| | |
Remove i18n symbol dependency
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
date.order is the only key in rails i18n that is required to be a
symbol. This patch allows for symbols or strings which means:
* No requirement for symbol type in .yml files. A future
YAML.safe_load wouldn't need to load symbols
* Rails could actually use json rather than yml as the backend
|
| | |
| |
| |
| |
| |
| | |
https://github.com/rails/rails/commit/cc1c3c5be061e7572018f734e5239750ab449e3f
Now instead of raise, we log by default in development and test
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| |
|
|
| |
Also add some generic tests to ensure they're properly deprecated.
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
Strong parameters exception handling
|
| | | |
|
| |/
|
|
| |
The same headers were being duplicated on every request.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit changes route defaults so that explicit defaults are no
longer required where the key is not part of the path. For example:
resources :posts, bucket_type: 'posts'
will be required whenever constructing the url from a hash such as a
functional test or using url_for directly. However using the explicit
form alters the behavior so it's not required:
resources :projects, defaults: { bucket_type: 'projects' }
This changes existing behavior slightly in that any routes which
only differ in their defaults will match the first route rather
than the closest match.
Closes #8814
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This now allows the use of arrays like this:
get '/foo/:action', to: 'foo', constraints: { subdomain: %w[www admin] }
or constraints where the request method returns an Fixnum like this:
get '/foo', to: 'foo#index', constraints: { port: 8080 }
Note that this only applies to constraints on the request - path
constraints still need to be specified as Regexps as the various
constraints are compiled into a single Regexp.
|
| | |
|
| |
|
|
|
|
|
| |
Now that Journey has been integrated into ActionDispatch we can raise
the exception ActionController::UrlGenerationError directly rather than
raising the internal Journey::Router::RoutingError and then have
ActionDispatch::Routing::RouteSet#generate re-raise the exception.
|
| |\
| |
| | |
Rename :value to :selected for date_select, and add missing tests/docs
|
| | |
| |
| |
| |
| | |
Add tests for time & datetime.
Add documentation.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
block. Breaks benchmark calls that return non-String values otherwise.
Revert "add benchmark helper that works in erb"
This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de.
Conflicts:
actionpack/lib/action_view/helpers.rb
actionpack/lib/action_view/helpers/benchmark_helper.rb
actionpack/test/template/benchmark_helper_test.rb
|
| |\ \
| |/
|/|
| |
| | |
Collection radio buttons and collection check boxes through FormBuilder render the provided block.
Closes #8897
|
| | |
| |
| |
| |
| |
| |
| |
| | |
the provided block.
In the case of having a form_for method being called, the block for each
collection would not be passed and thus the result expected was always the same.
This patch passes the block to the original method like it would be assumed.
|
| | | |
|
| |/ |
|
| |\
| |
| | |
Fixed nested fields bug when called with AssociationProxy
|
| | |
| |
| |
| | |
support in form helper
|
| | |
| |
| |
| | |
Fixes #8845.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Evaluate view_cache_dependencies at the instance level
Conflicts:
actionpack/lib/action_controller/caching.rb
|
| | | | |
|
| | | |
| | |
| | |
| | | |
All Action Pack tests are green.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
dealing with empty hashes. Thanks Damien Mathieu
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_dispatch/http/request.rb
actionpack/lib/action_dispatch/middleware/params_parser.rb
activerecord/CHANGELOG.md
activerecord/lib/active_record/relation/predicate_builder.rb
activerecord/test/cases/relation/where_test.rb
|
