diff options
author | Brian Alexander <balexand@gmail.com> | 2013-01-15 17:07:13 -0700 |
---|---|---|
committer | Brian Alexander <balexand@gmail.com> | 2013-01-15 17:45:34 -0700 |
commit | 8e221127abf5262183c20e981f7cf1ff4bfe1a4f (patch) | |
tree | 611f8035f49adff3aa83b7151aa138ade0abd8a4 /actionpack/test | |
parent | 8492396e9c1fe21036783d9785ed42c27dee9201 (diff) | |
download | rails-8e221127abf5262183c20e981f7cf1ff4bfe1a4f.tar.gz rails-8e221127abf5262183c20e981f7cf1ff4bfe1a4f.tar.bz2 rails-8e221127abf5262183c20e981f7cf1ff4bfe1a4f.zip |
strong parameters exception handling
Diffstat (limited to 'actionpack/test')
-rw-r--r-- | actionpack/test/controller/required_params_test.rb | 15 | ||||
-rw-r--r-- | actionpack/test/dispatch/debug_exceptions_test.rb | 6 |
2 files changed, 12 insertions, 9 deletions
diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb index 661bcb3945..2898adee72 100644 --- a/actionpack/test/controller/required_params_test.rb +++ b/actionpack/test/controller/required_params_test.rb @@ -11,20 +11,17 @@ class ActionControllerRequiredParamsTest < ActionController::TestCase tests BooksController test "missing required parameters will raise exception" do - post :create, { magazine: { name: "Mjallo!" } } - assert_response :bad_request + assert_raise (ActionController::ParameterMissing) do + post :create, { magazine: { name: "Mjallo!" } } + end - post :create, { book: { title: "Mjallo!" } } - assert_response :bad_request + assert_raise (ActionController::ParameterMissing) do + post :create, { book: { title: "Mjallo!" } } + end end test "required parameters that are present will not raise" do post :create, { book: { name: "Mjallo!" } } assert_response :ok end - - test "missing parameters will be mentioned in the return" do - post :create, { magazine: { name: "Mjallo!" } } - assert_equal "Required parameter missing: book", response.body - end end diff --git a/actionpack/test/dispatch/debug_exceptions_test.rb b/actionpack/test/dispatch/debug_exceptions_test.rb index 1319eba9ac..6035f0361e 100644 --- a/actionpack/test/dispatch/debug_exceptions_test.rb +++ b/actionpack/test/dispatch/debug_exceptions_test.rb @@ -39,6 +39,8 @@ class DebugExceptionsTest < ActionDispatch::IntegrationTest raise ActionController::BadRequest when "/missing_keys" raise ActionController::UrlGenerationError, "No route matches" + when "/parameter_missing" + raise ActionController::ParameterMissing, :missing_param_key else raise "puke!" end @@ -114,6 +116,10 @@ class DebugExceptionsTest < ActionDispatch::IntegrationTest get "/bad_request", {}, {'action_dispatch.show_exceptions' => true} assert_response 400 assert_match(/ActionController::BadRequest/, body) + + get "/parameter_missing", {}, {'action_dispatch.show_exceptions' => true} + assert_response 400 + assert_match(/ActionController::ParameterMissing/, body) end test "does not show filtered parameters" do |