aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Rename the last occurrence of UnexpectedParametersRafael Mendonça França2013-01-051-2/+2
|
* Rename the configuration to raise_on_unpermitted_parametersRafael Mendonça França2013-01-051-4/+4
| | | | Also changed the exception to UnpermittedParameters
* Merge pull request #8752 from thomasfedb/masterRafael Mendonça França2013-01-051-0/+33
|\ | | | | Exception on unexpected params when enabled.
| * Allow developers to enable raising of exception when unexpected params are ↵Thomas Drake-Brockman2013-01-051-0/+33
| | | | | | | | provided.
* | Allow use of durations for ActionDispatch::SSL configurationAndrew White2013-01-041-0/+7
|/
* Restore original remote_ip algorithm.Andre Arko2013-01-021-58/+44
| | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979
* do not append a second slash when usingYves Senn2013-01-021-6/+16
|
* No need to pass a empty block to content_tag_for anymoreRafael Mendonça França2013-01-021-11/+11
|
* Make content_tag_for work without blockRafael Mendonça França2013-01-021-0/+8
| | | | This is version of #8640 for master
* Fix test for DebugExceptions due to template changeGuillermo Iguaran2012-12-311-1/+1
|
* Use ActiveSupport::TestCase in the journey testsRafael Mendonça França2012-12-3113-13/+13
|
* Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-3112-22/+22
|
* Do not use the same tests descriptionRafael Mendonça França2012-12-311-3/+3
|
* Remove unneeded testsRafael Mendonça França2012-12-315-381/+0
| | | | These tests are needed only if we are using MiniTest::Spec
* Add active_support/testing/autorunRafael Mendonça França2012-12-313-3/+3
| | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* Merge pull request #8662 from ↵Santiago Pastorino2012-12-311-1/+12
|\ | | | | | | | | senny/8661_should_not_append_charset_if_already_present Charset should not be appended to image/* type
| * charset should not be appended for `head` responsesYves Senn2012-12-311-1/+12
| | | | | | | | | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* | Merge pull request #8546 from hsbt/fix-testcase-strict-warningSantiago Pastorino2012-12-301-1/+2
|\ \ | |/ |/| fix testcase: ruby-2.0.0 warned unused variables
| * change spy of after invoked controller action. because ruby-2.0.0 waned ↵SHIBATA Hiroshi2012-12-201-1/+2
| | | | | | | | unused variables
* | Fix collection_radio_buttons with the option `:checked` with value ofRafael Mendonça França2012-12-261-0/+6
| | | | | | | | `false`
* | we're not supporting SQLite 2Akira Matsuda2012-12-241-13/+5
| |
* | Merge pull request #8085 from acapilleri/format_never_nilGuillermo Iguaran2012-12-222-2/+11
|\ \ | | | | | | if format is unknown NullMimeTypeObject is returned
| * | return Mime::NullType if format is unknownAngelo Capilleri2012-12-222-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* | | Merge pull request #8586 from balexand/cache_digests_regexRafael Mendonça França2012-12-212-1/+11
|\ \ \ | |/ / |/| | Digestor explicit dependency should not contain trailing whitespace
| * | Digestor explicit dependency should not contain trailing whitespaceBrian Alexander2012-12-212-1/+11
| | | | | | | | | | | | test for rails/rails#8586
* | | Move background jobs to the 'jobs' branch until fully baked. Not shipping ↵Jeremy Kemper2012-12-211-10/+0
| | | | | | | | | | | | with Rails 4.0.
* | | Merge pull request #7312 from krainboltgreene/http-token-parser-bugSteve Klabnik2012-12-211-6/+29
|\ \ \ | |/ / |/| | Http token parser bug
| * | Refactoring the token_and_options method to fix bugsKurtis Rainbolt-Greene2012-12-151-6/+29
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding a test for the equal trun bug Adding a test for the after equal trunc bug Adding a test for the slash bug Adding a test for the slash quote bug Adding a helper method for creating a sample request object with token Writing a method to create params array from raw params Writing a method to rewrite param values in the params Writing a method to get the token params from an authorization value Refactoring the token_and_options method to fix bugs Removing unnessecary test A constant for this shared regex seemed appropriate Wanting to split up this logic Adding small documentation pieces
* | Integrate Journey into Action DispatchAndrew White2012-12-1913-0/+1615
| | | | | | | | | | | | | | | | Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.
* | Remove obfuscation support from mail_to helperNick Reed2012-12-181-56/+0
| | | | | | | | | | | | Removes support for :encode, :replace_at, and :replace_dot options from the mail_to helper. Support for these options has been extracted to the 'actionview-encoded_mail_to' gem.
* | handle protocol option in stylesheet_link_tag and javascript_include_tagVasiliy Ermolovich2012-12-181-1/+23
|/ | | | closes #8388
* Merge pull request #8497 from acapilleri/conditional_cacheRafael Mendonça França2012-12-141-16/+16
|\ | | | | | | Removed :if / :unless conditions to fragment cache in favour of *cache_i...
| * Removed :if and :unless from fragment cache option in favour ofAngelo capilleri2012-12-141-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cache_if(condition, option, &block) and cache_unless(condition, option, &block). In the PR #8371 was introduced conditional options :if and :unless in the cache method. Example: <%= cache @model, if: some_condition(@model) do %> ... <%end%> This is a good feature but *cache_if* and and *cache_unless* are more concise and close to the standard of rails view helpers (ex: link_to_if and link_to_unless). Example: <%= cache_if condition, @model do %> ... <%end%>
* | Clear url helper methods when routes are reloadedAndrew White2012-12-141-0/+86
|/ | | | | Remove all the old url helper methods when clear! is called on the route set because it's possible that some routes have been removed.
* Fix rewinding in ActionDispatch::Request#raw_postMatt Venables2012-12-111-0/+7
| | | | | | | | | If env['RAW_POST_DATA'] is nil, #raw_post will attempt to set it to the result of #body (which will return env['rack.input'] if env['RAW_POST_DATA'] is nil). #raw_post will then attempt to rewind the result of another call to #body. Since env['RAW_POST_DATA'] has already been set, the result of #body is not env['rack.input'] anymore. This causes env['rack.input'] to never be rewound.
* Merge pull request #8476 from sheerun/fix/multipart-getRafael Mendonça França2012-12-101-0/+12
|\ | | | | Prevent raising EOFError on multipart GET request.
| * Prevent raising EOFError on multipart GET request.Adam Stankiewicz2012-12-101-0/+12
| | | | | | | | | | | | | | | | | | | | Such request can happen on Internet Explorer. When we redirect after multipart form submission, the request type is changed to GET, but Content-Type is preserved as multipart. GET request cannot have multipart body and that caused Rails to fail. It's similar fix to Rack's one: https://github.com/chneukirchen/rack/blob/8025a4ae9477d1e6231344c2b7d795aa9b3717b6/lib/rack/request.rb#L224
* | use _action callbacks in actionmailerFrancesco Rodriguez2012-12-081-5/+5
| |
* | add tests to aliased _filter callbacksFrancesco Rodriguez2012-12-071-0/+46
| |
* | use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-073-26/+24
| |
* | update documentation and code to use _action callbacksFrancesco Rodriguez2012-12-0711-18/+18
| |
* | Rename all action callbacks from *_filter to *_actionDavid Heinemeier Hansson2012-12-071-5/+5
|/
* Revert "Invert precedence of content in ActionDispatch::Static"Andrew White2012-12-071-10/+5
| | | | This reverts commit c59734f756b79c39486c45273d2cc5d42cd0c864.
* Invert precedence of content in ActionDispatch::StaticAndrew White2012-12-061-5/+10
| | | | | | | | | | This commit inverts the precedence in ActionDispatch::Static so that dynamic content will be served before static content. This is so that precompiled assets do not inadvertently get included when running in development mode - it should have no effect in production where static files are usually handled by the web server. Closes #6421
* Allow fragment cache to accept :if and :unless optionsFabrizio Regini2012-12-051-0/+64
| | | | [Stephen Ausman + Fabrizio Regini]
* Adding filter capability to ActionController logsFabrizio Regini2012-12-051-0/+22
|
* Fixed issue where routes with globs caused constraints on that glob toMaura Fitzgerald2012-12-041-0/+29
| | | | | | be ignored. A regular expression constraint gets overwritten when the routes.rb file is processed. Changed the overwriting to an ||= instead of an = assignment.
* Override <%== to always behave as literal text rather than toggling based on ↵Jeremy Kemper2012-12-032-4/+10
| | | | whether escaping is enabled. Fixes that existing plaintext email templates using <%== unexpectedly flipped to *escaping* HTML when #8235 was merged.
* More descriptive error when rendering a partial with `:layout => true`Yves Senn2012-12-021-0/+5
|
* hash filters should be accessed with symbols or stringsFrancesco Rodriguez2012-11-301-0/+25
|