Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 1 | -1/+13 |
| | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_helper.rb actionpack/test/template/form_helper_test.rb | ||||
* | Merge pull request #8108 from Casecommons/fix-multiple-and-index-in-instance-tag | Rafael Mendonça França | 2012-11-08 | 1 | -0/+13 |
| | | | | | | | Support :multiple option on input tags that also have :index Conflicts: actionpack/lib/action_view/helpers/tags/base.rb actionpack/lib/action_view/helpers/tags/collection_check_boxes.rb | ||||
* | Fix the build. | Rafael Mendonça França | 2012-04-29 | 1 | -2/+2 |
| | | | | | * The method for persisted records in 3-2-branch is 'PUT' * size is generated by default in inputs | ||||
* | Lazy load `default_form_builder` if it's passed as a string | Piotr Sarnacki | 2012-04-28 | 1 | -0/+17 |
| | | | | closes #3341 | ||||
* | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -6/+19 |
| | | | | | | hash. Closes #2492 and #5614 | ||||
* | Fixing issue #2492. ActionView::Base.field_error_proc doesn't call for label. | Andrey Samsonov | 2012-03-27 | 1 | -0/+22 |
| | | | | | | objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -0/+8 |
| | |||||
* | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 1 | -36/+36 |
| | | | | Closes #393 | ||||
* | don't set the hidden checkbox value if it's nil | Damien Mathieu | 2012-01-27 | 1 | -0/+8 |
| | |||||
* | check_box helper with :disabled => true generates disabled hidden field. ↵ | Tadas Tamošauskas | 2012-01-27 | 1 | -4/+3 |
| | | | | fixes #1953 | ||||
* | Add button_tag support to ActionView::Helpers::FormBuilder. | Will Farrington | 2011-12-11 | 1 | -1/+3 |
| | | | | | | | | | | This support is near-identical to the existing submit_tag support. Example: <%= form_for @post do |f| %> <%= f.button %> <% end %> | ||||
* | form_for with +:as+ option uses "action_as" as css class and id | Vasiliy Ermolovich | 2011-12-04 | 1 | -11/+11 |
| | |||||
* | test helpers in erb using erb | lest | 2011-11-30 | 1 | -3/+2 |
| | |||||
* | add namespace options to form_for | Vasiliy Ermolovich | 2011-11-27 | 1 | -0/+76 |
| | | | | | You can provide a namespace for your form to ensure uniqueness of id attributes on form elements. The namespace attribute will be prefixed with underscore on the generate HTML id | ||||
* | fix label with block in erb | lest | 2011-11-27 | 1 | -0/+7 |
| | |||||
* | Rely on a public contract between railties instead of accessing railtie ↵ | José Valim | 2011-11-23 | 1 | -1/+1 |
| | | | | methods directly. | ||||
* | Fix impractical I18n lookup in nested fields_for | Alexander Uvarov | 2011-11-17 | 1 | -0/+46 |
| | |||||
* | add tests for the case where size is explicitly passed to number_field helper | Vijay Dev | 2011-11-04 | 1 | -0/+4 |
| | |||||
* | Remove 'size' attribute from number_field form helper fixes #3454 | Waseem Ahmad | 2011-11-04 | 1 | -2/+2 |
| | | | | | f.number_field generates <input type="number", size="30"../> which is invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state | ||||
* | No need to use </form> here. It's already in whole_form block | Arun Agrawal | 2011-09-10 | 1 | -2/+1 |
| | |||||
* | Rename new method to_path to to_partial_path to avoid conflicts with ↵ | José Valim | 2011-08-01 | 1 | -1/+1 |
| | | | | File#to_path and similar. | ||||
* | Merge pull request #2034 from Casecommons/to_path | José Valim | 2011-07-28 | 1 | -0/+11 |
|\ | | | | | Allow ActiveModel-compatible instances to define their own partial paths | ||||
| * | Let ActiveModel instances define partial paths. | Grant Hutchins & Peter Jaros | 2011-07-25 | 1 | -0/+11 |
| | | | | | | | | | | | | Deprecate ActiveModel::Name#partial_path. Now you should call #to_path directly on ActiveModel instances. | ||||
* | | added test case for fix to issue #2094 | Dan Gebhardt | 2011-07-16 | 1 | -0/+17 |
|/ | |||||
* | Revert "Add method fields_for_with_index to FormHelper" | José Valim | 2011-07-01 | 1 | -125/+0 |
| | | | | | | | | This reverts commit 7c562d5e460d97b18e4f3367b3cfb13401732920. Conflicts: actionpack/lib/action_view/helpers/form_helper.rb | ||||
* | Use real hash model in nested fields_for with hash model test | Sam Pohlenz | 2011-06-22 | 1 | -4/+2 |
| | |||||
* | Test for extractable_options? within nested fields_for. | Sam Pohlenz | 2011-06-20 | 1 | -0/+18 |
| | | | | | This fixes an error when a record object that is a subclass of Hash is passed to fields_for, which is incorrectly interpreted as field options. | ||||
* | There are no snowmen here | David Lee | 2011-06-11 | 1 | -2/+2 |
| | |||||
* | Added missing assert to test checking form with namespaced isolated model ↵ | Piotr Sarnacki | 2011-06-07 | 1 | -5/+5 |
| | | | | and fixed helpers to work correctly in such case | ||||
* | Add method fields_for_with_index to FormHelper | Jorge Bejar | 2011-05-21 | 1 | -0/+125 |
| | |||||
* | Refactor fields_for to make the api more clear, and fix usage with non ↵ | Carlos Antonio da Silva | 2011-05-14 | 1 | -0/+14 |
| | | | | nested attributes and without object | ||||
* | Allow a label with the value option to have value-specific translations. | Jason Garber | 2011-04-27 | 1 | -1/+11 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Allow FormHelper#form_for to specify the :method as a direct option instead ↵ | David Heinemeier Hansson | 2011-03-26 | 1 | -2/+19 |
| | | | | of through the :html hash [DHH] | ||||
* | Add an option to FormBuilder to omit hidden field with id | Alexander Uvarov | 2011-03-04 | 1 | -0/+135 |
| | | | | | | [#4551 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove duplicated action pack tests added to fix issue with fields_for, ↵ | Carlos Antonio da Silva | 2011-02-12 | 1 | -42/+0 |
| | | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add tests showing the LH issue #6381: fields_for with inline blocks and ↵ | Carlos Antonio da Silva | 2011-02-08 | 1 | -1/+85 |
| | | | | | | nested attributes already persisted Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | removing generation of id in submit helper | Franco Brusatti | 2011-02-03 | 1 | -6/+6 |
| | | | | | | [#6369 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Remove deprecated form_for with strings or symbols" | José Valim | 2010-11-18 | 1 | -0/+33 |
| | | | | | | | | | | | | | | | | This code was not deprecated. What was deprecated is the following: form_for(:foo, @foo) Which now should be rewritten as: form_for(@foo, :as => :foo) The following format is valid: form_for(:foo) This reverts commit be797750e6ce866ea08307f63bf35304a965c8d4. | ||||
* | Remove deprecated form_for with strings or symbols | Leonardo Capillera | 2010-11-18 | 1 | -33/+0 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | fields_for should treat ActiveRecord::Relation as an array | Neeraj Singh | 2010-11-11 | 1 | -0/+21 |
| | | | | | | [#5795 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix test helpers to ensure get method forms are properly tested [#5753 ↵ | Aditya Sanghi | 2010-10-12 | 1 | -6/+9 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Make InstanceTagMethods#value_before_type_cast raise if the model ↵ | Santiago Pastorino | 2010-10-10 | 1 | -30/+0 |
| | | | | | | | | don't respond to attr_before_type_cast or attr method" And "Makes form_helper use overriden model accessors" This reverts commit 3ba8e3100548f10fce0c9784981a4589531476dd and fb0bd8c1092db51888ec4bb72af6c595e13c31fa. | ||||
* | added test for form_for with search_field | Aditya Sanghi | 2010-10-02 | 1 | -0/+15 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Rename duplicated test, and give it a correct name. Remove nonsense line. | Emilio Tagua | 2010-09-28 | 1 | -2/+1 |
| | |||||
* | Remove last tests with deprecated form_for and cleanup form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -63/+49 |
| | | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before. | ||||
* | Review most of the form_for deprecated tests, missing tests with index like [] | Carlos Antonio da Silva | 2010-09-26 | 1 | -405/+321 |
| | |||||
* | file_field propagates up multipart property even inside of fields_for | Santiago Pastorino | 2010-09-20 | 1 | -0/+21 |
| |