diff options
author | Andrey Samsonov <andrey.samsonov@gmail.com> | 2012-03-27 16:30:08 +0400 |
---|---|---|
committer | Andrey Samsonov <andrey.samsonov@gmail.com> | 2012-03-27 16:30:08 +0400 |
commit | 7111133371c08d2096cbcffa661860c9ea2c5813 (patch) | |
tree | 5565252684578cd38a178b64fdd7cb8001bb1656 /actionpack/test/template/form_helper_test.rb | |
parent | e31ec4700b9e1ca4726cff46fd68442fd6364b7b (diff) | |
download | rails-7111133371c08d2096cbcffa661860c9ea2c5813.tar.gz rails-7111133371c08d2096cbcffa661860c9ea2c5813.tar.bz2 rails-7111133371c08d2096cbcffa661860c9ea2c5813.zip |
Fixing issue #2492. ActionView::Base.field_error_proc doesn't call for label.
objectify_options method should be applied to the proper options arg.
See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
Diffstat (limited to 'actionpack/test/template/form_helper_test.rb')
-rw-r--r-- | actionpack/test/template/form_helper_test.rb | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index f9940ead58..fc7a37ec07 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -943,6 +943,28 @@ class FormHelperTest < ActionView::TestCase assert_dom_equal expected, output_buffer end + def test_form_for_label_error_wrapping_without_conventional_instance_variable + post = remove_instance_variable :@post + default_field_error_proc = ActionView::Base.field_error_proc + ActionView::Base.field_error_proc = Proc.new{ |html_tag, instance| "<div class='error'>#{html_tag}</div>".html_safe } + + form_for(post) do |f| + concat f.label(:author_name, :class => 'label') + concat f.text_field(:author_name) + concat f.submit('Create post') + end + + expected = whole_form("/posts/123", "edit_post_123" , "edit_post", :method => "put") do + "<div class='error'><label for='post_author_name' class='label'>Author name</label></div>" + + "<div class='error'><input name='post[author_name]' size='30' type='text' id='post_author_name' value='' /></div>" + + "<input name='commit' type='submit' value='Create post' />" + end + + assert_dom_equal expected, output_buffer + ensure + ActionView::Base.field_error_proc = default_field_error_proc + end + def test_form_for_with_namespace form_for(@post, :namespace => 'namespace') do |f| concat f.text_field(:title) |