Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Add block support to button_tag helper | Tom Stuart | 2011-02-12 | 1 | -4/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per the HTML 4.01 spec: Buttons created with the BUTTON element function just like buttons created with the INPUT element, but they offer richer rendering possibilities: the BUTTON element may have content. For example, a BUTTON element that contains an image functions like and may resemble an INPUT element whose type is set to "image", but the BUTTON element type allows content. Since rich content is the main purpose of the <button> element, it makes sense for the button_tag helper to accept a block. http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#the-button-element Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | |||||
* | | Make type="submit" the default for button_tag helper | Tom Stuart | 2011-02-12 | 1 | -6/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | "submit" is the default value of the <button> element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag is going to have a default, type="submit" is a more sensible choice than type="button". http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | |||||
* | | Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵ | Josh Kalderimis | 2011-02-10 | 2 | -18/+38 | |
| | | | | | | | | | | | | the same same. This also changes how safe_join works, if items or the separator are not html_safe they are html_escape'd, a html_safe string is always returned. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Revert "Removed Array#safe_join in AS core_ext and moved it to a view helper ↵ | José Valim | 2011-02-10 | 2 | -40/+18 | |
| | | | | | | | | | | | | | | | | with the same same." Applied the wrong version. This reverts commit 98c0c5db50a7679b3d58769ac22cb0a27a62c930. | |||||
* | | Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵ | Josh Kalderimis | 2011-02-10 | 2 | -18/+40 | |
| | | | | | | | | the same same. | |||||
* | | Be sure to javascript_escape the email address to prevent apostrophes ↵ | Michael Koziarski | 2011-02-08 | 1 | -5/+6 | |
| | | | | | | | | | | | | inadvertently causing javascript errors. This fixes CVE-2011-0446 | |||||
* | | fields_for with inline blocks and nested attributes already persisted does ↵ | Santiago Pastorino | 2011-02-08 | 1 | -10/+7 | |
| | | | | | | | | | | | | not render properly [#6381 state:committed] | |||||
* | | put authenticity_token option in parity w/ remote | Dan Pickett | 2011-02-06 | 1 | -4/+5 | |
| | | | | | | | | | | | | [#6228 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Added tests for form_for and an authenticity_token option. Added docs for ↵ | Timothy N. Tsvetkov | 2011-02-05 | 1 | -0/+18 | |
|/ | | | | | | | | for_for and authenticity_token option. Added section to form helpers guide about forms for external resources and new authenticity_token option for form_tag and form_for helpers. [#6228 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | removing generation of id in submit helper | Franco Brusatti | 2011-02-03 | 1 | -1/+1 | |
| | | | | | | [#6369 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Allow customization of form class for button_to | Andrei Bocan | 2011-02-01 | 1 | -3/+13 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | auto_link: avoid recognizing full width chars as a part of URI scheme | Akira Matsuda | 2011-02-01 | 1 | -1/+1 | |
| | | | | | | | | fixes regression by http://github.com/rails/rails/commit/133ada6ab0f0cb7bef2bd40dbc18f2d5bc6b964e [#5503 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Issue one Cache#read command instead of two in the case of a fragment cache hit | Christos Trochalakis | 2011-01-18 | 1 | -2/+2 | |
| | ||||||
* | button_tag should escape it content | Santiago Pastorino | 2011-01-12 | 1 | -1/+1 | |
| | ||||||
* | authenticity_token option for form_tag [#2988 state:resolved] | Jakub Kuźma | 2011-01-09 | 1 | -5/+17 | |
| | ||||||
* | Improve select helpers by allowing a selected value of false. This is ↵ | John Allison | 2011-01-09 | 1 | -1/+1 | |
| | | | | useful when using a select helper with a boolean attribute, and the attribute is false. (e.g. f.select :allow_comments) | |||||
* | HTML5 button_tag helper | Rizwan Reza | 2011-01-09 | 1 | -0/+50 | |
| | | | | | | | | This tag is similar in nature to submit_tag, but allows more control. It also doesn't submit if submit type isn't used, allowing JavaScript to control the flow where required. For more information: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-button-element | |||||
* | Remove InstanceTagMethods module and define the methods inside the ↵ | Santiago Pastorino | 2011-01-09 | 1 | -7/+2 | |
| | | | | InstanceTag class | |||||
* | Merge branch 'master' of github.com:rails/rails | Xavier Noria | 2010-12-24 | 2 | -4/+10 | |
|\ | ||||||
| * | Allow registering javascript/stylesheet_expansions to existing symbols | Santiago Pastorino | 2010-12-22 | 2 | -4/+10 | |
| | | ||||||
* | | More minor edits. | Rizwan Reza | 2010-12-23 | 1 | -5/+5 | |
| | | ||||||
* | | Revised documentation for cache_helper. | Rizwan Reza | 2010-12-23 | 1 | -12/+10 | |
|/ | ||||||
* | Do not use the same hash instance for expansions [#6114 state:resolved] | Piotr Sarnacki | 2010-12-22 | 1 | -1/+3 | |
| | | | | | Using the same hash instance makes using the same expansions for both javascripts and stylesheets. | |||||
* | Fixed number_with_precision rounding error [#6182 state:resolved] | Don Wilson | 2010-12-18 | 1 | -2/+3 | |
| | ||||||
* | Revert "Fixed number_with_precision rounding error [#6182 state:resolved]" | Piotr Sarnacki | 2010-12-17 | 1 | -3/+2 | |
| | | | | This reverts commit 006ec77e60163d57d655479602230672d98e0f10. | |||||
* | Fixed number_with_precision rounding error [#6182 state:resolved] | Don Wilson | 2010-12-17 | 1 | -2/+3 | |
| | ||||||
* | eternal confusion! fixed doco to inform correctly | Aditya Sanghi | 2010-12-15 | 1 | -1/+1 | |
| | ||||||
* | Added :placeholder option to ActionView::Helpers::FormTagHelper text_field_tag | Ben Mills | 2010-12-13 | 1 | -0/+4 | |
| | ||||||
* | Remove nodoc from FormBuilder because the methods inside are public API methods | Ryan Bigg | 2010-12-13 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2010-12-05 | 1 | -1/+1 | |
|\ | ||||||
| * | Added a space before "do" keyword | Akira Matsuda | 2010-11-28 | 1 | -1/+1 | |
| | | ||||||
* | | Allow back passing :rescue_format => nil and test added | Santiago Pastorino | 2010-12-04 | 1 | -1/+1 | |
| | | ||||||
* | | Use ||= here | Santiago Pastorino | 2010-12-04 | 1 | -1/+1 | |
| | | ||||||
* | | Make TranslationHelper#translate use the :rescue_format option in I18n 0.5.0 | Sven Fuchs | 2010-12-04 | 1 | -7/+25 | |
|/ | | | | | | Don't catch exceptions here. Instead only declare that we want exceptions to be rescued as :html, but also let users configure reactions to exceptions in I18n. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | No need to return anything | Neeraj Singh | 2010-11-24 | 1 | -1/+0 | |
| | ||||||
* | class inheritable attributes is used no more! all internal use of class ↵ | Josh Kalderimis | 2010-11-20 | 1 | -2/+2 | |
| | | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix AssetIncludeTag ensuring that files are in the wrong directory [#6015 ↵ | Henning Koch | 2010-11-19 | 1 | -3/+3 | |
| | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Revert "Remove deprecated form_for with strings or symbols" | José Valim | 2010-11-18 | 1 | -3/+9 | |
| | | | | | | | | | | | | | | | | This code was not deprecated. What was deprecated is the following: form_for(:foo, @foo) Which now should be rewritten as: form_for(@foo, :as => :foo) The following format is valid: form_for(:foo) This reverts commit be797750e6ce866ea08307f63bf35304a965c8d4. | |||||
* | Remove deprecated form_for with strings or symbols | Leonardo Capillera | 2010-11-18 | 1 | -9/+3 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | changed asset_timestamps_cache to asset_ids_cache, added an rdoc comment to ↵ | Josh Kalderimis | 2010-11-16 | 1 | -15/+19 | |
| | | | | the new public api, and updated the railtie | |||||
* | corrected the AV railtie to use the new home for cache_asset_timestamps, and ↵ | Josh Kalderimis | 2010-11-16 | 3 | -74/+46 | |
| | | | | merged asset id caching and asset paths together. | |||||
* | reorganised the the common asset helpers module into a class and have it ↵ | Josh Kalderimis | 2010-11-16 | 6 | -125/+128 | |
| | | | | include the id caching module, this class is now shared from the view instance to the asset include tag helpers (js and css) | |||||
* | incorporated most of the feedback from José | Josh Kalderimis | 2010-11-16 | 6 | -288/+279 | |
| | ||||||
* | reduced duplication between the javascript and stylesheet asset tag methods, ↵ | Josh Kalderimis | 2010-11-16 | 8 | -264/+312 | |
| | | | | also split the asset id caching methods into a separate module for easy inclusion and use by the asset include tag class and base asset tag helpers | |||||
* | separated the asset id methods to a separate module, removed some dupliation ↵ | Josh Kalderimis | 2010-11-16 | 6 | -413/+486 | |
| | | | | with the various path methods, and moved the base asset tag methods to a base module so the asset id module can play nice with the path generation | |||||
* | split the javascript and stylesheet tag helpers into separate files as a ↵ | Josh Kalderimis | 2010-11-16 | 3 | -313/+348 | |
| | | | | precusor before removing the duplication between the two | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2010-11-15 | 1 | -0/+18 | |
|\ | ||||||
| * | Add a note to TextHelpers making explicit their default behavior of not ↵ | José Valim | 2010-11-08 | 1 | -0/+18 | |
| | | | | | | | | escaping but sanitizing. | |||||
* | | Add f.submit to forms just to show the most common use case | Santiago Pastorino | 2010-11-14 | 1 | -0/+12 | |
| | | ||||||
* | | Merge branch 'spastorino-master' | Santiago Pastorino | 2010-11-14 | 1 | -2/+2 | |
|\ \ |