diff options
| author | Don Wilson <robert.don.wilson@gmail.com> | 2010-12-16 11:37:11 -0200 |
|---|---|---|
| committer | Piotr Sarnacki <drogus@gmail.com> | 2010-12-17 11:32:19 +0100 |
| commit | 006ec77e60163d57d655479602230672d98e0f10 (patch) | |
| tree | a0a8e48f052ed8f8322f38a40e117f3044945028 /actionpack/lib/action_view/helpers | |
| parent | 3b9120fa52b76fb8591fe1d0db85d1a940e867d0 (diff) | |
| download | rails-006ec77e60163d57d655479602230672d98e0f10.tar.gz rails-006ec77e60163d57d655479602230672d98e0f10.tar.bz2 rails-006ec77e60163d57d655479602230672d98e0f10.zip | |
Fixed number_with_precision rounding error [#6182 state:resolved]
Diffstat (limited to 'actionpack/lib/action_view/helpers')
| -rw-r--r-- | actionpack/lib/action_view/helpers/number_helper.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/helpers/number_helper.rb b/actionpack/lib/action_view/helpers/number_helper.rb index a9400c347f..650828052f 100644 --- a/actionpack/lib/action_view/helpers/number_helper.rb +++ b/actionpack/lib/action_view/helpers/number_helper.rb @@ -270,12 +270,13 @@ module ActionView digits, rounded_number = 1, 0 else digits = (Math.log10(number.abs) + 1).floor - rounded_number = BigDecimal.new((number / 10 ** (digits - precision)).to_s).round.to_f * 10 ** (digits - precision) + rounded_number = (BigDecimal.new(number.to_s) / 10 ** (digits - precision)).round.to_f * 10 ** (digits - precision) + digits = (Math.log10(rounded_number.abs) + 1).floor # After rounding, the number of digits may have changed end precision -= digits precision = precision > 0 ? precision : 0 #don't let it be negative else - rounded_number = BigDecimal.new((number * (10 ** precision)).to_s).round.to_f / 10 ** precision + rounded_number = BigDecimal.new(number.to_s).round(precision).to_f end formatted_number = number_with_delimiter("%01.#{precision}f" % rounded_number, options) if strip_insignificant_zeros |