Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | refactoring to use fewer intermediate variables | Aaron Patterson | 2010-10-04 | 1 | -11/+12 |
| | |||||
* | cleaning up more crazy! | Aaron Patterson | 2010-10-04 | 1 | -3/+3 |
| | |||||
* | deleting more crazy | Aaron Patterson | 2010-10-04 | 1 | -6/+4 |
| | |||||
* | dry up some crazy codes | Aaron Patterson | 2010-10-04 | 1 | -8/+6 |
| | |||||
* | Performance: refactor convert_options_to_data_attributes. | thedarkone | 2010-09-27 | 1 | -10/+14 |
| | |||||
* | Remove dead code. | thedarkone | 2010-09-27 | 1 | -2/+2 |
| | |||||
* | Clean up url_for. | thedarkone | 2010-09-27 | 1 | -3/+1 |
| | |||||
* | Start cleanup of deprecations in ActionView | Carlos Antonio da Silva | 2010-09-06 | 1 | -6/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor RoutesProxy to avoid using _with_routes in helpers | Piotr Sarnacki | 2010-09-03 | 1 | -3/+5 |
| | |||||
* | Fix generating urls with mounted helpers in view context | Piotr Sarnacki | 2010-09-03 | 1 | -1/+3 |
| | | | | | | | | | | There were actually 2 problems with this one: * script_name was added to options as a string and then it was used in RouteSet#url_for with usage of <<, which was changing the original script_name * the second issue was with _with_routes method. It was called in RoutesProxy to modify _routes in view_context, but url_helpers in views is just delegating it to controller, so another _with_routes call is needed there | ||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-09-03 | 1 | -1/+1 |
|\ | |||||
| * | fix typo(?) | Akira Matsuda | 2010-09-01 | 1 | -1/+1 |
| | | |||||
* | | Remove unnecessary code from UrlHelper#link_to. | yury | 2010-09-01 | 1 | -7/+2 |
|/ | | | | | | convert_options_to_data_attributes always returns not nil stringified html_options [#5445 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix API docs for button_to options | Jaime Iniesta | 2010-08-31 | 1 | -2/+3 |
| | |||||
* | Restore consistency with the rest of the doc. | Rémy Coutable | 2010-08-25 | 1 | -2/+2 |
| | |||||
* | Fixed a missing simple quote. | Rémy Coutable | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | options could be of any kind of Hash (Hash, HashWithIndifferentAccess or ↵ | Santiago Pastorino | 2010-07-21 | 1 | -1/+1 |
| | | | | OrderedHash) this way we keep the properties of the options passed as an argument | ||||
* | Use capture instead of yield in link_to_unless. | José Valim | 2010-07-21 | 1 | -1/+1 |
| | | | | [#5162 state:resolved] | ||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | s/escape_once/html_escape/, since html safety is the contract that now says ↵ | Xavier Noria | 2010-06-30 | 1 | -14/+17 |
| | | | | whether something has to be escaped | ||||
* | url_for no longer escapes HTML, the :escape option is also gone | Xavier Noria | 2010-06-30 | 1 | -16/+5 |
| | | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc. | ||||
* | Restores the escaping of urls generated from hashes. [#4765 state:resolved] | Andrew White | 2010-06-28 | 1 | -1/+1 |
| | | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Action View is now titled. | Rizwan Reza | 2010-06-21 | 1 | -1/+1 |
| | |||||
* | Added titles and description. | Rizwan Reza | 2010-06-16 | 1 | -0/+1 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | wycats | 2010-04-26 | 1 | -1/+1 |
|\ | |||||
| * | HWIA symbolize_keys now returns a hash so no need to do this anymore | Santiago Pastorino | 2010-04-22 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Allow :remote => false to be passed to link_to | Nicolas Sanguinetti | 2010-04-22 | 1 | -3/+1 |
|/ | | | | | | | And add tests for `button_to` and `form_tag` which currently behave as expected, so we avoid a regression. Signed-off-by: wycats <wycats@gmail.com> | ||||
* | url_for now works with HashWithIndifferentAccess ht jay [#4391 state:committed] | Santiago Pastorino | 2010-04-21 | 1 | -1/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | mail_to with :encode => :javascript now outputs safe html | Sam Elliott | 2010-04-16 | 1 | -1/+1 |
| | | | | Signed-off-by: Carl Lerche <carllerche@mac.com> | ||||
* | Consistently use lowercase instead of camelCase for all JS class names in Rails | David Heinemeier Hansson | 2010-04-08 | 1 | -5/+5 |
| | |||||
* | * Change the object used in routing constraints to be an instance of | wycats | 2010-04-03 | 1 | -1/+6 |
| | | | | | | | | | | | ActionDispatch::Request rather than Rack::Request. * Changed ActionDispatch::Request#method to return a String, to be compatible with the Rack::Request superclass. * Changed ActionDispatch::Request#method to return the original method in the case of methodoverride and #request_method not to, to be compatible with Rack::Request | ||||
* | Refactored url_for in AV to have its own instances of the helpers instead of ↵ | wycats | 2010-04-03 | 1 | -15/+37 |
| | | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win) | ||||
* | Merge branch 'master' into docrails | wycats | 2010-03-26 | 1 | -3/+9 |
|\ | |||||
| * | Remove data-url support from url_helper [#4236 state:resolved] | Denis Odorcic | 2010-03-21 | 1 | -2/+0 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Fix missing require | wycats | 2010-03-16 | 1 | -0/+1 |
| | | |||||
| * | Do not always include the named URL helpers into AC::Base and AV::Base. | Carl Lerche | 2010-03-16 | 1 | -0/+7 |
| | | |||||
| * | Fix link_to with block | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | | |||||
* | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-15 | 1 | -1/+1 |
|\| | |||||
| * | Making escaped things more readable | Santiago Pastorino | 2010-03-14 | 1 | -1/+1 |
| | | |||||
* | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-12 | 1 | -13/+10 |
|\| | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/base.rb railties/lib/rails/configuration.rb railties/lib/rails/log_subscriber.rb | ||||
| * | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 1 | -2/+3 |
| | | |||||
| * | Use ActionDispatch::Routing everywhere | Martin Schürrer | 2010-02-21 | 1 | -1/+1 |
| | | |||||
| * | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 1 | -1/+1 |
| | | | | | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | ||||
| * | Remove empty line and trailing hash, breaks documentation generation | Dirkjan Bussink | 2010-02-19 | 1 | -2/+0 |
| | | | | | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
| * | Explicit html_escape removed when not needed | Santiago Pastorino and José Ignacio Costa | 2010-02-14 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
| * | html_escape mail_to when encode javascript and not hex | Santiago Pastorino and José Ignacio Costa | 2010-02-14 | 1 | -5/+3 |
| | | | | | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
| * | content_tag should escape its input | Bruno Michel | 2010-02-14 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | | Updated documentation for block helpers in url_helper.rb | Jeroen van Dijk | 2010-03-12 | 1 | -1/+1 |
|/ | |||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 1 | -4/+4 |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | ||||
* | UJS documentation. | Stefan Penner | 2010-01-31 | 1 | -25/+30 |
| |