diff options
| author | Andrew White <andyw@pixeltrix.co.uk> | 2010-06-27 09:16:46 +0100 |
|---|---|---|
| committer | José Valim <jose.valim@gmail.com> | 2010-06-28 15:35:38 +0200 |
| commit | 0b6ce3422370647cad3e91263a291f69b313d65b (patch) | |
| tree | fdb4fd6678f761880e387a830f59b4d6f15e8668 /actionpack/lib/action_view/helpers/url_helper.rb | |
| parent | e717631a8481935e8ac1eeb2445da341bdd4c868 (diff) | |
| download | rails-0b6ce3422370647cad3e91263a291f69b313d65b.tar.gz rails-0b6ce3422370647cad3e91263a291f69b313d65b.tar.bz2 rails-0b6ce3422370647cad3e91263a291f69b313d65b.zip | |
Restores the escaping of urls generated from hashes. [#4765 state:resolved]
HTML specifications recommend the escaping of urls in web pages,
which url_for does by default for string urls and consquently
urls generated by path helpers as these return strings.
Hashes passed to url_for are not escaped by default and this
commit reverses this default so that they are escaped.
Undoes the changes of this commit:
http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944
Signed-off-by: José Valim <jose.valim@gmail.com>
Diffstat (limited to 'actionpack/lib/action_view/helpers/url_helper.rb')
| -rw-r--r-- | actionpack/lib/action_view/helpers/url_helper.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/lib/action_view/helpers/url_helper.rb b/actionpack/lib/action_view/helpers/url_helper.rb index 6af11e632f..cbde9b94a7 100644 --- a/actionpack/lib/action_view/helpers/url_helper.rb +++ b/actionpack/lib/action_view/helpers/url_helper.rb @@ -104,7 +104,7 @@ module ActionView options when Hash options = { :only_path => options[:host].nil? }.update(options.symbolize_keys) - escape = options.key?(:escape) ? options.delete(:escape) : false + escape = options.key?(:escape) ? options.delete(:escape) : true super when :back escape = false |