Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | reuse the ast we already made | Aaron Patterson | 2014-05-29 | 1 | -9/+10 |
| | |||||
* | use a parser to extract the group parts from the path | Aaron Patterson | 2014-05-29 | 2 | -3/+7 |
| | |||||
* | pass the parsed parameters through the methods so we don't reparse or | Aaron Patterson | 2014-05-29 | 1 | -38/+34 |
| | | | | require caching code | ||||
* | Merge branch 'master' into mapper | Aaron Patterson | 2014-05-29 | 2 | -6/+6 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing | ||||
| * | Merge pull request #15061 from tgxworld/remove_unnecessary_include | Matthew Draper | 2014-05-29 | 1 | -6/+0 |
| |\ | | | | | | | Remove unnecessary include for integration tests. | ||||
| | * | Remove unnecessary include for integration tests. | Guo Xiang Tan | 2014-05-11 | 1 | -6/+0 |
| | | | |||||
| * | | Add missing `:param` option from the docs for Mapper#match [ci skip] | Zachary Scott | 2014-05-29 | 1 | -0/+6 |
| | | | | | | | | | | | | Option discovered by @zackperdue in #14741, implemented in #5581. | ||||
* | | | "controllers" should be a valid path name | Aaron Patterson | 2014-05-29 | 1 | -1/+1 |
| | | | |||||
* | | | controllers with slash names are also not supported, so we can reuse the message | Aaron Patterson | 2014-05-28 | 1 | -6/+2 |
| | | | |||||
* | | | only validate controllers | Aaron Patterson | 2014-05-28 | 1 | -15/+17 |
| | | | |||||
* | | | golf down a bit | Aaron Patterson | 2014-05-28 | 1 | -8/+4 |
| | | | |||||
* | | | only error handling between controller and action is the same | Aaron Patterson | 2014-05-28 | 1 | -18/+16 |
| | | | |||||
* | | | move nil check to a method that yields to a block if the value is not nil | Aaron Patterson | 2014-05-28 | 1 | -17/+16 |
| | | | |||||
* | | | translate action / controller to the desired object | Aaron Patterson | 2014-05-28 | 1 | -12/+11 |
| | | | |||||
* | | | only one nil check on the action variable | Aaron Patterson | 2014-05-28 | 1 | -10/+8 |
| | | | |||||
* | | | change to case / when on types | Aaron Patterson | 2014-05-28 | 1 | -8/+7 |
| | | | |||||
* | | | only do one nil check against the controller | Aaron Patterson | 2014-05-28 | 1 | -9/+9 |
| | | | |||||
* | | | extract controller and action parsing to a method | Aaron Patterson | 2014-05-28 | 1 | -19/+26 |
| | | | |||||
* | | | we don't need the call to presence. that is my present, to you! | Aaron Patterson | 2014-05-28 | 1 | -1/+1 |
| | | | |||||
* | | | swtich to returning early if to responds to call | Aaron Patterson | 2014-05-28 | 1 | -35/+32 |
| | | | |||||
* | | | return early if we have a valid controller name | Aaron Patterson | 2014-05-28 | 1 | -5/+5 |
| | | | |||||
* | | | trade 2 is_a? checks for a nil check | Aaron Patterson | 2014-05-28 | 1 | -2/+4 |
| | | | |||||
* | | | invert logic to remove nil? and exclude? checks (use ruby rather than AS ↵ | Aaron Patterson | 2014-05-28 | 1 | -6/+6 |
| | | | | | | | | | | | | when possible | ||||
* | | | fewer blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+4 |
| | | | |||||
* | | | reduce action.blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+6 |
| | | | |||||
* | | | reduce blank? checks | Aaron Patterson | 2014-05-28 | 1 | -4/+9 |
| | | | |||||
* | | | extract controller checks to methods | Aaron Patterson | 2014-05-28 | 1 | -19/+26 |
| | | | |||||
* | | | set defaults at the top so we can avoid the ||= test | Aaron Patterson | 2014-05-28 | 1 | -6/+9 |
|/ / | |||||
* | | rm dead code | Aaron Patterson | 2014-05-27 | 1 | -5/+0 |
| | | |||||
* | | PARAMETERS_KEY is only used in the request, so move the constant there | Aaron Patterson | 2014-05-27 | 2 | -4/+4 |
| | | |||||
* | | Merge branch 'constraints' | Aaron Patterson | 2014-05-27 | 9 | -70/+71 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb | ||||
| * | | rm reset_parameters because we automatically do it from 9ca4839a | Aaron Patterson | 2014-05-27 | 2 | -6/+0 |
| | | | |||||
| * | | move path_parameter encoding check to the request object | Aaron Patterson | 2014-05-27 | 3 | -18/+13 |
| | | | |||||
| * | | dispatcher doesn't need `call` anymore | Aaron Patterson | 2014-05-27 | 1 | -4/+0 |
| | | | |||||
| * | | call `serve` with the request on dispatchers | Aaron Patterson | 2014-05-27 | 1 | -9/+10 |
| | | | |||||
| * | | constraints class does not need the request class anymore | Aaron Patterson | 2014-05-27 | 1 | -4/+4 |
| | | | |||||
| * | | give all endpoints a superclass | Aaron Patterson | 2014-05-27 | 4 | -22/+40 |
| | | | |||||
| * | | we do not need to cache rack_app | Aaron Patterson | 2014-05-26 | 1 | -9/+3 |
| | | | |||||
| * | | a redirect is not a dispatcher by definition, so eliminate test | Aaron Patterson | 2014-05-26 | 1 | -1/+1 |
| | | | |||||
| * | | push is_a check up to where the Constraints object is allocated | Aaron Patterson | 2014-05-26 | 2 | -6/+11 |
| | | | |||||
| * | | pass the request object to the application | Aaron Patterson | 2014-05-25 | 2 | -4/+3 |
| | | | |||||
| * | | pass a request to `matches?` so we can avoid creating excess requests | Aaron Patterson | 2014-05-25 | 2 | -7/+6 |
| | | | |||||
| * | | nothing is passed to `rack_app` anymore, so rm the params | Aaron Patterson | 2014-05-25 | 1 | -1/+1 |
| | | | |||||
| * | | one fewer is_a check | Aaron Patterson | 2014-05-25 | 1 | -4/+3 |
| | | | |||||
| * | | Constraints#app should never return another Constraints object, so switch to ↵ | Aaron Patterson | 2014-05-25 | 1 | -1/+1 |
| | | | | | | | | | | | | if statement | ||||
| * | | eliminate dispatcher is_a checks | Aaron Patterson | 2014-05-24 | 1 | -8/+14 |
| | | | |||||
| * | | push is_a?(Dispatcher) check in to one place | Aaron Patterson | 2014-05-24 | 3 | -14/+11 |
| | | | |||||
| * | | Always construct route objects with Constraint objects | Aaron Patterson | 2014-05-24 | 3 | -9/+7 |
| | | | |||||
* | | | Merge pull request #15321 from ↵ | Santiago Pastorino | 2014-05-27 | 1 | -1/+4 |
|\ \ \ | | | | | | | | | | | | | | | | | tgxworld/only_find_routes_as_heads_for_head_request Call get_routes_as_head only on HEAD requests. | ||||
| * | | | Call get_routes_as_head only on HEAD requests. | Guo Xiang Tan | 2014-05-25 | 1 | -1/+4 |
| | | | |