aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2014-05-28 15:56:12 -0700
committerAaron Patterson <aaron.patterson@gmail.com>2014-05-28 15:56:12 -0700
commit996e9f568cba400cf82ececbc69ea797b863644b (patch)
treed5772a0e3988773ee3e05d933da9cb88a68d3e1d /actionpack/lib/action_dispatch
parent60ae50507d587e3663794fb8bdd0f967e5368695 (diff)
downloadrails-996e9f568cba400cf82ececbc69ea797b863644b.tar.gz
rails-996e9f568cba400cf82ececbc69ea797b863644b.tar.bz2
rails-996e9f568cba400cf82ececbc69ea797b863644b.zip
trade 2 is_a? checks for a nil check
Diffstat (limited to 'actionpack/lib/action_dispatch')
-rw-r--r--actionpack/lib/action_dispatch/routing/mapper.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/actionpack/lib/action_dispatch/routing/mapper.rb b/actionpack/lib/action_dispatch/routing/mapper.rb
index e8dd54b3f0..528bcd4189 100644
--- a/actionpack/lib/action_dispatch/routing/mapper.rb
+++ b/actionpack/lib/action_dispatch/routing/mapper.rb
@@ -293,11 +293,13 @@ module ActionDispatch
raise ArgumentError, message
end
- if controller.is_a?(String) && controller =~ %r{\A/}
+ return unless controller
+
+ if controller =~ %r{\A/}
raise ArgumentError, "controller name should not start with a slash"
end
- if controller.is_a?(String) && controller !~ /\A[a-z_0-9\/]*\z/
+ if controller !~ /\A[a-z_0-9\/]*\z/
message = "'#{controller}' is not a supported controller name. This can lead to potential routing problems."
message << " See http://guides.rubyonrails.org/routing.html#specifying-a-controller-to-use"
raise ArgumentError, message