Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Got overhead down from 127 to 85. All tests pass: | Yehuda Katz | 2009-08-11 | 1 | -36/+56 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string. | |||||
* | This change causes some failing tests, but it should be possible to make ↵ | Yehuda Katz | 2009-08-11 | 1 | -11/+12 | |
| | | | | them pass with minimal performance impact. | |||||
* | Allow to configure trusted proxies via ↵ | Felipe Talavera | 2009-08-09 | 1 | -2/+2 | |
| | | | | | | ActionController::Base.trusted_proxies [#2126 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add :redirect to the testable RJS statements [#2612 state:resolved] | Jon Wood | 2009-08-09 | 1 | -3/+10 | |
| | | | | | | | Example : assert_select_rjs :redirect, root_path Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Remove legacy processing and content_length | Yehuda Katz | 2009-08-02 | 1 | -40/+10 | |
| | | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status | |||||
* | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 1 | -5/+19 | |
| | | | | * Significantly simplifies setting and modifying cache control in other areas | |||||
* | Remove last TODO. | José Valim | 2009-07-29 | 1 | -1/+1 | |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | |||||
* | Remove Mime::ALL from Mime::SET. | José Valim | 2009-07-29 | 1 | -2/+4 | |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | |||||
* | Refactor even more Responder. Move mime negotiation to request and added ↵ | José Valim | 2009-07-29 | 1 | -8/+34 | |
| | | | | | | respond_to class method. Signed-off-by: Yehuda Katz <wycats@gmail.com> | |||||
* | Small changes to get 1.9 passing (for the most part) | Yehuda Katz | 2009-06-23 | 1 | -1/+1 | |
| | ||||||
* | Fixing pending tests and fixed some formats / partial rendering semantics | Yehuda Katz + Carl Lerche | 2009-06-17 | 2 | -7/+17 | |
| | ||||||
* | Finish making things pass with updated internal content_type semantics | Yehuda Katz + Carl Lerche | 2009-06-15 | 1 | -45/+11 | |
| | ||||||
* | ActionPack components should no longer have undeclared dependencies. | Yehuda Katz + Carl Lerche | 2009-06-08 | 2 | -0/+3 | |
| | | | | | | | * Tests can be run in isolation * Dependencies added * A few tests modified to avoid depending on AS deps not depended on my files they were testing | |||||
* | Depend on Hash#diff extension | Jeremy Kemper | 2009-05-30 | 1 | -0/+2 | |
| | ||||||
* | Revert "Only save the session if we're actually writing to it [#2703 ↵ | Joshua Peek | 2009-05-30 | 1 | -10/+1 | |
| | | | | | | state:resolved]" This reverts commit dd98280e38d640f5724887cf8a715b79f0439d2d. | |||||
* | Only save the session if we're actually writing to it [#2703 state:resolved] | Johan Sörensen | 2009-05-28 | 1 | -1/+10 | |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Make the default 500 Internal Server Error page more friendly. Many people ↵ | Hongli Lai (Phusion) | 2009-05-27 | 1 | -1/+4 | |
| | | | | | | don't know they're supposed to look in the log files. [#2716 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Got all the dispatch tests running on new base | Carl Lerche | 2009-05-26 | 1 | -5/+6 | |
| | ||||||
* | Don't want Rack's Content-Type default header though | Jeremy Kemper | 2009-05-24 | 1 | -2/+3 | |
| | ||||||
* | Construct a single HeaderHash. Speed up assign_default_content_type_and_charset | Jeremy Kemper | 2009-05-24 | 1 | -4/+10 | |
| | ||||||
* | Speed up Request#formats | Jeremy Kemper | 2009-05-23 | 1 | -6/+14 | |
| | ||||||
* | Slightly modify things to get content type matching working without breaking ↵ | Yehuda Katz | 2009-05-23 | 1 | -2/+8 | |
| | | | | other code | |||||
* | Remove some response content type concepts from ActionView | Yehuda Katz + Carl Lerche | 2009-05-21 | 2 | -2/+2 | |
| | ||||||
* | Fixed new_base tests on ruby 1.9 | Yehuda Katz + Carl Lerche | 2009-05-20 | 1 | -1/+1 | |
| | ||||||
* | Wrap string body in an array | Jeremy Kemper | 2009-05-20 | 1 | -1/+1 | |
| | ||||||
* | Temporarily bundle rack-test while MockSession is baking | Joshua Peek | 2009-05-19 | 7 | -0/+641 | |
| | ||||||
* | Allow ParamsParser to parse YAML from the request body IO directly | Brian Lopez | 2009-05-17 | 1 | -1/+1 | |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Extract generic callbacks middleware from dispatcher | Joshua Peek | 2009-05-17 | 1 | -0/+40 | |
| | ||||||
* | Merge Failsafe middleware into ShowExceptions | Joshua Peek | 2009-05-17 | 2 | -98/+40 | |
| | ||||||
* | Add support for parsing XML and JSON from an IO as well as a string [#2659 ↵ | Brian Lopez | 2009-05-17 | 1 | -5/+3 | |
| | | | | | | state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Instead of checking Rails.env.test? in Failsafe middleware, check ↵ | Bryan Helmkamp | 2009-05-16 | 1 | -3/+2 | |
| | | | | env["rails.raise_exceptions"] | |||||
* | Cherry-picking Active Support extensions | Jeremy Kemper | 2009-05-14 | 1 | -2/+4 | |
| | ||||||
* | Cherry-pick core extensions | Jeremy Kemper | 2009-05-13 | 3 | -0/+3 | |
| | ||||||
* | Implemented redirects and partial rendering in new base. | Yehuda Katz + Carl Lerche | 2009-05-12 | 1 | -6/+0 | |
| | ||||||
* | Merge branch 'master' into wip_abstract_controller | Yehuda Katz + Carl Lerche | 2009-05-11 | 16 | -45/+304 | |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb | |||||
| * | Wrap dispatcher callbacks around the whole middleware chain. Kill ↵ | Joshua Peek | 2009-05-03 | 1 | -14/+0 | |
| | | | | | | | | unnecessary Reloader middleware. | |||||
| * | Show lazy middleware args in pretty print | Joshua Peek | 2009-05-03 | 1 | -2/+1 | |
| | | ||||||
| * | Extract ActionController rescue templates into Rescue and ShowExceptions ↵ | Joshua Peek | 2009-05-02 | 11 | -7/+281 | |
| | | | | | | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. | |||||
| * | Switch functional tests to run through the rack interface instead of process | Joshua Peek | 2009-05-02 | 1 | -0/+5 | |
| | | ||||||
| * | Functional test runner finalizes response just like the integration test ↵ | Joshua Peek | 2009-05-02 | 2 | -13/+7 | |
| | | | | | | | | | | runner. In both runners, the @response object will now behave the same. Some functional tests will need to be updated if they are relying on preprocessed data on the response. | |||||
| * | Deprecate assert_redirect_to's partial hash matching | Joshua Peek | 2009-05-02 | 3 | -9/+8 | |
| | | ||||||
* | | Renamed Base2 to Base and don't require old action_controller for new Base | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -2/+0 | |
|/ | ||||||
* | Rename vendor/rack to vendor/rack-1.1.pre | Pratik Naik | 2009-05-01 | 51 | -0/+0 | |
| | ||||||
* | Vendor Rack edge ( commit : 815342a8e15db564b766f209ffb1e340233f064f ) | Pratik Naik | 2009-05-01 | 51 | -0/+5412 | |
| | ||||||
* | Move TestRequest#query_parameters into AD TestRequest | Joshua Peek | 2009-04-30 | 2 | -1/+5 | |
| | ||||||
* | Move TestRequest cookies accessor into AD TestRequest | Joshua Peek | 2009-04-30 | 1 | -3/+21 | |
| | ||||||
* | Depend on unreleased rack 1.1 | Joshua Peek | 2009-04-30 | 3 | -331/+0 | |
| | ||||||
* | Start moving TestRequest and TestResponse into ActionDispatch | Joshua Peek | 2009-04-30 | 5 | -73/+207 | |
| | ||||||
* | Vendor new Rack::Mock changes | Joshua Peek | 2009-04-30 | 5 | -148/+332 | |
| | ||||||
* | Group integration test helpers and delegate other helpers to request and ↵ | Joshua Peek | 2009-04-30 | 1 | -0/+9 | |
| | | | | response objects |