Start moving TestRequest and TestResponse into ActionDispatch

5 files changed, 207 insertions, 73 deletions

diff --git a/actionpack/lib/action_dispatch/extensions/rack/utils.rb b/actionpack/lib/action_dispatch/extensions/rack/utils.rb
index 1a46f8a4db..8e4b94eda0 100644
--- a/actionpack/lib/action_dispatch/extensions/rack/utils.rb
+++ b/actionpack/lib/action_dispatch/extensions/rack/utils.rb
@@ -83,7 +83,6 @@ module Rack
         end
       end
 
-      EOL = "\r\n"
       MULTIPART_BOUNDARY = "AaB03x"
 
       def self.parse_multipart(env)
diff --git a/actionpack/lib/action_dispatch/http/request.rb b/actionpack/lib/action_dispatch/http/request.rb
index 9f0361a874..c28f59dbd6 100755
--- a/actionpack/lib/action_dispatch/http/request.rb
+++ b/actionpack/lib/action_dispatch/http/request.rb
@@ -31,7 +31,7 @@ module ActionDispatch
     # <tt>:get</tt>. If the request \method is not listed in the HTTP_METHODS
     # constant above, an UnknownHttpMethod exception is raised.
     def request_method
-      @request_method ||= HTTP_METHOD_LOOKUP[super] || raise(ActionController::UnknownHttpMethod, "#{super}, accepted HTTP methods are #{HTTP_METHODS.to_sentence(:locale => :en)}")
+      HTTP_METHOD_LOOKUP[super] || raise(ActionController::UnknownHttpMethod, "#{super}, accepted HTTP methods are #{HTTP_METHODS.to_sentence(:locale => :en)}")
     end
 
     # Returns the HTTP request \method used for action processing as a
@@ -85,7 +85,7 @@ module ActionDispatch
     # For backward compatibility, the post \format is extracted from the
     # X-Post-Data-Format HTTP header if present.
     def content_type
-      @content_type ||= begin
+      @env["action_dispatch.request.content_type"] ||= begin
         if @env['CONTENT_TYPE'] =~ /^([^,\;]*)/
           Mime::Type.lookup($1.strip.downcase)
         else
@@ -100,7 +100,7 @@ module ActionDispatch
 
     # Returns the accepted MIME type for the request.
     def accepts
-      @accepts ||= begin
+      @env["action_dispatch.request.accepts"] ||= begin
         header = @env['HTTP_ACCEPT'].to_s.strip
 
         fallback = xhr? ? Mime::JS : Mime::HTML
@@ -160,7 +160,7 @@ module ActionDispatch
     #   GET /posts/5       | request.format => Mime::HTML or MIME::JS, or request.accepts.first depending on the value of <tt>ActionController::Base.use_accept_header</tt>
 
     def format(view_path = [])
-      @format ||=
+      @env["action_dispatch.request.format"] ||=
         if parameters[:format]
                         Mime[parameters[:format]]
         elsif ActionController::Base.use_accept_header && !(accepts == ONLY_ALL)
@@ -171,12 +171,11 @@ module ActionDispatch
     end
 
     def formats
-      @formats = 
-        if ActionController::Base.use_accept_header
-          Array(Mime[parameters[:format]] || accepts)
-        else
-          [format]
-        end
+      if ActionController::Base.use_accept_header
+        Array(Mime[parameters[:format]] || accepts)
+      else
+        [format]
+      end
     end
 
     # Sets the \format by string extension, which can be used to force custom formats
@@ -192,7 +191,7 @@ module ActionDispatch
     #   end
     def format=(extension)
       parameters[:format] = extension.to_s
-      @format = Mime::Type.lookup_by_extension(parameters[:format])
+      @env["action_dispatch.request.format"] = Mime::Type.lookup_by_extension(parameters[:format])
     end
 
     # Returns a symbolized version of the <tt>:format</tt> parameter of the request.
@@ -328,6 +327,10 @@ EOM
       port == standard_port ? '' : ":#{port}"
     end
 
+    def server_port
+      @env['SERVER_PORT'].to_i
+    end
+
     # Returns the \domain part of a \host, such as "rubyonrails.org" in "www.rubyonrails.org". You can specify
     # a different <tt>tld_length</tt>, such as 2 to catch rubyonrails.co.uk in "www.rubyonrails.co.uk".
     def domain(tld_length = 1)
@@ -396,18 +399,19 @@ EOM
 
     # Returns both GET and POST \parameters in a single hash.
     def parameters
-      @parameters ||= request_parameters.merge(query_parameters).update(path_parameters).with_indifferent_access
+      @env["action_dispatch.request.parameters"] ||= request_parameters.merge(query_parameters).update(path_parameters).with_indifferent_access
     end
     alias_method :params, :parameters
 
     def path_parameters=(parameters) #:nodoc:
+      @env.delete("action_dispatch.request.symbolized_path_parameters")
+      @env.delete("action_dispatch.request.parameters")
       @env["action_dispatch.request.path_parameters"] = parameters
-      @symbolized_path_parameters = @parameters = nil
     end
 
     # The same as <tt>path_parameters</tt> with explicitly symbolized keys.
     def symbolized_path_parameters
-      @symbolized_path_parameters ||= path_parameters.symbolize_keys
+      @env["action_dispatch.request.symbolized_path_parameters"] ||= path_parameters.symbolize_keys
     end
 
     # Returns a hash with the \parameters used to form the \path of the request.
@@ -464,8 +468,8 @@ EOM
       @env['rack.session.options'] = options
     end
 
-    def server_port
-      @env['SERVER_PORT'].to_i
+    def flash
+      session['flash'] || {}
     end
 
     private
diff --git a/actionpack/lib/action_dispatch/http/response.rb b/actionpack/lib/action_dispatch/http/response.rb
index 1b12308cc9..2b969323ca 100644
--- a/actionpack/lib/action_dispatch/http/response.rb
+++ b/actionpack/lib/action_dispatch/http/response.rb
@@ -31,14 +31,6 @@ module ActionDispatch # :nodoc:
   #    end
   #  end
   class Response < Rack::Response
-    def self.from_response(response)
-      new.tap do |resp|
-        resp.status  = response.status
-        resp.headers = response.headers
-        resp.body    = response.body
-      end
-    end
-
     DEFAULT_HEADERS = { "Cache-Control" => "no-cache" }
     attr_accessor :request
 
@@ -47,27 +39,6 @@ module ActionDispatch # :nodoc:
     attr_writer :header
     alias_method :headers=, :header=
 
-    def template
-      ActiveSupport::Deprecation.warn("response.template has been deprecated. Use controller.template instead", caller)
-      @template
-    end
-    attr_writer :template
-
-    def session
-      ActiveSupport::Deprecation.warn("response.session has been deprecated. Use request.session instead", caller)
-      @request.session
-    end
-
-    def assigns
-      ActiveSupport::Deprecation.warn("response.assigns has been deprecated. Use controller.assigns instead", caller)
-      @template.controller.assigns
-    end
-
-    def layout
-      ActiveSupport::Deprecation.warn("response.layout has been deprecated. Use template.layout instead", caller)
-      @template.layout
-    end
-
     delegate :default_charset, :to => 'ActionController::Base'
 
     def initialize
@@ -90,33 +61,6 @@ module ActionDispatch # :nodoc:
     end
     alias_method :status_message, :message
 
-    # Was the response successful?
-    def success?
-      (200..299).include?(response_code)
-    end
-
-    # Was the URL not found?
-    def missing?
-      response_code == 404
-    end
-
-    # Were we redirected?
-    def redirect?
-      (300..399).include?(response_code)
-    end
-
-    # Was there a server-side error?
-    def error?
-      (500..599).include?(response_code)
-    end
-
-    alias_method :server_error?, :error?
-
-    # Was there a client client?
-    def client_error?
-      (400..499).include?(response_code)
-    end
-
     def body
       str = ''
       each { |part| str << part.to_s }
diff --git a/actionpack/lib/action_dispatch/testing/test_request.rb b/actionpack/lib/action_dispatch/testing/test_request.rb
new file mode 100644
index 0000000000..3d20b466d3
--- /dev/null
+++ b/actionpack/lib/action_dispatch/testing/test_request.rb
@@ -0,0 +1,56 @@
+module ActionDispatch
+  class TestRequest < Request
+    def self.new(env = {})
+      super
+    end
+
+    def initialize(env = {})
+      super(Rack::MockRequest.env_for('/').merge(env))
+
+      self.host        = 'test.host'
+      self.remote_addr = '0.0.0.0'
+      self.user_agent  = 'Rails Testing'
+    end
+
+    def request_method=(method)
+      @env['REQUEST_METHOD'] = method.to_s.upcase
+    end
+
+    def host=(host)
+      @env['HTTP_HOST'] = host
+    end
+
+    def port=(number)
+      @env['SERVER_PORT'] = number.to_i
+    end
+
+    def request_uri=(uri)
+      @env['REQUEST_URI'] = uri
+    end
+
+    def path=(path)
+      @env['PATH_INFO'] = path
+    end
+
+    def if_modified_since=(last_modified)
+      @env['HTTP_IF_MODIFIED_SINCE'] = last_modified
+    end
+
+    def if_none_match=(etag)
+      @env['HTTP_IF_NONE_MATCH'] = etag
+    end
+
+    def remote_addr=(addr)
+      @env['REMOTE_ADDR'] = addr
+    end
+
+    def user_agent=(user_agent)
+      @env['HTTP_USER_AGENT'] = user_agent
+    end
+
+    def accept=(mime_types)
+      @env.delete("action_dispatch.request.accepts")
+      @env["HTTP_ACCEPT"] = Array(mime_types).collect { |mime_types| mime_types.to_s }.join(",")
+    end
+  end
+end
diff --git a/actionpack/lib/action_dispatch/testing/test_response.rb b/actionpack/lib/action_dispatch/testing/test_response.rb
new file mode 100644
index 0000000000..50c6d85828
--- /dev/null
+++ b/actionpack/lib/action_dispatch/testing/test_response.rb
@@ -0,0 +1,131 @@
+module ActionDispatch
+  class TestResponse < Response
+    def self.from_response(response)
+      new.tap do |resp|
+        resp.status  = response.status
+        resp.headers = response.headers
+        resp.body    = response.body
+      end
+    end
+
+    module DeprecatedHelpers
+      def template
+        ActiveSupport::Deprecation.warn("response.template has been deprecated. Use controller.template instead", caller)
+        @template
+      end
+      attr_writer :template
+
+      def session
+        ActiveSupport::Deprecation.warn("response.session has been deprecated. Use request.session instead", caller)
+        @request.session
+      end
+
+      def assigns
+        ActiveSupport::Deprecation.warn("response.assigns has been deprecated. Use controller.assigns instead", caller)
+        @template.controller.assigns
+      end
+
+      def layout
+        ActiveSupport::Deprecation.warn("response.layout has been deprecated. Use template.layout instead", caller)
+        @template.layout
+      end
+
+      def redirect_url_match?(pattern)
+        ::ActiveSupport::Deprecation.warn("response.redirect_url_match? is deprecated. Use assert_match(/foo/, response.redirect_url) instead", caller)
+        return false if redirect_url.nil?
+        p = Regexp.new(pattern) if pattern.class == String
+        p = pattern if pattern.class == Regexp
+        return false if p.nil?
+        p.match(redirect_url) != nil
+      end
+
+      # Returns the template of the file which was used to
+      # render this response (or nil)
+      def rendered
+        ActiveSupport::Deprecation.warn("response.rendered has been deprecated. Use tempate.rendered instead", caller)
+        @template.instance_variable_get(:@_rendered)
+      end
+
+      # A shortcut to the flash. Returns an empty hash if no session flash exists.
+      def flash
+        ActiveSupport::Deprecation.warn("response.flash has been deprecated. Use request.flash instead", caller)
+        request.session['flash'] || {}
+      end
+
+      # Do we have a flash?
+      def has_flash?
+        ActiveSupport::Deprecation.warn("response.has_flash? has been deprecated. Use flash.any? instead", caller)
+        !flash.empty?
+      end
+
+      # Do we have a flash that has contents?
+      def has_flash_with_contents?
+        ActiveSupport::Deprecation.warn("response.has_flash_with_contents? has been deprecated. Use flash.any? instead", caller)
+        !flash.empty?
+      end
+
+      # Does the specified flash object exist?
+      def has_flash_object?(name=nil)
+        ActiveSupport::Deprecation.warn("response.has_flash_object? has been deprecated. Use flash[name] instead", caller)
+        !flash[name].nil?
+      end
+
+      # Does the specified object exist in the session?
+      def has_session_object?(name=nil)
+        ActiveSupport::Deprecation.warn("response.has_session_object? has been deprecated. Use session[name] instead", caller)
+        !session[name].nil?
+      end
+
+      # A shortcut to the template.assigns
+      def template_objects
+        ActiveSupport::Deprecation.warn("response.template_objects has been deprecated. Use tempate.assigns instead", caller)
+        @template.assigns || {}
+      end
+
+      # Does the specified template object exist?
+      def has_template_object?(name=nil)
+        ActiveSupport::Deprecation.warn("response.has_template_object? has been deprecated. Use tempate.assigns[name].nil? instead", caller)
+        !template_objects[name].nil?
+      end
+    end
+    include DeprecatedHelpers
+
+    # Was the response successful?
+    def success?
+      (200..299).include?(response_code)
+    end
+
+    # Was the URL not found?
+    def missing?
+      response_code == 404
+    end
+
+    # Were we redirected?
+    def redirect?
+      (300..399).include?(response_code)
+    end
+
+    # Was there a server-side error?
+    def error?
+      (500..599).include?(response_code)
+    end
+    alias_method :server_error?, :error?
+
+    # Was there a client client?
+    def client_error?
+      (400..499).include?(response_code)
+    end
+
+    # Returns binary content (downloadable file), converted to a String
+    def binary_content
+      raise "Response body is not a Proc: #{body_parts.inspect}" unless body_parts.kind_of?(Proc)
+      require 'stringio'
+
+      sio = StringIO.new
+      body_parts.call(self, sio)
+
+      sio.rewind
+      sio.read
+    end
+  end
+end