aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
...
* | no more is_a checks on instantiationAaron Patterson2014-05-291-9/+4
| |
* | Path::Pattern is instantiated internally, so make the contructor require a ↵Aaron Patterson2014-05-291-7/+6
| | | | | | | | strexp object
* | Strexp#names is only used in a test, so rmAaron Patterson2014-05-291-4/+0
| |
* | pass the parsed path from mapper to the StrexpAaron Patterson2014-05-292-5/+9
| |
* | add an alternate constructor to Strexp that takes a stringAaron Patterson2014-05-292-8/+10
| |
* | ask the strexp for the astAaron Patterson2014-05-292-3/+7
| |
* | remove dead codeAaron Patterson2014-05-291-1/+0
| |
* | disconnect path from the instanceAaron Patterson2014-05-291-6/+6
| |
* | reuse the ast we already madeAaron Patterson2014-05-291-9/+10
| |
* | use a parser to extract the group parts from the pathAaron Patterson2014-05-292-3/+7
| |
* | pass the parsed parameters through the methods so we don't reparse orAaron Patterson2014-05-291-38/+34
| | | | | | | | require caching code
* | Merge branch 'master' into mapperAaron Patterson2014-05-292-6/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing
| * \ Merge pull request #15061 from tgxworld/remove_unnecessary_includeMatthew Draper2014-05-291-6/+0
| |\ \ | | | | | | | | Remove unnecessary include for integration tests.
| | * | Remove unnecessary include for integration tests.Guo Xiang Tan2014-05-111-6/+0
| | | |
| * | | Add missing `:param` option from the docs for Mapper#match [ci skip]Zachary Scott2014-05-291-0/+6
| | | | | | | | | | | | | | | | Option discovered by @zackperdue in #14741, implemented in #5581.
* | | | "controllers" should be a valid path nameAaron Patterson2014-05-291-1/+1
| | | |
* | | | controllers with slash names are also not supported, so we can reuse the messageAaron Patterson2014-05-281-6/+2
| | | |
* | | | only validate controllersAaron Patterson2014-05-281-15/+17
| | | |
* | | | golf down a bitAaron Patterson2014-05-281-8/+4
| | | |
* | | | only error handling between controller and action is the sameAaron Patterson2014-05-281-18/+16
| | | |
* | | | move nil check to a method that yields to a block if the value is not nilAaron Patterson2014-05-281-17/+16
| | | |
* | | | translate action / controller to the desired objectAaron Patterson2014-05-281-12/+11
| | | |
* | | | only one nil check on the action variableAaron Patterson2014-05-281-10/+8
| | | |
* | | | change to case / when on typesAaron Patterson2014-05-281-8/+7
| | | |
* | | | only do one nil check against the controllerAaron Patterson2014-05-281-9/+9
| | | |
* | | | extract controller and action parsing to a methodAaron Patterson2014-05-281-19/+26
| | | |
* | | | we don't need the call to presence. that is my present, to you!Aaron Patterson2014-05-281-1/+1
| | | |
* | | | swtich to returning early if to responds to callAaron Patterson2014-05-281-35/+32
| | | |
* | | | return early if we have a valid controller nameAaron Patterson2014-05-281-5/+5
| | | |
* | | | trade 2 is_a? checks for a nil checkAaron Patterson2014-05-281-2/+4
| | | |
* | | | invert logic to remove nil? and exclude? checks (use ruby rather than AS ↵Aaron Patterson2014-05-281-6/+6
| | | | | | | | | | | | | | | | when possible
* | | | fewer blank? callsAaron Patterson2014-05-281-4/+4
| | | |
* | | | reduce action.blank? callsAaron Patterson2014-05-281-4/+6
| | | |
* | | | reduce blank? checksAaron Patterson2014-05-281-4/+9
| | | |
* | | | extract controller checks to methodsAaron Patterson2014-05-281-19/+26
| | | |
* | | | set defaults at the top so we can avoid the ||= testAaron Patterson2014-05-281-6/+9
|/ / /
* | | rm dead codeAaron Patterson2014-05-271-5/+0
| | |
* | | PARAMETERS_KEY is only used in the request, so move the constant thereAaron Patterson2014-05-272-4/+4
| | |
* | | Merge branch 'constraints'Aaron Patterson2014-05-279-70/+71
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * | | rm reset_parameters because we automatically do it from 9ca4839aAaron Patterson2014-05-272-6/+0
| | | |
| * | | move path_parameter encoding check to the request objectAaron Patterson2014-05-273-18/+13
| | | |
| * | | dispatcher doesn't need `call` anymoreAaron Patterson2014-05-271-4/+0
| | | |
| * | | call `serve` with the request on dispatchersAaron Patterson2014-05-271-9/+10
| | | |
| * | | constraints class does not need the request class anymoreAaron Patterson2014-05-271-4/+4
| | | |
| * | | give all endpoints a superclassAaron Patterson2014-05-274-22/+40
| | | |
| * | | we do not need to cache rack_appAaron Patterson2014-05-261-9/+3
| | | |
| * | | a redirect is not a dispatcher by definition, so eliminate testAaron Patterson2014-05-261-1/+1
| | | |
| * | | push is_a check up to where the Constraints object is allocatedAaron Patterson2014-05-262-6/+11
| | | |
| * | | pass the request object to the applicationAaron Patterson2014-05-252-4/+3
| | | |
| * | | pass a request to `matches?` so we can avoid creating excess requestsAaron Patterson2014-05-252-7/+6
| | | |