index
:
rails.git
3-2-stable-for-hmno
master
Mirror of official rails repo with custom fixes.
Harald Eilertsen
about
summary
refs
log
tree
commit
diff
stats
log msg
author
committer
range
path:
root
/
actionpack
/
lib
/
action_dispatch
/
routing
Commit message (
Expand
)
Author
Age
Files
Lines
*
remove dead code
Aaron Patterson
2014-05-29
1
-1
/
+0
*
disconnect path from the instance
Aaron Patterson
2014-05-29
1
-6
/
+6
*
reuse the ast we already made
Aaron Patterson
2014-05-29
1
-9
/
+10
*
use a parser to extract the group parts from the path
Aaron Patterson
2014-05-29
1
-3
/
+3
*
pass the parsed parameters through the methods so we don't reparse or
Aaron Patterson
2014-05-29
1
-38
/
+34
*
Merge branch 'master' into mapper
Aaron Patterson
2014-05-29
1
-0
/
+6
|
\
|
*
Add missing `:param` option from the docs for Mapper#match [ci skip]
Zachary Scott
2014-05-29
1
-0
/
+6
*
|
"controllers" should be a valid path name
Aaron Patterson
2014-05-29
1
-1
/
+1
*
|
controllers with slash names are also not supported, so we can reuse the message
Aaron Patterson
2014-05-28
1
-6
/
+2
*
|
only validate controllers
Aaron Patterson
2014-05-28
1
-15
/
+17
*
|
golf down a bit
Aaron Patterson
2014-05-28
1
-8
/
+4
*
|
only error handling between controller and action is the same
Aaron Patterson
2014-05-28
1
-18
/
+16
*
|
move nil check to a method that yields to a block if the value is not nil
Aaron Patterson
2014-05-28
1
-17
/
+16
*
|
translate action / controller to the desired object
Aaron Patterson
2014-05-28
1
-12
/
+11
*
|
only one nil check on the action variable
Aaron Patterson
2014-05-28
1
-10
/
+8
*
|
change to case / when on types
Aaron Patterson
2014-05-28
1
-8
/
+7
*
|
only do one nil check against the controller
Aaron Patterson
2014-05-28
1
-9
/
+9
*
|
extract controller and action parsing to a method
Aaron Patterson
2014-05-28
1
-19
/
+26
*
|
we don't need the call to presence. that is my present, to you!
Aaron Patterson
2014-05-28
1
-1
/
+1
*
|
swtich to returning early if to responds to call
Aaron Patterson
2014-05-28
1
-35
/
+32
*
|
return early if we have a valid controller name
Aaron Patterson
2014-05-28
1
-5
/
+5
*
|
trade 2 is_a? checks for a nil check
Aaron Patterson
2014-05-28
1
-2
/
+4
*
|
invert logic to remove nil? and exclude? checks (use ruby rather than AS when...
Aaron Patterson
2014-05-28
1
-6
/
+6
*
|
fewer blank? calls
Aaron Patterson
2014-05-28
1
-4
/
+4
*
|
reduce action.blank? calls
Aaron Patterson
2014-05-28
1
-4
/
+6
*
|
reduce blank? checks
Aaron Patterson
2014-05-28
1
-4
/
+9
*
|
extract controller checks to methods
Aaron Patterson
2014-05-28
1
-19
/
+26
*
|
set defaults at the top so we can avoid the ||= test
Aaron Patterson
2014-05-28
1
-6
/
+9
|
/
*
PARAMETERS_KEY is only used in the request, so move the constant there
Aaron Patterson
2014-05-27
1
-2
/
+0
*
rm reset_parameters because we automatically do it from 9ca4839a
Aaron Patterson
2014-05-27
1
-2
/
+0
*
move path_parameter encoding check to the request object
Aaron Patterson
2014-05-27
2
-18
/
+2
*
dispatcher doesn't need `call` anymore
Aaron Patterson
2014-05-27
1
-4
/
+0
*
call `serve` with the request on dispatchers
Aaron Patterson
2014-05-27
1
-9
/
+10
*
constraints class does not need the request class anymore
Aaron Patterson
2014-05-27
1
-4
/
+4
*
give all endpoints a superclass
Aaron Patterson
2014-05-27
4
-22
/
+40
*
we do not need to cache rack_app
Aaron Patterson
2014-05-26
1
-9
/
+3
*
a redirect is not a dispatcher by definition, so eliminate test
Aaron Patterson
2014-05-26
1
-1
/
+1
*
push is_a check up to where the Constraints object is allocated
Aaron Patterson
2014-05-26
2
-6
/
+11
*
pass the request object to the application
Aaron Patterson
2014-05-25
1
-3
/
+2
*
pass a request to `matches?` so we can avoid creating excess requests
Aaron Patterson
2014-05-25
2
-7
/
+6
*
nothing is passed to `rack_app` anymore, so rm the params
Aaron Patterson
2014-05-25
1
-1
/
+1
*
one fewer is_a check
Aaron Patterson
2014-05-25
1
-4
/
+3
*
Constraints#app should never return another Constraints object, so switch to ...
Aaron Patterson
2014-05-25
1
-1
/
+1
*
eliminate dispatcher is_a checks
Aaron Patterson
2014-05-24
1
-8
/
+14
*
push is_a?(Dispatcher) check in to one place
Aaron Patterson
2014-05-24
2
-5
/
+10
*
Always construct route objects with Constraint objects
Aaron Patterson
2014-05-24
3
-9
/
+7
*
unwrap the constraints object on initialization, eliminate loops
Aaron Patterson
2014-05-24
3
-2
/
+11
*
Constraints contructor should always return a Constraints object
Aaron Patterson
2014-05-23
1
-9
/
+5
*
default value is never used, so make it required
Aaron Patterson
2014-05-23
1
-1
/
+1
*
push options decomposition up so we can extract
Aaron Patterson
2014-05-23
1
-20
/
+13
[next]