aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Fix regex used to find URI schemes in redirect_toDerek Prior2013-09-191-0/+5
| | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC.
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-0/+5
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* Fix an issue where router can't recognize downcased url encoding path.kennyj2013-09-191-0/+6
|
* Custom flash should be defined only for the class that defines it and it's ↵Ricardo de Cillo2013-09-131-0/+7
| | | | subclasses.
* Add CHANGELOG entry for #12149Rafael Mendonça França2013-09-121-0/+6
| | | | [ci skip]
* Remove BasicRendering and remove template functionality from AbsC::RenderingJosé Valim2013-09-091-5/+0
|
* Improve AP changelog regarding AV extraction [ci skip]Carlos Antonio da Silva2013-08-261-2/+2
|
* Update AP changelogŁukasz Strzałkowski2013-08-251-0/+9
|
* Display exceptions in text format for xhr requestKir Shatrov2013-08-221-0/+4
|
* Execute conditional procs on controller filters only for current action.Nicholas Jakobsen2013-08-101-0/+7
| | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786.
* Pass assert_dom_equal message arg to underlying assertionRyan McGeary2013-08-041-0/+7
| | | | | #assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized.
* Allow overriding of all headers from passed environment hashAndrew White2013-07-251-0/+7
| | | | | | | Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from the environment passed into `ActionDispatch::TestRequest.new`. Fixes #11590
* Clear named routes when routes.rb is reloadedAndrew White2013-07-211-0/+8
| | | | | | | | Fix an issue where Journey was failing to clear the named routes hash when the routes were reloaded and since it doesn't overwrite existing routes then if a route changed but wasn't renamed it kept the old definition. This was being masked by the optimised url helpers so it only became apparent when passing an options hash to the url helper.
* Skip Rack applications and redirects when generating urlsAndrew White2013-07-161-0/+7
| | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018
* move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-121-0/+4
|
* Show real LoadError on helpers requirePiotr Niełacny2013-07-101-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Use Request#raw_post instead Request#bodyPaul Nikitochkin2013-07-081-0/+7
| | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345
* Space is not required for Set-Cookie headerYamagishi Kazutoshi2013-07-051-0/+4
|
* Remove deprecated Rails application fallback for integration testingCarlos Antonio da Silva2013-07-021-0/+5
| | | | Set ActionDispatch.test_app instead.
* Remove `page_cache_extension` deprecated methodFrancesco Rodriguez2013-07-011-0/+4
|
* Remove deprecated constants from Action ControllerCarlos Antonio da Silva2013-07-011-0/+12
| | | | | | | | | | ActionController::AbstractRequest => ActionDispatch::Request ActionController::Request => ActionDispatch::Request ActionController::AbstractResponse => ActionDispatch::Response ActionController::Response => ActionDispatch::Response ActionController::Routing => ActionDispatch::Routing ActionController::Integration => ActionDispatch::Integration ActionController::IntegrationTest => ActionDispatch::IntegrationTest
* Merge pull request #11000 from sbeckeriv/accept_headerCarlos Antonio da Silva2013-06-251-0/+8
|\ | | | | | | Fix undefined method `ref' for nil:NilClass for bad accept headers
| * Fix undefined method `ref' for nil:NilClass for bad accept headersStephen Becker IV2013-06-191-0/+4
| |
* | Fixing Issue #11083Akshay Khole2013-06-251-1/+1
| | | | | | | | Removing other occurrences of `the` appearing twice
* | Fix shorthand routes where controller and action are in the scopeAndrew White2013-06-251-0/+9
| | | | | | | | | | | | | | | | | | Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856
* | Don't remove trailing slash from PATH_INFO for mounted appsPiotr Sarnacki2013-06-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when app was mounted as following: class Foo def call(env) [200, {}, [env['PATH_INFO']]] end end RackMountRailsBug::Application.routes.draw do mount RackTest.new => "/foo" end trailing slash was removed from PATH_INFO. For example requesting GET /foo/bar/ on routes defined above would result in a response containing "/foo/bar" instead of "/foo/bar/". This commit fixes the issue. (closes #3215)
* | Adjust changelog for AV & APŁukasz Strzałkowski2013-06-201-35/+2
| |
* | Add CHANGELOG entry for #10969Rafael Mendonça França2013-06-161-0/+21
|/ | | | [ci skip]
* collection tags accept html attributes as the last element of collectionVasiliy Ermolovich2013-06-161-0/+5
|
* Update the HTML boolean attributes per the HTML 5.1 specAlex Peattie2013-06-141-0/+7
| | | | | | | - Add attributes `allowfullscreen`, `default`, `inert`, `sortable`, `truespeed`, `typemustmatch`. - Fix attribute `seamless` (previously misspelled `seemless`). - Use `assert_dom_equal` instead of `assert_equal` in test.
* Allow numbers in partial name for digestingBryan Ricker2013-05-061-1/+3
| | | | | | | | | | Add failing test for template with number at the end Use \w for RENDER_DEPENDENCY regex Spacing Add CHANGELOG entry
* rails/master is now 4.1.0.betaRafael Mendonça França2013-04-291-1192/+2
|
* Revert "Merge pull request #10337 from eimermusic/fix_template_digestor_lookup"Rafael Mendonça França2013-04-251-9/+0
| | | | | | | | This reverts commit b4239622afc4f3f73808fd0c97512f3a534e07dd, reversing changes made to f99ce3c188f5dde57e2ff63e6a22363c62f0a4cd. Reason: This broke the build https://travis-ci.org/rails/rails/jobs/6629894
* Merge pull request #10337 from eimermusic/fix_template_digestor_lookupRafael Mendonça França2013-04-251-0/+9
|\ | | | | | | | | | | | | Fix ActionView::Digestor to correctly pass format to LookupContext Conflicts: actionpack/CHANGELOG.md
| * AV Digestor correctly passes format to LookupContextMartin Westin2013-04-251-0/+9
| | | | | | | | | | | | | | | | ActionView::Digestor now passes arguments correctly to LookupContext::find method. This makes cache digests respect the format option correctly. FixtureFinder in tests also changed to reflect this.
* | Add support for extra options to `force_ssl`Andrew White2013-04-251-0/+5
| | | | | | | | | | | | | | | | This commit adds support for passing additional url options along with a :status option and any of the flash-related options to `redirect_to` (i.e. :flash, :alert & :notice). Closes #7570.
* | Use `request.fullpath` to build redirect url in `force_ssl`Andrew White2013-04-251-0/+9
|/ | | | | | | | | | | The `force_ssl` command now builds the redirect url from `request.fullpath`. This ensures that the format is maintained and it doesn't redirect to a route that has the same parameters but is defined earlier in `routes.rb`. Also any optional segments are maintained. Fixes #7528. Fixes #9061. Fixes #10305.
* Return a 405 response for unknown HTTP methodsLewis Marshall2013-04-221-0/+5
|
* Add CHANGELOG entries - closes #10180, #10185Andrew White2013-04-181-0/+10
|
* Merge pull request #10173 from nashby/element-attributesRafael Mendonça França2013-04-161-0/+5
|\ | | | | options_from_collection_for_select helper takes html attributes
| * options_from_collection_for_select helper takes html attributesVasiliy Ermolovich2013-04-111-0/+5
| | | | | | | | as the last element of the array
* | use unified and clean formatting in CHANGELOGS. [ci skip]Yves Senn2013-04-121-1/+1
|/
* Improve the changelog entry [ci skip]Rafael Mendonça França2013-04-051-3/+4
|
* Fix explicit names on multiple file fieldsRyan McGeary2013-04-051-0/+7
| | | | | | | | If a file field tag is passed the multiple option, it is turned into an array field (appending "[]"), but if the file field is passed an explicit name as an option, leave the name alone (do not append "[]"). Fixes #9830
* Add block support for the helperSam Pohlenz2013-04-031-0/+4
|
* Merge pull request #9978 from trevorturk/cookie-store-auto-upgradeSantiago Pastorino2013-04-011-0/+11
|\ | | | | Cookie-base session store auto-upgrade
| * Allow transparent upgrading of legacy signed cookies to encrypted cookies; ↵Trevor Turk2013-03-281-0/+11
| | | | | | | | Automatically configure cookie-based sessions to use the best cookie jar given the app's config
* | Improve AP changelog entry about layout method with nil returnCarlos Antonio da Silva2013-03-301-4/+4
|/ | | | | | | Add a note about getting the "no layout" behavior by returning "false" to make it easier for people that might need to change their code. Related to #8458. [ci skip]
* Removed unused variable in procPrathamesh Sonpatki2013-03-281-1/+1
| | | | | | * This unused variable is already removed from the code here. d18e8b1a3839c5c214e96c7e37e0d86febe15f99 * So removing it from CHANGELOG to be consistent with code
* Merge pull request #8458 from ↵Rafael Mendonça França2013-03-271-0/+21
|\ | | | | | | | | | | | | | | | | lucisferre/improve-layout-override-fallback-behavior Provides standard layout lookup behavior for method and proc cases Conflicts: actionpack/CHANGELOG.md