diff options
| author | Derek Prior <derekprior@gmail.com> | 2013-04-26 14:30:29 -0400 |
|---|---|---|
| committer | Derek Prior <derekprior@gmail.com> | 2013-09-19 09:23:20 -0400 |
| commit | 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0 (patch) | |
| tree | 7a82fbf9bb30202b01590c2306c9ffd1846f5e89 /actionpack/CHANGELOG.md | |
| parent | fb2785ec3d97f0e3578e181012f18eda920dca10 (diff) | |
| download | rails-1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0.tar.gz rails-1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0.tar.bz2 rails-1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0.zip | |
Fix incorrect assert_redirected_to failure message
In some instances, `assert_redirected_to` assertion was returning an
incorrect and misleading failure message when the assertion failed.
This was due to a disconnect in how the assertion computes the redirect
string for the failure message and how `redirect_to` computes the
string that is actually used for redirection.
I made the `_compute_redirect_to_loaction` method used by `redirect_to`
public and call that from the method `assert_redirect_to` uses to
calculate the URL.
The reveals a new test failure due to the regex used by
`_compute_redirect_to_location` allow `_` in the URL scheme.
Diffstat (limited to 'actionpack/CHANGELOG.md')
| -rw-r--r-- | actionpack/CHANGELOG.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index 63a208dbcf..a7ad07afd9 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,3 +1,8 @@ +* Fix incorrect `assert_redirected_to` failure message for protocol-relative + URLs. + + *Derek Prior* + * Fix an issue where router can't recognize downcased url encoding path. Fixes #12269 |