aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable
Commit message (Collapse)AuthorAgeFilesLines
...
* Reduce string objects by using \ instead of + or << for concatenating stringsAkira Matsuda2017-01-121-2/+2
| | | | (I personally prefer writing one string in one line no matter how long it is, though)
* ActionCable should not raise when a connection is already openDuncan Grazier2017-01-062-3/+6
| | | | | | | | | | | ActionCable was throwing a "Existing connection must be closed before opening" exception which was being picked up as a production issue in our error monitoring software. Since this happens pretty often on any device that allows the browser to sleep (mobile) this error was getting triggered often. This change removes the exception, but keeps logging the occurrence. We now return `false` to let the caller now that `open` failed.
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-052-3/+3
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Merge pull request #25626 from maclover7/jm-standardize-ac-readmeRafael França2017-01-031-0/+9
|\ | | | | Standardize Action Cable README.md
| * Standardize Action Cable README.mdJon Moss2016-07-021-0/+9
| | | | | | | | | | | | | | All other Rails components feature this section, Action Cable should have it as well. [ci skip]
* | Bump license years for 2017Jon Moss2016-12-312-2/+2
| | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* | Upgrade to nio4r 2.0.0Tony Arcieri2016-12-281-1/+1
| | | | | | | | | | | | | | | | | | | | nio4r 2.0.0 primarily includes new features and bugfixes, with few breaking changes. The primary reason for bumping the major version is dropping support for all Ruby versions prior to 2.2.2, so as to match Rails 5. Full release announcement here: https://groups.google.com/forum/#!topic/socketry/ZDIUj1ufiJ8
* | Small edits to actioncable/CHANGELOG.mdJon Moss2016-12-271-2/+2
| | | | | | | | | | | | [ci skip] - capitalize WebSocket
* | Privatize unneededly protected methods in Action CableAkira Matsuda2016-12-245-25/+24
| |
* | Privatize unneededly protected methods in Action Cable testsAkira Matsuda2016-12-243-3/+3
| |
* | Describe what we are protectingAkira Matsuda2016-12-234-0/+8
| |
* | Fix typo in channel generator usage messageCarlos Eduardo Monti2016-12-191-2/+2
| |
* | ActionCable::Connection::Base doc code sample syntax errorMSP-Greg2016-12-061-4/+1
| |
* | Prevent race condition when launching EventMachine reactorMatthew Draper2016-11-302-2/+28
| | | | | | | | | | | | | | reactor_running? will be true just after the thread enters EventMachine.run; reactor_thread only gets set after the internal initialize_event_machine method has been called, the C extension is set up, and it is entering its run loop.
* | Add more Action Cable JavaScript testsJavan Makhmali2016-11-214-0/+78
| |
* | use correct value in example [ci skip]yuuji.yaginuma2016-11-141-1/+1
| | | | | | | | | | Need to specify `reload` from turbolinks 5. Ref: 7225f0bb9fd1d71a7a37b53815c90178cc7319bd
* | Changelog editsVipul A M2016-11-121-4/+4
| |
* | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-298-18/+18
| |
* | Lazy-load blade for actioncable tests; no blade on JRuby.Charles Oliver Nutter2016-10-211-1/+2
| |
* | Permit same-origin connections by defaultMatthew Draper2016-10-115-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebSocket always defers the decision to the server, because it didn't have to deal with legacy compatibility... but the same-origin policy is still a reasonable default. Origin checks do not protect against a directly connecting attacker -- they can lie about their host, but can also lie about their origin. Origin checks protect against a connection from 3rd-party controlled script in a context where a victim browser's cookies will be passed along. And if an attacker has breached that protection, they've already compromised the HTTP session, so treating the WebSocket connection in the same way seems reasonable. In case this logic proves incorrect (or anyone just wants to be more paranoid), we retain a config option to disable it.
* | Merge pull request #26568 from skateman/cable-sameorigin-as-hostMatthew Draper2016-10-114-1/+18
|\ \ | | | | | | | | | Optionally allow ActionCable requests from the same host as origin
| * | Optionally allow ActionCable requests from the same host as originDávid Halász2016-09-214-1/+18
| | | | | | | | | | | | | | | | | | | | | When the `allow_same_origin_as_host` is set to `true`, the request forgery protection permits `HTTP_ORIGIN` values starting with the corresponding `proto://` prefix followed by `HTTP_HOST`. This way it is not required to specify the list of allowed URLs.
* | | Merge pull request #26714 from matthewd/close-raceMatthew Draper2016-10-074-10/+11
|\ \ \ | | | | | | | | Work around read/close race (x2)
| * | | Wait for the socket to be closed asynchronouslyMatthew Draper2016-10-061-2/+10
| | | |
| * | | Use a branch of websocket-client-simple, to work around read/close raceMatthew Draper2016-10-061-7/+0
| | | |
| * | | Close the IO from the read loop threadMatthew Draper2016-10-062-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IO#close and IO#read across threads don't get along so well: After T1 enters #read and releases the GVL, T2 can call #close on the IO, thereby both closing the fd and freeing the buffer while T1 is using them.
* | | | Change page:change to turbolinks:load in README.md [ci skip]kenta-s2016-10-051-1/+1
|/ / /
* | | Don't shut down adapters that haven't been setMatthew Draper2016-10-041-1/+1
| | | | | | | | | | | | We hit when we skip the PostgreSQL adapter.
* | | Shut down the worker pool - don't kill itMatthew Draper2016-10-031-1/+1
| | | | | | | | | | | | | | | Different parts of concurrent-ruby's documentation make inconsistent claims about how kill will behave. It doesn't do the thing we want.
* | | Add tests for Server::Base#restartJon Moss2016-10-021-0/+33
| | |
* | | Move behavior to Server::Base, and flush pubsubJon Moss2016-10-022-3/+6
| | |
* | | Shutdown pubsub connection before classes are reloadedJon Moss2016-10-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this patch, if you were to make a file edit in your Rails application and you tried to load up the page, it would hang indefinitely. The issue is that Active Record is trying to cleanup after itself and clear all active connection, but Action Cable is still holding onto a connection from the pool. To resolve this, we are now shutting down the pubsub adapter before classes are reloaded, to avoid this altogether (connection is being returned to the pool). Credits to @skateman for discovering this bug. :)
* | | Use websocket-client-simple instead of Faye as a websockets clientMatthew Draper2016-10-021-57/+81
| | | | | | | | | | | | | | | | | | Mostly, this is just to avoid EventMachine. But there's also an argument to be made that we're better off using a different protocol library for our test suite than the one we use to implement the server.
* | | Shut down EventMachine before re-enabling warningsMatthew Draper2016-10-022-0/+9
| | |
* | | In-line the configuration points that only existed for Faye supportMatthew Draper2016-10-015-13/+4
| | |
* | | Remove Faye modeMatthew Draper2016-10-0110-168/+7
| | | | | | | | | | | | No deprecation, because it was never documented.
* | | Merge pull request #26547 from ↵Matthew Draper2016-10-019-24/+83
|\ \ \ | | | | | | | | | | | | | | | | | | | | palkan/fix/actioncable-confirmation-race-condition Avoid race condition on subscription confirmation
| * | | Add Channel#ensure_confirmation_sent; call #subscribe_to_channel after ↵palkan2016-09-227-33/+39
| | | | | | | | | | | | | | | | initializing
| * | | [Fix #25381] Avoid race condition on subscription confirmationpalkan2016-09-206-15/+60
| | | |
* | | | Buffer writes to the cable socketsMatthew Draper2016-09-284-12/+100
| |/ / |/| | | | | | | | | | | Otherwise, they can sometimes block, leading to reduced system throughput.
* | | [ci skip] Fix formatting of documentation of worker_pool method from ↵Prathamesh Sonpatki2016-09-071-1/+1
| | | | | | | | | | | | AC::Server::Base
* | | [ci skip] Fix formatting in Action Cable Connection::Base module docsPrathamesh Sonpatki2016-09-071-1/+1
| | |
* | | [ci fix] Fix API documentation for Streams module from Action CablePrathamesh Sonpatki2016-09-061-4/+4
|/ /
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-012-2/+2
| |
* | Prevent invocation of channel action if rejected connectionJon Moss2016-08-192-1/+16
| | | | | | | | | | | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
* | Add three new rubocop rulesRafael Mendonça França2016-08-163-26/+26
| | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | Pass over changelogs [ci skip]Vipul A M2016-08-101-1/+1
| |
* | revises more Lint/EndAlignment offensesXavier Noria2016-08-081-6/+6
| |
* | copy-edits an exception messageXavier Noria2016-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Inserted spaces in the name of Rails components. Since I was on it, also used PostgreSQL instead of Postgres because albeit Postgres is an accepted alias, PostgreSQL is the official name and the actual name of the adapter. See https://wiki.postgresql.org/wiki/ProjectName with regard to PostgreSQL vs Postgres.
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-072-3/+0
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 17:59:29 +0000