diff options
| author | Akira Matsuda <ronnie@dio.jp> | 2016-12-19 19:10:49 +0900 |
|---|---|---|
| committer | Akira Matsuda <ronnie@dio.jp> | 2016-12-23 23:48:54 +0900 |
| commit | 21e5fd4a2a1c162ad33708d3e01b1fda165f204d (patch) | |
| tree | 1bd755cd789faccd608e1e72a092723b56435466 /actioncable | |
| parent | be984f02db145c0091c265babd331127c3b408d9 (diff) | |
| download | rails-21e5fd4a2a1c162ad33708d3e01b1fda165f204d.tar.gz rails-21e5fd4a2a1c162ad33708d3e01b1fda165f204d.tar.bz2 rails-21e5fd4a2a1c162ad33708d3e01b1fda165f204d.zip | |
Describe what we are protecting
Diffstat (limited to 'actioncable')
4 files changed, 8 insertions, 0 deletions
diff --git a/actioncable/lib/action_cable/connection/base.rb b/actioncable/lib/action_cable/connection/base.rb index e1da126d64..6d94b0eab0 100644 --- a/actioncable/lib/action_cable/connection/base.rb +++ b/actioncable/lib/action_cable/connection/base.rb @@ -133,6 +133,8 @@ module ActionCable send_async :handle_close end + # TODO Change this to private once we've dropped Ruby 2.2 support. + # Workaround for Ruby 2.2 "private attribute?" warning. protected # The request that initiated the WebSocket connection is available here. This gives access to the environment, cookies, etc. def request diff --git a/actioncable/lib/action_cable/connection/message_buffer.rb b/actioncable/lib/action_cable/connection/message_buffer.rb index 6a80770cae..4ccd322644 100644 --- a/actioncable/lib/action_cable/connection/message_buffer.rb +++ b/actioncable/lib/action_cable/connection/message_buffer.rb @@ -28,6 +28,8 @@ module ActionCable receive_buffered_messages end + # TODO Change this to private once we've dropped Ruby 2.2 support. + # Workaround for Ruby 2.2 "private attribute?" warning. protected attr_reader :connection attr_reader :buffered_messages diff --git a/actioncable/lib/action_cable/connection/subscriptions.rb b/actioncable/lib/action_cable/connection/subscriptions.rb index 00511aead5..abf42c99d5 100644 --- a/actioncable/lib/action_cable/connection/subscriptions.rb +++ b/actioncable/lib/action_cable/connection/subscriptions.rb @@ -61,6 +61,8 @@ module ActionCable subscriptions.each { |id, channel| remove_subscription(channel) } end + # TODO Change this to private once we've dropped Ruby 2.2 support. + # Workaround for Ruby 2.2 "private attribute?" warning. protected attr_reader :connection, :subscriptions diff --git a/actioncable/lib/action_cable/connection/web_socket.rb b/actioncable/lib/action_cable/connection/web_socket.rb index 382141b89f..03eb6e2ea8 100644 --- a/actioncable/lib/action_cable/connection/web_socket.rb +++ b/actioncable/lib/action_cable/connection/web_socket.rb @@ -32,6 +32,8 @@ module ActionCable websocket.rack_response end + # TODO Change this to private once we've dropped Ruby 2.2 support. + # Workaround for Ruby 2.2 "private attribute?" warning. protected attr_reader :websocket end |