aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/test/client_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use match? where we don't need MatchDataAkira Matsuda2019-07-291-1/+1
|
* typo fixes in action cablealkesh262019-01-171-1/+1
|
* Include `ActiveSupport::Testing::MethodCallAssertions` to ↵bogdanvlviv2018-06-081-3/+0
| | | | | | | | | `ActionCable::TestCase` Remove all `include ActiveSupport::Testing::MethodCallAssertions` in actioncable's tests since we can do it only in `ActionCable::TestCase` in order to prevent code duplication. We use the same approach for other modules of Rails.
* assert_calledutilum2018-04-261-3/+7
|
* Use assert_predicate and assert_not_predicateDaniel Colson2018-01-251-1/+1
|
* Use frozen string literal in actioncable/Kir Shatrov2017-07-231-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Work around all the thingsMatthew Draper2017-04-061-1/+11
|
* Avoid "can't modify frozen IOError" failuresMatthew Draper2017-04-051-5/+16
| | | | https://bugs.ruby-lang.org/issues/13239
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-11/+11
|
* Use a branch of websocket-client-simple, to work around read/close raceMatthew Draper2016-10-061-7/+0
|
* Use websocket-client-simple instead of Faye as a websockets clientMatthew Draper2016-10-021-57/+81
| | | | | | Mostly, this is just to avoid EventMachine. But there's also an argument to be made that we're better off using a different protocol library for our test suite than the one we use to implement the server.
* Remove Faye modeMatthew Draper2016-10-011-1/+0
| | | | No deprecation, because it was never documented.
* Add three new rubocop rulesRafael Mendonça França2016-08-161-22/+22
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* applies new string literal convention in actioncable/testXavier Noria2016-08-061-28/+28
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Make client test run individually.Kasper Timm Hansen2016-06-281-1/+3
| | | | Require our dependency and forgo the core ext version.
* client test have not using Pathname and hashwithindifferent accessGaurav Sharma2016-06-261-3/+0
|
* Properly support reloading for Action Cable channelsMatthew Draper2016-06-021-25/+47
|
* Cable: Extract stream handler constructionJeremy Daer2016-04-181-1/+3
| | | | | | | | * Use separate stream handler builders for easy override and testing. * Fix worker pool execution that was silently failing since it only expected connection receivers. Sparked by code in #24162.
* Cable message encodingJeremy Daer2016-03-311-18/+18
| | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* Merge pull request #23992 from matthewd/em-optionMatthew Draper2016-03-041-2/+3
|\ | | | | Support faye-websocket + EventMachine as an option
| * Support faye-websocket + EventMachine as an optionMatthew Draper2016-03-021-2/+3
| |
* | Merge pull request #23976 from danielrhodes/enhancement/ac-ping-to-message-typeMatthew Draper2016-03-021-1/+8
|\ \ | |/ |/| | | ActionCable: Add a "welcome" and "ping" message type
| * Make ping into a message typeDaniel Rhodes2016-03-011-1/+1
| | | | | | | | | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work.
| * Added welcome message type and fix test hacksDaniel Rhodes2016-03-011-0/+6
| |
* | Use AS::Executor / AS::Reloader to support reloading in ActionCableMatthew Draper2016-03-021-0/+20
|/
* Merge pull request #23715 from maclover7/fix-unsubscribeMatthew Draper2016-02-191-0/+21
|\ | | | | Fix `unsubscribed` server side behavior
| * Fix `unsubscribed` server side behaviorJon Moss2016-02-181-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
* | Use a semaphore to signal message availabilityMatthew Draper2016-02-191-7/+8
|/ | | | | The Event hack was too much of a hack: on actually thinking about it, there's a rather obvious race.
* Don't rely on the global server as a receiver.Kasper Timm Hansen2016-02-141-3/+1
| | | | | | | | | | | | | | | | The `WorkerTest`'s `Receiver` is imporsonating an `ActionCable::Connection::Base`, but just delegates the logger to `ActionCable.logger`. This creates a mismatch as the connection requires the logger to be a `TaggedLoggerProxy`'ied logger, while the server doesn't. Thus to ensure an exception isn't raised when the worker tries to call `tag` other tests have to assign a proxied logger to their test server. Instead of forcing change on other tests, have Receiver adhere to the connection contract and use a `TaggedLoggerProxy`. As a consequence remove more setup from the tests.
* Default connection class to ActionCable::Connection::Base.Kasper Timm Hansen2016-02-141-8/+0
| | | | | | | Instead of depending on ApplicationCable::Connection being defined at initialize we should inject it in the Railtie. Thus we can kill more setup in the tests too.
* Inject Rails' channel paths in engine.Kasper Timm Hansen2016-02-141-9/+1
| | | | | | | | | | | | | We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize, thereby coupling ourselves to Rails. Instead add `app/channels` to Rails' app paths and assign the existent files to `channel_paths`. Users can still append to those load paths with `<<` and `push` in `config/application.rb`. This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails and root definitions in the tests.
* Cant run on an out-of-the-box OSX installation without running out of TOO ↵David Heinemeier Hansson2016-02-051-1/+1
| | | | MANY FILES OPEN
* Merge pull request #23370 from maclover7/actioncable-main-travis-buildGuillermo Iguaran2016-01-311-9/+0
|\ | | | | Move Action Cable back to the main build
| * Remove unused methodJon Moss2016-01-311-9/+0
| |
* | Wait for EventMachine to finish startingMatthew Draper2016-02-011-0/+1
|/
* Use a gentler disconnectMatthew Draper2016-01-301-2/+2
| | | | The detach used by close! seems to be making EM very sad on Travis.
* Don't bother stopping EM between testsMatthew Draper2016-01-301-38/+3
| | | | | It's not strictly necessary, and maybe this will help with the current test failure.
* Keep the socket reference after closeMatthew Draper2016-01-301-3/+2
| | | | We may still try to send to it.
* Reduce the client count, in hope of a more consistent testMatthew Draper2016-01-301-3/+3
|
* Be more patient while gathering the expected responsesMatthew Draper2016-01-301-4/+3
|
* Handle more IO errors (especially, ECONNRESET)Matthew Draper2016-01-301-0/+26
| | | | | | Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor.
* Add a couple of tests that connect with a WS clientMatthew Draper2016-01-301-0/+238
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 23:02:24 +0000