aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge pull request #34969 from eileencodes/fix-error-message-for-multi-db-appsEileen M. Uchitelle2019-01-181-1/+20
|\ \ \ \ \ | |/ / / / |/| | | | Fix error message when adapter is not specified
| * | | | Fix error message when adapter is not specifiedEileen Uchitelle2019-01-171-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we added support for multiple databases through a 3-tiered config and configuration objects this error message got a bit convoluted. Previously if you had an application with a missing configuation and multiple databases the error message would look like this: ``` 'doesnexist' database is not configured. Available: development, development, test, test, production, production (ActiveRecord::AdapterNotSpecified) ``` That's not very descriptive since it duplicates the environments (because there are multiple databases per environment for this application). To fix this I've constructed a bit more readable error message which now reads like this if you have a multi db app: ``` The `doesntexist` database is not configured for the `production` environment. (ActiveRecord::AdapterNotSpecified) Available databases configurations are: development: primary, primary_readonly test: primary, primary_readonly production: primary, primary_readonly ``` And like this if you have a single db app: ``` The `doesntexist` database is not configured for the `production` environment. (ActiveRecord::AdapterNotSpecified) Available databases configurations are: development test ``` This makes the error message more readable and presents the user all available options for the database connections.
* | | | | Use `unboundable?` rather than `boundable?`Ryuta Kamizono2019-01-184-14/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `unboundable?` behaves like the `infinite?`. ```ruby inf = Topic.predicate_builder.build_bind_attribute(:id, Float::INFINITY) inf.infinite? # => 1 oob = Topic.predicate_builder.build_bind_attribute(:id, 9999999999999999999999999999999) oob.unboundable? # => 1 inf = Topic.predicate_builder.build_bind_attribute(:id, -Float::INFINITY) inf.infinite? # => -1 oob = Topic.predicate_builder.build_bind_attribute(:id, -9999999999999999999999999999999) oob.unboundable? # => -1 ```
* | | | | Revert "Remove deprecated `server` argument from the rails server command"yuuji.yaginuma2019-01-183-6/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fa791fb8e2a718b5d0430c7ca5a454678dfc192d. Reason: `server` argument was deprecated in Rails 6.0. Ref: #32058.
* | | | | Merge pull request #34956 from kamipo/actionmailbox_datetime_precisionRyuta Kamizono2019-01-184-14/+20
|\ \ \ \ \ | | | | | | | | | | | | Allow using Action Mailbox on MySQL 5.5
| * | | | | Allow using Action Mailbox on MySQL 5.5Ryuta Kamizono2019-01-184-14/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record still support MySQL 5.5 which doesn't support datetime with precision. https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101 So we should check `supports_datetime_with_precision?` on the connection.
* | | | | | Merge pull request #34963 from ↵Rafael França2019-01-172-8/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | dylanahsmith/better-composed-of-single-field-query activerecord: Use a simpler query condition for aggregates with one mapping
| * | | | | | Use public_send instead since respond_to? doesn't include private/protected ↵Ryuta Kamizono2019-01-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | methods by default Co-Authored-By: dylanahsmith <dylan.smith@shopify.com>
| * | | | | | Avoid using yield_self to make it easier to backportDylan Thacker-Smith2019-01-171-5/+4
| | | | | | |
| * | | | | | activerecord: Use a simpler query condition for aggregates with one mappingDylan Thacker-Smith2019-01-172-8/+14
| | | | | | |
* | | | | | | Action Text: bundle package.json in built gem.Kasper Timm Hansen2019-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After 866da19fd9fc12d001ab99ac87890ea1cebb2cd9 we now use package.json to install Action Text's JS dependencies (see JS_PACKAGE_PATH). But when the gem pacakge for Action Text is built, package.json was not included so running `rails action_text:install` in a Rails app would fail with: ``` rails action_text:install rails aborted! Errno::ENOENT: No such file or directory @ rb_sysopen - xxx/gems/actiontext-6.0.0.alpha/lib/templates/../../package.json ./bin/rails:4:in `<main>' Tasks: TOP => app:template (See full trace by running task with --trace) ```
* | | | | | | Use released webpackerRafael Mendonça França2019-01-173-12/+7
| | | | | | |
* | | | | | | Merge pull request #34966 from ↵Rafael Mendonça França2019-01-173-4/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bogdanvlviv/ensure-ar-relation-exists-allows-permitted-params Ensure that AR::Relation#exists? allows only permitted params
| * | | | | | | Ensure that AR::Relation#exists? allows only permitted paramsbogdanvlviv2019-01-173-7/+17
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify changelog entry Related to #34891
* | | | | | | Merge pull request #34954 from rails/rm-remove-5.2-deprecationsRafael França2019-01-1767-1189/+210
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Remove all code deprecated in Rails 5.2
| * | | | | | Remove deprecated `after_bundle` helper inside plugins templatesRafael Mendonça França2019-01-175-53/+16
| | | | | | |
| * | | | | | Remove deprecated `server` argument from the rails server commandRafael Mendonça França2019-01-173-25/+6
| | | | | | |
| * | | | | | Remove deprecated support to old `config.ru` that use the application class ↵Rafael Mendonça França2019-01-173-27/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | as argument of `run`
| * | | | | | Remove deprecated `environment` argument from the rails commandsRafael Mendonça França2019-01-175-55/+10
| | | | | | |
| * | | | | | Remove deprecated `capify!`Rafael Mendonça França2019-01-173-18/+4
| | | | | | |
| * | | | | | Remove secret_token rack env and cookie upgrade codeRafael Mendonça França2019-01-177-261/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that secret_token was removed all this code is now dead.
| * | | | | | Remove deprecated `config.secret_token`Rafael Mendonça França2019-01-177-233/+13
| | | | | | |
| * | | | | | Remove deprecated `Module#reachable?` methodRafael Mendonça França2019-01-174-58/+5
| | | | | | |
| * | | | | | Remove deprecated `#acronym_regex` method from `Inflections`Rafael Mendonça França2019-01-174-9/+5
| | | | | | |
| * | | | | | Remove deprecated `#set_state` from the transaction objectRafael Mendonça França2019-01-173-29/+4
| | | | | | |
| * | | | | | Remove deprecated `#supports_statement_cache?` from the database adaptersRafael Mendonça França2019-01-173-11/+4
| | | | | | |
| * | | | | | Remove deprecated `#insert_fixtures` from the database adaptersRafael Mendonça França2019-01-175-43/+5
| | | | | | |
| * | | | | | Remove deprecated ↵Rafael Mendonça França2019-01-173-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?`
| * | | | | | Do not allow passing the column name to `sum` when a block is passedRafael Mendonça França2019-01-173-9/+11
| | | | | | |
| * | | | | | Do not allow passing the column name to `count` when a block is passedRafael Mendonça França2019-01-173-9/+11
| | | | | | |
| * | | | | | Remove delegation of missing methods in a relation to arelRafael Mendonça França2019-01-173-20/+4
| | | | | | |
| * | | | | | Remove delegation of missing methods in a relation to private methods of the ↵Rafael Mendonça França2019-01-173-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | class
| * | | | | | Change `SQLite3Adapter` to always represent boolean values as integersRafael Mendonça França2019-01-178-109/+44
| | | | | | |
| * | | | | | Remove ability to specify a timestamp name for `#cache_key`Rafael Mendonça França2019-01-174-31/+10
| | | | | | |
| * | | | | | Remove deprecated `ActiveRecord::Migrator.migrations_path=`Rafael Mendonça França2019-01-173-17/+4
| | | | | | |
| * | | | | | Remove deprecated `expand_hash_conditions_for_aggregates`Rafael Mendonça França2019-01-173-46/+7
| | | | | | |
| * | | | | | Remove deprecated image_alt helperRafael Mendonça França2019-01-173-43/+4
| | | | | | |
| * | | | | | Remove deprecated `fragment_cache_key` helper in favor of ↵Rafael Mendonça França2019-01-173-27/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `combined_fragment_cache_key`
| * | | | | | Remove deprecated methods in ActionDispatch::TestResponseRafael Mendonça França2019-01-173-34/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of `#successful?`, `not_found?` and `server_error?`.
| * | | | | | Update the promisse that ActionController::TestCase will be extractedRafael Mendonça França2019-01-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are past 5.1 and it was not extrated yet, so while we still have plans they will not be realized on 6.0, so it is better to not set expectations of which release will exclude it just yet. [ci skip]
* | | | | | | Merge pull request #34967 from lifo/am-handle-duplicate-emailsGeorge Claghorn2019-01-174-10/+9
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Update test schema.rb to reflect the recent changes
| * | | | | | Use create_and_extract_message_id! to create an inbound email.Pratik Naik2019-01-171-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes sure the created email has checksum and message id columns set.
| * | | | | | Specify a name for [ message_id, message_checksum ] index to ensure the name ↵Pratik Naik2019-01-173-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | does not exceed the limit. Also, update test schema to reflect the recent changes.
* | | | | | | Merge pull request #34412 from gmcgibbon/redirect_to_allow_other_hostRafael França2019-01-177-29/+87
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Ensure external redirects are explicitly allowed
| * | | | | | | Ensure external redirects are explicitly allowedGannon McGibbon2019-01-177-29/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `fallback_location` and `allow_other_host` options to `redirect_to`.
* | | | | | | | Merge pull request #34962 from lifo/am-handle-duplicate-emailsGeorge Claghorn2019-01-176-15/+44
|\ \ \ \ \ \ \ \ | | |/ / / / / / | |/| | / / / / | |_|_|/ / / / |/| | | | | | Ensure Action Mailbox processes an email only once
| * | | | | | Ensure Action Mailbox processes an email only once when received multiple timesPratik Naik2019-01-176-15/+44
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also adds a new column, message_checksum, to the action_mailbox_inbound_emails table for storing SHA1 digest of the email source. Additionally, it makes generating the missing message id deterministic and adds a unique index on message_checksum and message_id to detect duplicate emails.
* | | | | | Merge pull request #34958 from javan/actiontext/trix-as-peerJavan Makhmali2019-01-173-11/+23
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Declare Trix as peer dependency of Action Text's npm package
| * | | | | Tidy up action_text:install taskJavan Makhmali2019-01-171-9/+20
| | | | | | | | | | | | | | | | | | | | | | | | Automate installing the appropriate packages with yarn and appending them to the default application.js pack.
| * | | | | Make trix a peer dependency of actiontext since it’s not used directlyJavan Makhmali2019-01-172-2/+3
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-21 17:59:41 +0000