diff options
| author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2019-01-14 15:25:52 -0500 | 
|---|---|---|
| committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2019-01-17 16:08:31 -0500 | 
| commit | 60c8a03c8d1e45e48fcb1055ba4c49ed3d5ff78f (patch) | |
| tree | 671c34049bdb773a23cbba4f625001daeb11332d | |
| parent | e70d3df7c9b05c129b0fdcca57f66eca316c5cfc (diff) | |
| download | rails-60c8a03c8d1e45e48fcb1055ba4c49ed3d5ff78f.tar.gz rails-60c8a03c8d1e45e48fcb1055ba4c49ed3d5ff78f.tar.bz2 rails-60c8a03c8d1e45e48fcb1055ba4c49ed3d5ff78f.zip  | |
Remove deprecated image_alt helper
| -rw-r--r-- | actionview/CHANGELOG.md | 4 | ||||
| -rw-r--r-- | actionview/lib/action_view/helpers/asset_tag_helper.rb | 23 | ||||
| -rw-r--r-- | actionview/test/template/asset_tag_helper_test.rb | 20 | 
3 files changed, 4 insertions, 43 deletions
diff --git a/actionview/CHANGELOG.md b/actionview/CHANGELOG.md index 36f10958b6..5b2ea6c556 100644 --- a/actionview/CHANGELOG.md +++ b/actionview/CHANGELOG.md @@ -1,3 +1,7 @@ +*   Remove deprecated `image_alt` helper. + +    *Rafael Mendonça França* +  *   Fix the need of `#protect_against_forgery?` method defined in      `ActionView::Base` subclasses. This prevents the use of forms and buttons. diff --git a/actionview/lib/action_view/helpers/asset_tag_helper.rb b/actionview/lib/action_view/helpers/asset_tag_helper.rb index 3d7c8dae75..c186cb8422 100644 --- a/actionview/lib/action_view/helpers/asset_tag_helper.rb +++ b/actionview/lib/action_view/helpers/asset_tag_helper.rb @@ -355,29 +355,6 @@ module ActionView          tag("img", options)        end -      # Returns a string suitable for an HTML image tag alt attribute. -      # The +src+ argument is meant to be an image file path. -      # The method removes the basename of the file path and the digest, -      # if any. It also removes hyphens and underscores from file names and -      # replaces them with spaces, returning a space-separated, titleized -      # string. -      # -      # ==== Examples -      # -      #   image_alt('rails.png') -      #   # => Rails -      # -      #   image_alt('hyphenated-file-name.png') -      #   # => Hyphenated file name -      # -      #   image_alt('underscored_file_name.png') -      #   # => Underscored file name -      def image_alt(src) -        ActiveSupport::Deprecation.warn("image_alt is deprecated and will be removed from Rails 6.0. You must explicitly set alt text on images.") - -        File.basename(src, ".*").sub(/-[[:xdigit:]]{32,64}\z/, "").tr("-_", " ").capitalize -      end -        # Returns an HTML video tag for the +sources+. If +sources+ is a string,        # a single video tag will be returned. If +sources+ is an array, a video        # tag with nested source tags for each source will be returned. The diff --git a/actionview/test/template/asset_tag_helper_test.rb b/actionview/test/template/asset_tag_helper_test.rb index e68f03d1f4..e371a87614 100644 --- a/actionview/test/template/asset_tag_helper_test.rb +++ b/actionview/test/template/asset_tag_helper_test.rb @@ -512,26 +512,6 @@ class AssetTagHelperTest < ActionView::TestCase      UrlToImageToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) }    end -  def test_image_alt -    [nil, "/", "/foo/bar/", "foo/bar/"].each do |prefix| -      assert_deprecated do -        assert_equal "Rails", image_alt("#{prefix}rails.png") -      end -      assert_deprecated do -        assert_equal "Rails", image_alt("#{prefix}rails-9c0a079bdd7701d7e729bd956823d153.png") -      end -      assert_deprecated do -        assert_equal "Rails", image_alt("#{prefix}rails-f56ef62bc41b040664e801a38f068082a75d506d9048307e8096737463503d0b.png") -      end -      assert_deprecated do -        assert_equal "Long file name with hyphens", image_alt("#{prefix}long-file-name-with-hyphens.png") -      end -      assert_deprecated do -        assert_equal "Long file name with underscores", image_alt("#{prefix}long_file_name_with_underscores.png") -      end -    end -  end -    def test_image_tag      ImageLinkToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) }    end  | 
