| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
| |
Using broadcast directly off server is not recommended
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rails Guide for Action Cable
Added content from README
Pull additional information from Action Cable README and restructured Client/Server elements
Update to list numbering
Switched from list numbers to headings in the examples
Change AppearancesChannel to AppearanceChannel
Word missing
fixed missing word.
Removed Mistaken nesting of Channel class
Removed nesting of ChatChannel and AppearanceChannel from within ApplicationChannel Module. (Copy&Paste error)
Incorporated first round of comments
1. Capitalize "action cable"
2. Separated "Consumers require... via JavaScript" into two sentences
3. Minor typographical correction (remember...)
4. Extra backtick
5. Revised text which implied Redis was the exclusive storage adapter to reflect it's position as default.
6. Revised reference to denote correct config file location: config/cable.yml
7. Added adapter: redis to environment configuration blocks
8. Capitalized "R" for "Rack"
9. Revised syntax for routing to reflect the hash syntax. (to: NOT :to =>)
10. Removed reference to Action Cable being separate from Rails.
11. Began revision for adapter API [I believe this requires a reformatting of the 'Redis' portion of the configuration section to simply "Storage Adapters"]
12. Celluloid -> Concurrent-ruby
Moved errant grave mark [ci skip]
Reordered "In App" above "Standalone" [ci skip]
Reordered to reflect "In App" as preferable to "Standalone"
Action Cable Deployment [ci skip]
Removed paragraph that alludes to Action Cable not being able to run in the same process as Rails.
Removed EM reference and updated deployment [ci skip]
Removed explicit multi-threaded server dependency reference [ci skip]
Revised Configuration and fixed typos [ci skip]
Switched Lifecycle Graphic for Detailed Description [ci skip]
Switched from Lifecycle graphic to detailed description to facilitate revision and maintainability in the future.
Capitalized Heading (typo) [ci skip]
Implemented merged commits from README [ci skip]
Pulled over all (or at least I believe all) merged commits from README. (Dec 14, 2015 - Feb 11, 2016)
Editorial - Capitalize WebSockets [ci skip]
Reformated lines to ~75 characters [ci skip]
|
|
|
|
| |
:tada: :beers:
|
| |
|
|\
| |
| | |
Fix `receive` spelling
|
| | |
|
|\ \
| | |
| | | |
Handle specified schemas when removing a Postgres index
|
| | | |
|
|\ \ \
| |_|/
|/| | |
[ActionCable] Test invalid action on channel
|
| | | |
|
|/ /
| |
| |
| |
| | |
Found `recieve` next to the correctly spelled method name, fixed it.
Also we prefer a one space padding within hashes, add that.
|
|\ \
| | |
| | | |
[ActionCable] test perform action with default action
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This test needs to have a require for the Listen gem or else it returns
an error when run by itself or with a certain order in the Active
Support tests. We use `silence_warnings` because Listen has some
warnings about private methods. It's already silenced when it's required
in Active Support EventedFileUpdateChecker.
```
1) Error:
EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given:
NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen
test/evented_file_update_checker_test.rb:21:in `teardown'
```
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The test was was in here twice so we were seeing this error:
```
activesupport/test/caching_test.rb:658:
warning: method redefined; discarding old test_local_cache_of_read_nil
activesupport/test/caching_test.rb:634:
warning: previous definition of test_local_cache_of_read_nil was here
```
|
|/ / |
|
|\ \
| | |
| | | |
Fix "instance variable not initialized" in tests
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The ActionPack test suite had a handful of these warnings when run. This
was due to `assert_response` being tested outside the context of a
controller instance where those instance variables would already have
been initialized.
|
|\ \ \
| | | |
| | | | |
Prevent ActionController::Parameters in url_for
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
add line break between method of generated channel js
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
```
# before
App.appearance = App.cable.subscriptions.create "AppearanceChannel",
connected: ->
# Called when the subscription is ready for use on the server
disconnected: ->
# Called when the subscription has been terminated by the server
received: (data) ->
# Called when there's incoming data on the websocket for this channel
appear: ->
@perform 'appear'
away: ->
@perform 'away'
```
```
# after
App.appearance = App.cable.subscriptions.create "AppearanceChannel",
connected: ->
# Called when the subscription is ready for use on the server
disconnected: ->
# Called when the subscription has been terminated by the server
received: (data) ->
# Called when there's incoming data on the websocket for this channel
appear: ->
@perform 'appear'
away: ->
@perform 'away'
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ActionCable] Test available actions on Channel
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Our logic is complex now and we don't need to check the version to asset
the behavior so I'm removing the checking here.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | | |
Allow normal version updates within a release series
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We originally chose to apply very strict versioning on the `rails` entry
in the Gemfile, because our future versioning policy was not strongly
defined.
Now it is, and our policy is very much designed on the expectation that
people will regularly update to the latest patch level in their release
series... so we should encourage that.
Of course, Gemfile.lock will do its job and prevent unplanned updates,
just as it does for every other gem in the bundle... but if you run
`bundle update`, we want to get you the latest bug/security fixes
without requiring a manual edit of the Gemfile entry.
Our current version could be a few different shapes, so it takes a bit
of work to find the right specifier, but in principle, we match anything
of the form x.y.*, where x.y matches our current release series.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Still more to do. Please assist!
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | | |
We went back to `Thread.current[]` in 33e11e59.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Fix grammar
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
this at a high level
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
accessors"
This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
fix indentation of generated controller test
|