diff options
| author | Kasper Timm Hansen <kaspth@gmail.com> | 2015-12-18 12:37:08 +0100 |
|---|---|---|
| committer | Kasper Timm Hansen <kaspth@gmail.com> | 2015-12-18 12:37:08 +0100 |
| commit | 49f2f0988ba5de7bf51602a1efeadc168dbbf58d (patch) | |
| tree | 6bb5c90dd71384f40630548ebaeb8ef91fd037c2 | |
| parent | e50ea481dd4ee2e82e947835dff849f28130c2c2 (diff) | |
| parent | ebad5c72d3e55b855a552bb6d86e7b44330faab4 (diff) | |
| download | rails-49f2f0988ba5de7bf51602a1efeadc168dbbf58d.tar.gz rails-49f2f0988ba5de7bf51602a1efeadc168dbbf58d.tar.bz2 rails-49f2f0988ba5de7bf51602a1efeadc168dbbf58d.zip | |
Merge pull request #22656 from akshay-vishnoi/fix-typos
[ci skip] Fix grammar
| -rw-r--r-- | actioncable/README.md | 6 | ||||
| -rw-r--r-- | actioncable/lib/action_cable/server/base.rb | 2 | ||||
| -rw-r--r-- | actioncable/lib/action_cable/server/broadcasting.rb | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/actioncable/README.md b/actioncable/README.md index 13b79d15ca..4262046482 100644 --- a/actioncable/README.md +++ b/actioncable/README.md @@ -202,7 +202,7 @@ end ``` ```coffeescript -# Client-side which assumes you've already requested the right to send web notifications +# Client-side, which assumes you've already requested the right to send web notifications App.cable.subscriptions.create "WebNotificationsChannel", received: (data) -> new Notification data["title"], body: data["body"] @@ -236,7 +236,7 @@ end Pass an object as the first argument to `subscriptions.create`, and that object will become your params hash in your cable channel. The keyword `channel` is required. ```coffeescript -# Client-side which assumes you've already requested the right to send web notifications +# Client-side, which assumes you've already requested the right to send web notifications App.cable.subscriptions.create { channel: "ChatChannel", room: "Best Room" }, received: (data) -> @appendLine(data) @@ -279,7 +279,7 @@ end ``` ```coffeescript -# Client-side which assumes you've already requested the right to send web notifications +# Client-side, which assumes you've already requested the right to send web notifications App.chatChannel = App.cable.subscriptions.create { channel: "ChatChannel", room: "Best Room" }, received: (data) -> # data => { sent_by: "Paul", body: "This is a cool chat app." } diff --git a/actioncable/lib/action_cable/server/base.rb b/actioncable/lib/action_cable/server/base.rb index 5f44bdd1c3..740e4b301e 100644 --- a/actioncable/lib/action_cable/server/base.rb +++ b/actioncable/lib/action_cable/server/base.rb @@ -42,7 +42,7 @@ module ActionCable @worker_pool ||= ActionCable::Server::Worker.pool(size: config.worker_pool_size) end - # Requires and returns an hash of all the channel class constants keyed by name. + # Requires and returns a hash of all the channel class constants keyed by name. def channel_classes @channel_classes ||= begin config.channel_paths.each { |channel_path| require channel_path } diff --git a/actioncable/lib/action_cable/server/broadcasting.rb b/actioncable/lib/action_cable/server/broadcasting.rb index 6e0fbae387..c759239a0e 100644 --- a/actioncable/lib/action_cable/server/broadcasting.rb +++ b/actioncable/lib/action_cable/server/broadcasting.rb @@ -15,7 +15,7 @@ module ActionCable # ActionCable.server.broadcast \ # "web_notifications_1", { title: 'New things!', body: 'All shit fit for print' } # - # # Client-side coffescript which assumes you've already requested the right to send web notifications + # # Client-side coffescript, which assumes you've already requested the right to send web notifications # App.cable.subscriptions.create "WebNotificationsChannel", # received: (data) -> # new Notification data['title'], body: data['body'] |