aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add some FIXME notes about documentation [ci skip]Rafael Mendonça França2014-12-021-0/+4
|
* Prefer object/nil over `true`/`false`Rafael Mendonça França2014-12-021-6/+4
| | | | | | | | | | | This is the project guideline and the reasons are: * That follows standard Ruby semantics. * Allows the implementation to avoid artificial code like !! or something ? true : false * You do not need to rely on the exact type of 3rd party code. For example, if your method returns str.end_with?('foo') you do not need to make sure end_with? returns a singleton. Your predicate just propagates predicate semantics up regardless of what end_with? returns.
* Merge pull request #17873 from kirs/refactor-debug-erbRafael Mendonça França2014-12-024-23/+54
|\ | | | | Refactor debug view
| * Refactor debug viewKir Shatrov2014-12-024-23/+54
| | | | | | Avoid logic in ERB and use helpers
* | Merge pull request #17727 from lleger/lleger-add-methods-to-message-verifierSean Griffin2014-12-023-22/+47
|\ \ | | | | | | Add new methods to MessageVerifier
| * | Add `#verified` and `#valid_message?` to MessageVerifierLogan Leger2014-12-013-22/+47
| |/ | | | | | | | | | | | | | | | | | | | | This commit adds a `#verified` method to `ActiveSupport::MessageVerifier` which will return either `false` when it encounters an error or the message. `#verify` continues to raise an `InvalidSignature` exception on error. This commit also adds a convenience boolean method on `MessageVerifier` as a way to check if a message is valid without performing the decoding.
* | Merge pull request #17867 from tgxworld/silence_minitest_pluginsRafael Mendonça França2014-12-022-1/+4
|\ \ | | | | | | Silence Minitest for plugin tests.
| * | Silence Minitest for plugin tests.Guo Xiang Tan2014-12-022-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/17340. Use Minitest::BacktraceFilter instead of removing all silencers. This will allow the backtrace for all libraries in the plugin to be shown while removing noise generated by Minitest's backtrace.
* | | Merge pull request #17862 from lucasmazza/lm-hide-actionRafael Mendonça França2014-12-022-1/+4
| | | | | | | | | | | | `_generate_paths_by_default` should always be private.
* | | Allow failures for mysql adapter testsRafael Mendonça França2014-12-021-2/+1
| | |
* | | Merge pull request #17576 from senny/native_database_typesYves Senn2014-12-024-7/+13
|\ \ \ | | | | | | | | no need to pass native_database_types around
| * | | no need to pass native_database_types aroundYves Senn2014-12-024-7/+13
|/ / /
* | | pg tests, get rid of global schema `schema_1`.Yves Senn2014-12-023-53/+51
| | |
* | | pg tests, move uniqueness validation test to array tests.Yves Senn2014-12-023-27/+16
| | |
* | | tests, extract pg number tests into separate file.Yves Senn2014-12-023-44/+51
| | |
* | | tests, move schema shorthand assertions into pg specific tests.Yves Senn2014-12-0210-131/+89
| | |
* | | tests, move pg geometric tests out of `base_test`.Yves Senn2014-12-023-106/+73
| | |
* | | Merge pull request #17878 from claudiob/remove-unused-modgreet-fixtureYves Senn2014-12-021-1/+0
|\ \ \ | | | | | | | | Remove unused AV/test/fixtures/scope
| * | | Remove unused AV/test/fixtures/scopeclaudiob2014-12-011-1/+0
| |/ / | | | | | | | | | | | | The file `modgreet.erb` was added 8 years ago in 21187c0 and is not used anymore by any test.
* | | Merge pull request #17877 from claudiob/remove-happy-path-fixtureYves Senn2014-12-021-1/+0
|\ \ \ | |/ / |/| | Remove unused AV/test/fixtures/happy_path
| * | Remove unused AV/test/fixtures/happy_pathclaudiob2014-12-011-1/+0
|/ / | | | | | | | | | | | | | | | | | | The `test/fixtures/happy_path/render_action/hello_world.erb` file was introduced in 8ab37c7 for the `TestRenderAction` test. That test was subsequently removed in 34f058e, so the fixture is not used anymore. If Travis CI is happy, then you can be sure the fixture can be removed.
* | Merge pull request #17871 from claudiob/remove-unused-blog-public-fixturesSantiago Pastorino2014-12-024-4/+0
|\ \ | | | | | | Remove unused AV/test/fixtures/blog_public
| * | Remove unused AV/test/fixtures/blog_publicclaudiob2014-12-014-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | The fixtures were added to support StaticTests in 401cd97 but those tests were then removed in d5ad92ce. If Travis CI is happy with this PR, then you can be sure that those fixtures are not needed anymore.
* | | Merge pull request #17872 from ↵Santiago Pastorino2014-12-021-3/+0
|\ \ \ | |_|/ |/| | | | | | | | claudiob/remove-duplicate-functional-caching-fixture Remove one AV fixture (duplicate of an AP fixture)
| * | Remove one AV fixture (duplicate of an AP fixture)claudiob2014-12-011-3/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | Both ActionPack and ActionView include `test/fixtures/functional_caching/fragment_cached_without_digest.html.erb`. The [ActionPack file](https://github.com/rails/rails/blob/master/actionpack/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is used by the tests. The [ActionView file](https://github.com/rails/rails/blob/master/actionview/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is not: it was introduced in eb23754e when some tests and fixtures were moved from AP to AV, but no tests in AV uses the fixture. Long story short: if Travis CI is happy with removing the fixture, you can be sure that is not needed anymore!
* | Merge pull request #17866 from bogdan/default-form-builderSantiago Pastorino2014-12-012-1/+42
|\ \ | |/ |/| Bugfix config.action_view.default_form_builder option
| * Bugfix config.action_view.default_form_builder optionBogdan Gusiev2014-12-012-1/+42
| |
* | ugh, forgot to add this test to cdd90f39d796986dabf1678b3277b230dbe18961Aaron Patterson2014-12-011-0/+5
| |
* | Merge pull request #17869 from 2called-chaos/patch-1Xavier Noria2014-12-011-1/+1
|\ \ | | | | | | Fix documentation for ActionMailer::Base#default [ci skip]
| * | Fix documentation for #defaultSven Pachnit2014-12-011-1/+1
|/ / | | | | Just a little syntax error I spotted by accident. Cannot pass hash with curly braces without normal parentheses.
* | tests, favor public API over inspecting columns where possible.Yves Senn2014-12-013-23/+20
| | | | | | | | | | This is a follow up to https://github.com/rails/rails/commit/07786c5e75a7b0afdf318063510af6b475e3e04c and https://github.com/rails/rails/commit/cd2596f55e88fe659592612a793c4f4aa723c9be
* | Merge pull request #17827 from rkh/rkh-fix-or-patternAaron Patterson2014-12-012-0/+7
|\ \ | | | | | | Fix OR in Journey patterns
| * | make OR in journey patterns compile to a valid regular expressionKonstantin Haase2014-11-292-0/+7
| | |
* | | tests, run numeric default tests for every adapter.Yves Senn2014-12-011-15/+33
| | |
* | | tests, use public API to verify default parsing. #17863, #17856Yves Senn2014-12-011-1/+2
| | |
* | | Merge pull request #17863 from ↵Rafael Mendonça França2014-12-012-1/+5
|\ \ \ | | | | | | | | | | | | | | | | tgxworld/fix_extracated_default_value_for_negative_integers Fix value extracted from negative integers for PostgreSQL.
| * | | Fix value extracted from negative integers for PostgreSQL.Guo Xiang Tan2014-12-012-1/+5
|/ / / | | | | | | | | | Fixes: https://github.com/rails/rails/issues/17856.
* | | Merge pull request #17861 from kirs/pp-request-paramsRafael Mendonça França2014-12-012-1/+9
|\ \ \ | | | | | | | | Pretty-print request params on exception page
| * | | Pretty-print request params on exception pageKir Shatrov2014-12-012-1/+9
| | | |
* | | | Ensure numericality validations work with mutationSean Griffin2014-12-013-6/+30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The detection of in-place changes caused a weird unexpected issue with numericality validations. That validator (out of necessity) works on the `_before_type_cast` version of the attribute, since on an `:integer` type column, a non-numeric string would type cast to 0. However, strings are mutable, and we changed strings to ensure that the post type cast version of the attribute was a different instance than the before type cast version (so the mutation detection can work properly). Even though strings are the only mutable type for which a numericality validation makes sense, special casing strings would feel like a strange change to make here. Instead, we can make the assumption that for all mutable types, we should work on the post-type-cast version of the attribute, since all cases which would return 0 for non-numeric strings are immutable. Fixes #17852
* | | Merge pull request #17860 from SamSaffron/fix_engine_backtraceRafael Mendonça França2014-11-301-1/+1
|\ \ \ | | | | | | | | FIX: absolute_path may be nil for code added via instance_eval
| * | | FIX: absolute_path may be nil for code added via instance_evalSam2014-12-011-1/+1
|/ / /
* | | Fix grammar on ActiveRecord::AttributeMethods doc.Hendy Tanata2014-11-301-1/+1
| | | | | | | | | | | | [ci skip]
* | | [Testing guide] Using "Fixtures API" consistentlyPrathamesh Sonpatki2014-11-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | - In guides, "API" is used consistently instead of "api". - Reason behind replacing "fixtures API" to "Fixtures API" is because here we are referring to the concept of "fixtures". In other places in the guide "fixture" OR "fixtures" is referred to the single or multiple instances of test data. - This is also followup of https://github.com/rails/docrails/commit/aa9d1332b20305dd860b21a7ada06c5252bebad5#commitcomment-8497376.
* | | [Testing guide] Use "Fixtures API" instead of "fixture api".Prathamesh Sonpatki2014-11-301-1/+1
| | |
* | | Merge pull request #17850 from y-yagi/patch-2Richard Schneeman2014-11-302-18/+1
|\ \ \ | | | | | | | | [ci skip] fix description of url_for
| * | | [ci skip] fix description of url_foryuuji.yaginuma2014-11-302-18/+1
| | | |
* | | | Update Arel usage for rails/arel#98fc259Sean Griffin2014-11-294-8/+8
|/ / / | | | | | | | | | | | | `where_sql` now requires that we pass it an engine. None of the manager classes take an engine in their constructor.
* | | Use arel masterSean Griffin2014-11-291-0/+1
| | |
* | | Stop using `Arel::Table.engine`Sean Griffin2014-11-294-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We never actually make use of it on the table, since we're constructing the select manager manually. It looks like if we ever actually were grabbing it from the table, we're grossly misusing it since it's meant to vary by AR class. Its existence on `Arel::Table` appears to be purely for convenience methods that are never used outside of tests. However, in production code it just complicates construction of the tables on the rails side, and the plan is to remove it from `Arel::Table` entirely. I'm not convinced it needs to live on `SelectManager`, etc either.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 04:22:40 +0000