aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2014-12-01 11:37:17 -0200
committerRafael Mendonça França <rafaelmfranca@gmail.com>2014-12-01 11:37:17 -0200
commit6acd4920c9728478f8e033658fe6c9c1883f59b1 (patch)
tree0a2b9defc636126209ff123cce2574d23ce0c6a5
parent704c658531ae202715cba29d6b2ba64651f220fd (diff)
parent9c15d23a7771d883cf8235cb516eec611a6bee19 (diff)
downloadrails-6acd4920c9728478f8e033658fe6c9c1883f59b1.tar.gz
rails-6acd4920c9728478f8e033658fe6c9c1883f59b1.tar.bz2
rails-6acd4920c9728478f8e033658fe6c9c1883f59b1.zip
Merge pull request #17861 from kirs/pp-request-params
Pretty-print request params on exception page
-rw-r--r--actionpack/lib/action_dispatch/middleware/exception_wrapper.rb1
-rw-r--r--actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb9
2 files changed, 9 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb b/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb
index a4862e33aa..8edeeaf2af 100644
--- a/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb
+++ b/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb
@@ -1,5 +1,6 @@
require 'action_controller/metal/exceptions'
require 'active_support/core_ext/module/attribute_accessors'
+require 'pp'
module ActionDispatch
class ExceptionWrapper
diff --git a/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb b/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
index db219c8fa9..761cd0ffcc 100644
--- a/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
+++ b/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
@@ -10,7 +10,14 @@
clean_params.delete("action")
clean_params.delete("controller")
- request_dump = clean_params.empty? ? 'None' : clean_params.inspect.gsub(',', ",\n")
+ request_dump = if clean_params.empty?
+ 'None'
+ else
+ pretty_params = ""
+ PP.pp(clean_params, pretty_params, 200)
+
+ pretty_params
+ end
def debug_hash(object)
object.to_hash.sort_by { |k, _| k.to_s }.map { |k, v| "#{k}: #{v.inspect rescue $!.message}" }.join("\n")