Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | Ensure that AR::Relation#exists? allows only permitted params | bogdanvlviv | 2019-01-17 | 3 | -7/+17 | |
| |/ / / / | | | | | | | | | | | | | | | | | | | | | Clarify changelog entry Related to #34891 | |||||
* | | | | | Merge pull request #34954 from rails/rm-remove-5.2-deprecations | Rafael França | 2019-01-17 | 67 | -1189/+210 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Remove all code deprecated in Rails 5.2 | |||||
| * | | | | Remove deprecated `after_bundle` helper inside plugins templates | Rafael Mendonça França | 2019-01-17 | 5 | -53/+16 | |
| | | | | | ||||||
| * | | | | Remove deprecated `server` argument from the rails server command | Rafael Mendonça França | 2019-01-17 | 3 | -25/+6 | |
| | | | | | ||||||
| * | | | | Remove deprecated support to old `config.ru` that use the application class ↵ | Rafael Mendonça França | 2019-01-17 | 3 | -27/+4 | |
| | | | | | | | | | | | | | | | | | | | | as argument of `run` | |||||
| * | | | | Remove deprecated `environment` argument from the rails commands | Rafael Mendonça França | 2019-01-17 | 5 | -55/+10 | |
| | | | | | ||||||
| * | | | | Remove deprecated `capify!` | Rafael Mendonça França | 2019-01-17 | 3 | -18/+4 | |
| | | | | | ||||||
| * | | | | Remove secret_token rack env and cookie upgrade code | Rafael Mendonça França | 2019-01-17 | 7 | -261/+19 | |
| | | | | | | | | | | | | | | | | | | | | Now that secret_token was removed all this code is now dead. | |||||
| * | | | | Remove deprecated `config.secret_token` | Rafael Mendonça França | 2019-01-17 | 7 | -233/+13 | |
| | | | | | ||||||
| * | | | | Remove deprecated `Module#reachable?` method | Rafael Mendonça França | 2019-01-17 | 4 | -58/+5 | |
| | | | | | ||||||
| * | | | | Remove deprecated `#acronym_regex` method from `Inflections` | Rafael Mendonça França | 2019-01-17 | 4 | -9/+5 | |
| | | | | | ||||||
| * | | | | Remove deprecated `#set_state` from the transaction object | Rafael Mendonça França | 2019-01-17 | 3 | -29/+4 | |
| | | | | | ||||||
| * | | | | Remove deprecated `#supports_statement_cache?` from the database adapters | Rafael Mendonça França | 2019-01-17 | 3 | -11/+4 | |
| | | | | | ||||||
| * | | | | Remove deprecated `#insert_fixtures` from the database adapters | Rafael Mendonça França | 2019-01-17 | 5 | -43/+5 | |
| | | | | | ||||||
| * | | | | Remove deprecated ↵ | Rafael Mendonça França | 2019-01-17 | 3 | -9/+4 | |
| | | | | | | | | | | | | | | | | | | | | `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?` | |||||
| * | | | | Do not allow passing the column name to `sum` when a block is passed | Rafael Mendonça França | 2019-01-17 | 3 | -9/+11 | |
| | | | | | ||||||
| * | | | | Do not allow passing the column name to `count` when a block is passed | Rafael Mendonça França | 2019-01-17 | 3 | -9/+11 | |
| | | | | | ||||||
| * | | | | Remove delegation of missing methods in a relation to arel | Rafael Mendonça França | 2019-01-17 | 3 | -20/+4 | |
| | | | | | ||||||
| * | | | | Remove delegation of missing methods in a relation to private methods of the ↵ | Rafael Mendonça França | 2019-01-17 | 3 | -12/+4 | |
| | | | | | | | | | | | | | | | | | | | | class | |||||
| * | | | | Change `SQLite3Adapter` to always represent boolean values as integers | Rafael Mendonça França | 2019-01-17 | 8 | -109/+44 | |
| | | | | | ||||||
| * | | | | Remove ability to specify a timestamp name for `#cache_key` | Rafael Mendonça França | 2019-01-17 | 4 | -31/+10 | |
| | | | | | ||||||
| * | | | | Remove deprecated `ActiveRecord::Migrator.migrations_path=` | Rafael Mendonça França | 2019-01-17 | 3 | -17/+4 | |
| | | | | | ||||||
| * | | | | Remove deprecated `expand_hash_conditions_for_aggregates` | Rafael Mendonça França | 2019-01-17 | 3 | -46/+7 | |
| | | | | | ||||||
| * | | | | Remove deprecated image_alt helper | Rafael Mendonça França | 2019-01-17 | 3 | -43/+4 | |
| | | | | | ||||||
| * | | | | Remove deprecated `fragment_cache_key` helper in favor of ↵ | Rafael Mendonça França | 2019-01-17 | 3 | -27/+4 | |
| | | | | | | | | | | | | | | | | | | | | `combined_fragment_cache_key` | |||||
| * | | | | Remove deprecated methods in ActionDispatch::TestResponse | Rafael Mendonça França | 2019-01-17 | 3 | -34/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of `#successful?`, `not_found?` and `server_error?`. | |||||
| * | | | | Update the promisse that ActionController::TestCase will be extracted | Rafael Mendonça França | 2019-01-17 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are past 5.1 and it was not extrated yet, so while we still have plans they will not be realized on 6.0, so it is better to not set expectations of which release will exclude it just yet. [ci skip] | |||||
* | | | | | Merge pull request #34967 from lifo/am-handle-duplicate-emails | George Claghorn | 2019-01-17 | 4 | -10/+9 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Update test schema.rb to reflect the recent changes | |||||
| * | | | | Use create_and_extract_message_id! to create an inbound email. | Pratik Naik | 2019-01-17 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | This makes sure the created email has checksum and message id columns set. | |||||
| * | | | | Specify a name for [ message_id, message_checksum ] index to ensure the name ↵ | Pratik Naik | 2019-01-17 | 3 | -8/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | does not exceed the limit. Also, update test schema to reflect the recent changes. | |||||
* | | | | | Merge pull request #34412 from gmcgibbon/redirect_to_allow_other_host | Rafael França | 2019-01-17 | 7 | -29/+87 | |
|\ \ \ \ \ | | | | | | | | | | | | | Ensure external redirects are explicitly allowed | |||||
| * | | | | | Ensure external redirects are explicitly allowed | Gannon McGibbon | 2019-01-17 | 7 | -29/+87 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Add `fallback_location` and `allow_other_host` options to `redirect_to`. | |||||
* | | | | | | Merge pull request #34962 from lifo/am-handle-duplicate-emails | George Claghorn | 2019-01-17 | 6 | -15/+44 | |
|\ \ \ \ \ \ | | |/ / / / | |/| | / / | |_|_|/ / |/| | | | | Ensure Action Mailbox processes an email only once | |||||
| * | | | | Ensure Action Mailbox processes an email only once when received multiple times | Pratik Naik | 2019-01-17 | 6 | -15/+44 | |
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | This also adds a new column, message_checksum, to the action_mailbox_inbound_emails table for storing SHA1 digest of the email source. Additionally, it makes generating the missing message id deterministic and adds a unique index on message_checksum and message_id to detect duplicate emails. | |||||
* | | | | Merge pull request #34958 from javan/actiontext/trix-as-peer | Javan Makhmali | 2019-01-17 | 3 | -11/+23 | |
|\ \ \ \ | |/ / / |/| | | | Declare Trix as peer dependency of Action Text's npm package | |||||
| * | | | Tidy up action_text:install task | Javan Makhmali | 2019-01-17 | 1 | -9/+20 | |
| | | | | | | | | | | | | | | | | Automate installing the appropriate packages with yarn and appending them to the default application.js pack. | |||||
| * | | | Make trix a peer dependency of actiontext since it’s not used directly | Javan Makhmali | 2019-01-17 | 2 | -2/+3 | |
| | | | | ||||||
* | | | | Merge pull request #34953 from gmcgibbon/seed_with_inline_jobs | Rafael França | 2019-01-17 | 3 | -1/+29 | |
|\ \ \ \ | |/ / / |/| | | | Seed database with inline ActiveJob job adapter | |||||
| * | | | Seed database with inline ActiveJob job adapter | Gannon McGibbon | 2019-01-17 | 3 | -1/+29 | |
| | | | | ||||||
* | | | | Merge pull request #34213 from matildasmeds/guides_session_guidelines_2 | Rafael França | 2019-01-17 | 1 | -68/+31 | |
|\ \ \ \ | |_|/ / |/| | | | Edit Security Guide's Session Guidelines & Custom Credentials [skip ci] | |||||
| * | | | Merge branch 'master' into guides_session_guidelines_2 | Matilda Smeds | 2018-12-09 | 473 | -9721/+14396 | |
| |\ \ \ | ||||||
| * | | | | Update guides/source/security.md | Derek Prior | 2018-10-18 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Update guides/source/security.md | Derek Prior | 2018-10-18 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Edit Security Guide's Session Guidelines & Custom Credentials [skip ci] | Matilda Smeds | 2018-10-14 | 1 | -68/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Edit Session Guidelines to achieve tighter prose and accuracy * Remove mentions related to earlier Rails versions * Add links to ActionController guide and Custom Credentials part * Clarify Custom Credentials part | |||||
* | | | | | Merge pull request #33419 from bogdanvlviv/update-active_storage | George Claghorn | 2019-01-16 | 6 | -1/+31 | |
|\ \ \ \ \ | | | | | | | | | | | | | `rake app:update` should update active_storage | |||||
| * | | | | | Add foreign key to active_storage_attachments for `blob_id` via new migration | bogdanvlviv | 2019-01-16 | 6 | -1/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need this in order to be able to add this migration for users that use ActiveStorage during update their apps from Rails 5.2 to Rails 6.0. Related to #33405 `rake app:update` should update active_storage `rake app:update` should execute `rake active_storage:update` if it is used in the app that is being updated. It will add new active_storage's migrations to users' apps during update Rails. Context https://github.com/rails/rails/pull/33405#discussion_r204239399 Also, see a related discussion in the Campfire: https://3.basecamp.com/3076981/buckets/24956/chats/12416418@1236713081 | |||||
* | | | | | | Add a space in framework names. Matches Active Record in generated Gemfile. | Kasper Timm Hansen | 2019-01-16 | 1 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #34941 from rmacklin/allow-actioncable-to-run-in-web-workers | Javan Makhmali | 2019-01-16 | 4 | -12/+12 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Avoid ReferenceError exceptions if ActionCable is used in a web worker | |||||
| * | | | | | | Remove explicit `document` receiver from add/removeEventListener calls | Richard Macklin | 2019-01-15 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows ActionCable to be used in a web worker, where the `document` global is undefined. Previously, attempting to use ActionCable inside a web worker would result in this exception after you try to open a connection: ``` ReferenceError: document is not defined ``` The visibilitychange event won't ever get triggered in a worker, so adding the listener is effectively a no-op there. But the listener is mainly a convenience, rather than a critical piece of the javascript interface, so using ActionCable in a worker will still work. (And you could listen for visibilitychange yourself in a window script, then tell the worker to reconnect if you still want that behavior.) | |||||
| * | | | | | | Replace `window` references in ActionCable with `self` | Richard Macklin | 2019-01-14 | 3 | -8/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this change, attempting to use ActionCable inside a web worker would result in an exception being thrown: ``` ReferenceError: window is not defined ``` By replacing the `window` reference with `self`, which is available in both a window context and a worker context, we can avoid this error. Ref: https://developer.mozilla.org/en-US/docs/Web/API/Window/self |