Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Update Minitest references in Testing Guide | Leandro Facchinetti | 2014-05-30 | 1 | -12/+8 |
| | | | | | | | | | | | | | | | | | | | | | The Guide references `test/unit`, which has been replaced by `Minitest` in all versions of Ruby supported by Rails. The following updates were performed: * The superclass of `ActiveSupport::TestCase` is no longer `MiniTest::Unit::TestCase`, but `Minitest::Test` [1]. * The preferred spelling is `Minitest`, not `MiniTest` [2]. * For a method to be a test in Minitest, its name must start with `test_`, not only `test` [3]. * Explanations about `test/unit` in Ruby 1.8 were removed in favor of more up-to-date information on `Minitest`. [1]: https://github.com/rails/rails/blob/6c2b569660c9216595d02ce6412e3bdcc7293317/activesupport/lib/active_support/test_case.rb#L18 [2]: https://github.com/seattlerb/minitest/blob/d5d43cef9a3fd4a0eea972dde125ed5ba1ddb821/lib/minitest.rb#L9 [3]: https://github.com/seattlerb/minitest/blob/d5d43cef9a3fd4a0eea972dde125ed5ba1ddb821/lib/minitest/test.rb#L62 | ||||
* | Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinct | Yves Senn | 2014-05-30 | 3 | -1/+17 |
|\ | | | | | | | | | | | | | Fixed #columns_for_distinct of postgresql adapter Conflicts: activerecord/CHANGELOG.md | ||||
| * | Fixed `columns_for_distinct` of postgresql adapter | Nikolay Kondratyev | 2013-08-15 | 3 | -1/+17 |
| | | |||||
* | | :scissors: removed deprecated `Numeric#ago` and friends | Godfrey Chan | 2014-05-30 | 3 | -62/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replacements: 5.ago => 5.seconds.ago 5.until => 5.seconds.until 5.since => 5.seconds.since 5.from_now => 5.seconds.from_now The removed tests does not affect coverage – we have equivalent test cases in the tests for `AS::Duration`. See #12389 for the history and rationale behind this. | ||||
* | | Merge pull request #15189 from senny/bin/setup | Yves Senn | 2014-05-30 | 4 | -1/+34 |
|\ \ | | | | | | | `bin/setup` script to bootstrap applications. | ||||
| * | | `bin/setup` script to bootstrap applications. | Yves Senn | 2014-05-30 | 4 | -1/+34 |
|/ / | |||||
* | | pg, `reset_pk_sequence!` respects schemas. Closes #14719. | Yves Senn | 2014-05-30 | 5 | -11/+34 |
| | | |||||
* | | pg, `PostgreSQL::Name` to hold schema qualified names. | Yves Senn | 2014-05-30 | 4 | -19/+96 |
| | | |||||
* | | Merge pull request #15417 from JuanitoFatas/doc/semver-of-rails | Zachary Scott | 2014-05-29 | 1 | -4/+23 |
|\ \ | | | | | | | [ci skip] Document Rails' shifted semver. | ||||
| * | | [ci skip] Document Rails' shifted semver. | Juanito Fatas | 2014-05-30 | 1 | -4/+23 |
|/ / | |||||
* | | Mapping never actually uses @set, so rm | Aaron Patterson | 2014-05-29 | 2 | -4/+4 |
| | | |||||
* | | no reason to make a Mapper object if the path is blank | Aaron Patterson | 2014-05-29 | 1 | -1/+2 |
| | | |||||
* | | Merge branch 'mapper' | Aaron Patterson | 2014-05-29 | 12 | -210/+220 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * mapper: (34 commits) no more is_a checks on instantiation Path::Pattern is instantiated internally, so make the contructor require a strexp object Strexp#names is only used in a test, so rm pass the parsed path from mapper to the Strexp add an alternate constructor to Strexp that takes a string ask the strexp for the ast remove dead code disconnect path from the instance reuse the ast we already made use a parser to extract the group parts from the path pass the parsed parameters through the methods so we don't reparse or require caching code "controllers" should be a valid path name controllers with slash names are also not supported, so we can reuse the message only validate controllers golf down a bit only error handling between controller and action is the same add a test for controllers without colons move nil check to a method that yields to a block if the value is not nil translate action / controller to the desired object only one nil check on the action variable ... | ||||
| * | | no more is_a checks on instantiation | Aaron Patterson | 2014-05-29 | 2 | -13/+4 |
| | | | |||||
| * | | Path::Pattern is instantiated internally, so make the contructor require a ↵ | Aaron Patterson | 2014-05-29 | 5 | -46/+49 |
| | | | | | | | | | | | | strexp object | ||||
| * | | Strexp#names is only used in a test, so rm | Aaron Patterson | 2014-05-29 | 2 | -36/+0 |
| | | | |||||
| * | | pass the parsed path from mapper to the Strexp | Aaron Patterson | 2014-05-29 | 2 | -5/+9 |
| | | | |||||
| * | | add an alternate constructor to Strexp that takes a string | Aaron Patterson | 2014-05-29 | 6 | -39/+41 |
| | | | |||||
| * | | ask the strexp for the ast | Aaron Patterson | 2014-05-29 | 2 | -3/+7 |
| | | | |||||
| * | | remove dead code | Aaron Patterson | 2014-05-29 | 1 | -1/+0 |
| | | | |||||
| * | | disconnect path from the instance | Aaron Patterson | 2014-05-29 | 1 | -6/+6 |
| | | | |||||
| * | | reuse the ast we already made | Aaron Patterson | 2014-05-29 | 1 | -9/+10 |
| | | | |||||
| * | | use a parser to extract the group parts from the path | Aaron Patterson | 2014-05-29 | 3 | -5/+9 |
| | | | |||||
| * | | pass the parsed parameters through the methods so we don't reparse or | Aaron Patterson | 2014-05-29 | 1 | -38/+34 |
| | | | | | | | | | | | | require caching code | ||||
| * | | Merge branch 'master' into mapper | Aaron Patterson | 2014-05-29 | 22 | -73/+148 |
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing | ||||
| * | | | "controllers" should be a valid path name | Aaron Patterson | 2014-05-29 | 2 | -1/+11 |
| | | | | |||||
| * | | | controllers with slash names are also not supported, so we can reuse the message | Aaron Patterson | 2014-05-28 | 1 | -6/+2 |
| | | | | |||||
| * | | | only validate controllers | Aaron Patterson | 2014-05-28 | 1 | -15/+17 |
| | | | | |||||
| * | | | golf down a bit | Aaron Patterson | 2014-05-28 | 1 | -8/+4 |
| | | | | |||||
| * | | | only error handling between controller and action is the same | Aaron Patterson | 2014-05-28 | 1 | -18/+16 |
| | | | | |||||
| * | | | add a test for controllers without colons | Aaron Patterson | 2014-05-28 | 1 | -0/+10 |
| | | | | |||||
| * | | | move nil check to a method that yields to a block if the value is not nil | Aaron Patterson | 2014-05-28 | 1 | -17/+16 |
| | | | | |||||
| * | | | translate action / controller to the desired object | Aaron Patterson | 2014-05-28 | 1 | -12/+11 |
| | | | | |||||
| * | | | only one nil check on the action variable | Aaron Patterson | 2014-05-28 | 1 | -10/+8 |
| | | | | |||||
| * | | | change to case / when on types | Aaron Patterson | 2014-05-28 | 1 | -8/+7 |
| | | | | |||||
| * | | | only do one nil check against the controller | Aaron Patterson | 2014-05-28 | 1 | -9/+9 |
| | | | | |||||
| * | | | extract controller and action parsing to a method | Aaron Patterson | 2014-05-28 | 1 | -19/+26 |
| | | | | |||||
| * | | | we don't need the call to presence. that is my present, to you! | Aaron Patterson | 2014-05-28 | 1 | -1/+1 |
| | | | | |||||
| * | | | swtich to returning early if to responds to call | Aaron Patterson | 2014-05-28 | 1 | -35/+32 |
| | | | | |||||
| * | | | return early if we have a valid controller name | Aaron Patterson | 2014-05-28 | 1 | -5/+5 |
| | | | | |||||
| * | | | trade 2 is_a? checks for a nil check | Aaron Patterson | 2014-05-28 | 1 | -2/+4 |
| | | | | |||||
| * | | | invert logic to remove nil? and exclude? checks (use ruby rather than AS ↵ | Aaron Patterson | 2014-05-28 | 1 | -6/+6 |
| | | | | | | | | | | | | | | | | when possible | ||||
| * | | | fewer blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+4 |
| | | | | |||||
| * | | | reduce action.blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+6 |
| | | | | |||||
| * | | | reduce blank? checks | Aaron Patterson | 2014-05-28 | 1 | -4/+9 |
| | | | | |||||
| * | | | extract controller checks to methods | Aaron Patterson | 2014-05-28 | 1 | -19/+26 |
| | | | | |||||
| * | | | set defaults at the top so we can avoid the ||= test | Aaron Patterson | 2014-05-28 | 1 | -6/+9 |
| | | | | |||||
| * | | | add a test for existing mapper functionality | Aaron Patterson | 2014-05-28 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior | ||||
* | | | | Merge pull request #15414 from akshay-vishnoi/doc_changes | Rafael Mendonça França | 2014-05-29 | 1 | -2/+3 |
|\ \ \ \ | | | | | | | | | | | [ci skip] Include ActiveModel::Model in a class instead of inheriting | ||||
| * | | | | [ci skip] Include ActiveModel::Model in a class instead of inheriting | Akshay Vishnoi | 2014-05-30 | 1 | -2/+3 |
|/ / / / |