aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2014-05-28 16:00:40 -0700
committerAaron Patterson <aaron.patterson@gmail.com>2014-05-28 16:00:40 -0700
commitac9a3a9d641a44f43796b342f76c5b342ae82de6 (patch)
treecc3e98cc77794fc63e2adcc92400c72c34d16385
parent996e9f568cba400cf82ececbc69ea797b863644b (diff)
downloadrails-ac9a3a9d641a44f43796b342f76c5b342ae82de6.tar.gz
rails-ac9a3a9d641a44f43796b342f76c5b342ae82de6.tar.bz2
rails-ac9a3a9d641a44f43796b342f76c5b342ae82de6.zip
return early if we have a valid controller name
-rw-r--r--actionpack/lib/action_dispatch/routing/mapper.rb10
1 files changed, 5 insertions, 5 deletions
diff --git a/actionpack/lib/action_dispatch/routing/mapper.rb b/actionpack/lib/action_dispatch/routing/mapper.rb
index 528bcd4189..b8aadff5e6 100644
--- a/actionpack/lib/action_dispatch/routing/mapper.rb
+++ b/actionpack/lib/action_dispatch/routing/mapper.rb
@@ -294,16 +294,16 @@ module ActionDispatch
end
return unless controller
+ return if controller =~ /\A[a-z_0-9][a-z_0-9\/]*\z/
if controller =~ %r{\A/}
- raise ArgumentError, "controller name should not start with a slash"
- end
-
- if controller !~ /\A[a-z_0-9\/]*\z/
+ message = "controller name should not start with a slash"
+ else
message = "'#{controller}' is not a supported controller name. This can lead to potential routing problems."
message << " See http://guides.rubyonrails.org/routing.html#specifying-a-controller-to-use"
- raise ArgumentError, message
end
+
+ raise ArgumentError, message
end
def blocks