aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Grammar fixes for Contributing guideJon Moss2016-06-021-7/+7
| | | | | | | | | Not sure why #25239, but it had good changes, so I'm manually pulling in the changes. [Jon Moss, Rajat Bansal] [ci skip]
* `will be` --> `is`Jon Moss2016-05-311-1/+1
| | | | [ci skip]
* Light edits to Action Cable Overview guideJon Moss2016-05-281-3/+3
| | | | [ci skip]
* `behaviour` --> `behavior`Jon Moss2016-05-272-2/+2
| | | | http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
* - :scissors: space in code to match previous defaults.Vipul A M2016-05-231-3/+1
| | | | - Grammar edits.
* Update i18n guide about how to change locale and translations paths [ci skip]Prathamesh Sonpatki2016-05-221-4/+5
| | | | | | - config/application.rb no longer has comments about how to specify load paths or change default locale after https://github.com/rails/rails/commit/28dcadc0140dfdeb.
* Small grammar fixes for Action Controller OverviewJon Moss2016-05-211-5/+6
| | | | [ci skip]
* `routes.rb` --> `config/routes.rb`Jon Moss2016-05-191-4/+4
| | | | | | For consistency. [ci skip]
* Light grammar edits to beginning of Routing guideJon Moss2016-05-181-3/+3
| | | | [ci skip]
* Add tick marks + small grammar changeJon Moss2016-05-171-2/+2
| | | | [ci skip]
* PerRequestDigestCacheExpiry middlware was been removed. Removed traces, for ↵Vipul A M2016-05-171-1/+0
| | | | | | | | the same. https://github.com/rails/rails/commit/23b6a9c0fcb8992e18450d6fe0680bf09685b7db [ci skip]
* Pass over API Apps guide grammar. [ci skip]Vipul A M2016-05-161-7/+5
|
* The `ActiveRecord::ConnectionAdapters::ConnectionManagement` and ↵Vipul A M2016-05-163-13/+3
| | | | | | | `ActiveRecord::QueryCache` middlewares were removed with `Executor` addition on d3c9d808e3e242155a44fd2a89ef272cfade8fe8 Removes traces and reference of these from all places. [ci skip]
* Change output genereated for middlewares on a new application. This has ↵Vipul A M2016-05-161-3/+3
| | | | | | changed quite a bit after Executor middleware addition. [ci skip]
* Add `ActiveRecord::Migration::CheckPending` to default middlewares for API AppsVipul A M2016-05-161-0/+1
| | | | [ci skip]
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-05-147-53/+72
|\ | | | | | | | | Conflicts: guides/source/configuring.md
| * Add output snippet from `ActionController::API.ancestors - ↵Vipul A M2016-05-131-0/+7
| | | | | | | | | | | | ActionController::Metal.ancestors` command for api apps. [ci skip]
| * Remove ambiquity in what we are referring to in the documentation of config ↵Vipul A M2016-05-111-1/+1
| | | | | | | | vs configuring the server itself
| * Document config.action_dispatch.ignore_accept_header and ↵Vipul A M2016-05-111-0/+4
| | | | | | | | config.action_dispatch.x_sendfile_header in configuring guide
| * More missing true literal quotingsVipul A M2016-05-111-12/+12
| |
| * Lets be consistent in the usage of true/false across this guide. It should ↵Vipul A M2016-05-111-26/+26
| | | | | | | | be quoted as how other config options are. They are already quoted at many places. This change, makes this usage consistent. Note that, this is quoting literal values true and false, not truthy values
| * Document missing smtp config over at configuring guide. [ci skip]Vipul A M2016-05-111-0/+3
| |
| * This config still applies for Rails 4 Apps and we need to mention it, what ↵Vipul A M2016-05-111-2/+2
| | | | | | | | was needed before. [ci skip]
| * Asset Pipeline: Remove outdated comment about `config.assets.digest` [ci skip]Prathamesh Sonpatki2016-05-081-1/+1
| |
| * Asset pipeline: Remove documentation about outdated `config.assets.compress` ↵Prathamesh Sonpatki2016-05-082-14/+7
| | | | | | | | | | | | option [ci skip]
| * s/words_connnector/words_connector/Vipul A M2016-05-031-1/+1
| | | | | | | | [ci skip]
| * Fix code formatting in docsJay Hayes2016-05-031-2/+2
| |
| * Add example for UnknownAttributeErrorVipul A M2016-05-021-0/+9
| | | | | | | | [ci skip]
| * Active Model: Messages for strict validation always convert attributes to ↵Prathamesh Sonpatki2016-05-011-2/+2
| | | | | | | | human readable form [ci skip]
| * Move comment up to the class, for both of the methods, and document on class ↵Vipul A M2016-05-011-1/+4
| | | | | | | | | | | | level why we are doing this. [ci skip]
* | Merge pull request #25008 from lvl0nax/as_enumarable_index_by_refactoringRafael França2016-05-141-1/+3
|\ \ | | | | | | Perfomance fix for ActiveSupport Enumerable#index_by
| * | Perfomance fix for Enumerable#index_bylvl0nax2016-05-141-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calculating ------------------------------------- before 34.731k i/100ms after 48.206k i/100ms ------------------------------------------------- before 508.451k (± 1.2%) i/s - 2.570M after 720.068k (± 0.9%) i/s - 3.615M Comparison: after: 720067.6 i/s before: 508451.1 i/s - 1.42x slower
* | | Merge pull request #25003 from kangkyu/missing_lineRafael França2016-05-141-3/+3
|\ \ \ | |/ / |/| | Add missing space and newline for clarity
| * | Add missing space and newline for clarityKang-Kyu Lee2016-05-121-3/+3
| | |
* | | Merge pull request #25015 from joemasilotti/patch-1Eileen M. Uchitelle2016-05-131-0/+4
|\ \ \ | |/ / |/| | Add notes on cosmetic patches to contributing guidelines
| * | Add notes on cosmetic patchesJoe Masilotti2016-05-131-0/+4
|/ /
* | Give more context from `AssociationMismatchError`Sean Griffin2016-05-122-2/+3
| | | | | | | | | | | | | | The error message that we give today makes this error difficult to debug if you receive it. I have no clue why we're printing the object ID of the class (the commit doesn't give context), but I've left it as it was deliberate.
* | Merge pull request #25001 from Neodelf/typosRichard Schneeman2016-05-121-1/+1
|\ \ | | | | | | Rename test method
| * | Rename test methodMolchanov Andrey2016-05-121-1/+1
|/ /
* | Fix false positive mutation detection when JSON is used with serializeSean Griffin2016-05-122-1/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | When looking for mutation, we compare the serialized version of the value to the before_type_cast form. `Type::Serialized` was breaking this contract by passing the already serialized attribute to the subtype's mutation detection. This never manifested previously, as all mutable subtypes either didn't do anything in their `serialize` method, or had a way to detect double serialization (e.g. `is_a?(String)`). However, now that JSON types can handle string primitives, we need to avoid double serialization. Fixes #24993.
* | Publish Action Cable to NPM when we release.Jon Moss2016-05-114-8/+75
| | | | | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Merge pull request #24980 from merhard/virtual-attribute-defaultSean Griffin2016-05-112-1/+10
|\ \ | | | | | | Define ActiveRecord::Attribute::Null#type_cast
| * | Define ActiveRecord::Attribute::Null#type_castMatthew Erhard2016-05-112-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using ActiveRecord::Base.attribute to declare an attribute with a default value on a model where the attribute is not backed by the database would raise a NotImplementedError when model.save is called. The error originates from https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L84. This is called from https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L46 on an ActiveRecord::Attribute::Null object. This commit corrects the behavior by implementing ActiveRecord::Attribute::Null#type_cast. With ActiveRecord::Attribute::Null#type_cast defined, ActiveRecord::Attribute::Null#value (https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L173..L175) can be replaced with its super method (https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L36..L40). fixes #24979
* | | Merge pull request #24982 from tomkadwill/improve_clarity_of_raw_host_with_portKasper Timm Hansen2016-05-112-3/+30
|\ \ \ | | | | | | | | Improve documentation and tests for raw_host_with_port and host_with_…
| * | | Improve documentation and tests for raw_host_with_port and host_with_portTom Kadwill2016-05-112-3/+30
| | | |
* | | | remove_connection should not remove parent connectionArthur Neves2016-05-112-1/+9
| |/ / |/| | | | | | | | | | | | | | When calling remove_connection in a subclass, that should not fallback to the parent, otherwise it will remove the parent connection from the handler.
* | | Merge pull request #24977 from fgo/patch-19Arthur Nogueira Neves2016-05-111-0/+1
|\ \ \ | | | | | | | | Getting Started Guide: Add invoke test_unit to files table [ci skip]
| * | | Getting Started Guide: Add invoke test_unit to files table [ci skip]Francis Go2016-05-121-0/+1
|/ / /
* | | Merge pull request #24974 from mohitnatoo/arrayinquirer-any-definitionVipul A M2016-05-111-2/+4
|\ \ \ | | | | | | | | Added clarity to documentation of ArrayInquirer#any? [ci skip]
| * | | - Added clarity to documentation of ArrayInquirer#any? [ci skip]Mohit Natoo2016-05-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | - Added clarity to documentation of ArrayInquirer#any? [ci skip] - Added clarity to documentation of ArrayInquirer#any? [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-04 19:37:04 +0000