diff options
| author | Eileen M. Uchitelle <eileencodes@gmail.com> | 2016-05-13 15:12:48 -0400 |
|---|---|---|
| committer | Eileen M. Uchitelle <eileencodes@gmail.com> | 2016-05-13 15:12:48 -0400 |
| commit | b6429b871ff8b73ebd10076ead6ed2c1f651da86 (patch) | |
| tree | 4309bd001c6ff780f9c508c91617ff185746168f | |
| parent | 0991c4c6fc0c04764f34c6b65a42adce190440c3 (diff) | |
| parent | 6143de0b927089f48b58fa6a8c924e658c9373fc (diff) | |
| download | rails-b6429b871ff8b73ebd10076ead6ed2c1f651da86.tar.gz rails-b6429b871ff8b73ebd10076ead6ed2c1f651da86.tar.bz2 rails-b6429b871ff8b73ebd10076ead6ed2c1f651da86.zip | |
Merge pull request #25015 from joemasilotti/patch-1
Add notes on cosmetic patches to contributing guidelines
| -rw-r--r-- | CONTRIBUTING.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 961b48733c..f6ebef7e89 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,6 +21,10 @@ * Before submitting, please read the [Contributing to Ruby on Rails](http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html) guide to know more about coding conventions and benchmarks. +#### **Did you fix whitespace, format code, or make a purely cosmetic patch?** + +Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted (read more about [our rationales behind this decision](https://github.com/rails/rails/pull/13771#issuecomment-32746700)). + #### **Do you intend to add a new feature or change an existing one?** * Suggest your change in the [rubyonrails-core mailing list](https://groups.google.com/forum/?fromgroups#!forum/rubyonrails-core) and start writing code. |