aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Change the default test order from `:sorted` to `:random`Rafael Mendonça França2015-01-043-30/+18
| | |
| * | Remove deprecated ActiveSupport::JSON::Encoding::CircularReferenceError.Rafael Mendonça França2015-01-043-46/+4
| | |
| * | Remove deprecated ActiveSupport::JSON::Encoding.encode_big_decimal_as_string=Rafael Mendonça França2015-01-043-43/+5
| | |
| * | Remove deprecated `ActiveSupport::SafeBuffer#prepend`Rafael Mendonça França2015-01-043-16/+4
| | |
| * | Remove deprecated methods at `Kernel`.Rafael Mendonça França2015-01-047-128/+49
| | | | | | | | | | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`.
| * | Remove deprecated core_ext/big_decimal/yaml_conversions fileRafael Mendonça França2015-01-043-25/+5
| | |
| * | Remove deprecated ActiveSupport::Cache::Store.instrumentRafael Mendonça França2015-01-042-14/+5
|/ /
* | Merge pull request #18324 from ↵Vijay Dev2015-01-042-2/+2
|\ \ | |/ |/| | | | | prathamesh-sonpatki/rails-version-in-bug-templates Update bug report templates to use version 4.2.0 instead of 5.0.0
| * Update bug report templates to use version 4.2.0 instead of 5.0.0 [ci skip]Prathamesh Sonpatki2015-01-042-2/+2
|/ | | | | | | | - Right now master is 5.0.0. Latest gem release is 4.2.0 for which we are accepting bug reports. So lets use it in bug report templates. - 5.0.0 is not installable as it's not available on Rubygems yet. So the gem bug templates are not usable without editing the version. Using 4.2.0 will make them usable again.
* Merge pull request #18319 from kamipo/sql_type_has_been_determinedRafael Mendonça França2015-01-041-4/+2
|\ | | | | `sql_type` has been determined already when quoting defaults
| * `sql_type` has been determined already when quoting defaultsRyuta Kamizono2015-01-041-4/+2
| | | | | | | | No need to call `type_to_sql` again.
* | Merge pull request #18318 from ↵Rafael Mendonça França2015-01-041-1/+2
|\ \ | | | | | | | | | | | | kamipo/stop_passing_the_column_when_quoting_defaults Stop passing the column to the `quote` method when quoting defaults
| * | Stop passing the column to the `quote` method when quoting defaultsRyuta Kamizono2015-01-041-1/+2
| |/ | | | | | | Related the commit 8f8f8058e58dda20259c1caa61ec92542573643d.
* | Merge pull request #18283 from kamipo/refactor_postgresql_columnRafael Mendonça França2015-01-0318-30/+29
|\ \ | | | | | | Prefer `array?` rather than `array`
| * | Prefer `array?` rather than `array`Ryuta Kamizono2015-01-0418-30/+29
| |/ | | | | | | | | | | Slightly refactoring `PostgreSQLColumn`. `array` should be readonly. `default_function` should be initialized by `super`. `sql_type` has been removed `[]`. Since we already choose to remove it we should not change.
* | Improve the matches on the scaffold generator testsCarlos Antonio da Silva2015-01-031-9/+8
| | | | | | | | Related to #13434.
* | Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-035-6/+21
|\ \ | |/ |/| | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-265-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-0333-81/+507
|\ \ | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | Add config to halt callback chain on return falseclaudiob2015-01-0212-19/+191
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
| * | Deprecate `false` as the way to halt AR callbacksclaudiob2015-01-0215-47/+191
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, returning `false` in an ActiveRecord `before_` callback such as `before_create` would halt the callback chain. After this commit, the behavior is deprecated: will still work until the next release of Rails but will also display a deprecation warning. The preferred way to halt a callback chain is to explicitly `throw(:abort)`.
| * | Deprecate `false` as the way to halt AM callbacksclaudiob2015-01-023-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, returning `false` in an ActiveModel `before_` callback such as `before_create` would halt the callback chain. After this commit, the behavior is deprecated: will still work until the next release of Rails but will also display a deprecation warning. The preferred way to halt a callback chain is to explicitly `throw(:abort)`.
| * | Deprecate `false` as the way to halt AM validation callbacksclaudiob2015-01-023-6/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, returning `false` in an ActiveModel validation callback such as `before_validation` would halt the callback chain. After this commit, the behavior is deprecated: will still work until the next release of Rails but will also display a deprecation warning. The preferred way to halt a callback chain is to explicitly `throw(:abort)`.
| * | Deprecate `false` as the way to halt AS callbacksclaudiob2015-01-024-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this commit, returning `false` in a callback will display a deprecation warning to make developers aware of the fact that they need to explicitly `throw(:abort)` if their intention is to halt a callback chain. This commit also patches two internal uses of AS::Callbacks (inside ActiveRecord and ActionDispatch) which sometimes return `false` but whose returned value is not meaningful for the purpose of execution. In both cases, the returned value is set to `true`, which does not affect the execution of the callbacks but prevents unrequested deprecation warnings from showing up.
| * | Throw :abort halts default CallbackChainsclaudiob2015-01-027-14/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes arguments and default value of CallbackChain's :terminator option. After this commit, Chains of callbacks defined **without** an explicit `:terminator` option will be halted as soon as a `before_` callback throws `:abort`. Chains of callbacks defined **with** a `:terminator` option will maintain their existing behavior of halting as soon as a `before_` callback matches the terminator's expectation. For instance, ActiveModel's callbacks will still halt the chain when a `before_` callback returns `false`.
| * | Loosen test about order of initializersclaudiob2015-01-021-10/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit modifies the code (but not the purpose) of a test that checks that > initializers are executed after application configuration initializers Currently the test hard-codes the *exact* initializers that are expected to occur before a custom one. This can cause the test to fail even if the expectation still passes. This commit loosens the test by simply checking that, in the array of initializers, the custom initializers (called `dummy_initializer` in the example) is executed after the last occurrence of `load_config_initializers`.
* | | Remove some warningsRafael Mendonça França2015-01-031-32/+32
| | |
* | | Merge pull request #18314 from robin850/rm-tmp-sessionsRafael Mendonça França2015-01-035-27/+17
|\ \ \ | | | | | | | | Remove the tmp/sessions folder and its clear task
| * | | Remove the tmp/sessions folder and its clear taskRobin Dupret2015-01-035-27/+17
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 1aea470 introduced this directory but this was at a time when the default way to store sessions was on the file system under the tmp directory. Let's remove references to it from the documentation as well. [Robin Dupret & yui-knk]
* | | Fix a few typos [ci skip]Robin Dupret2015-01-034-5/+5
| | |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-0317-40/+74
|\ \ \
| * | | Use Active Model, not ActiveModel in plain Englishclaudiob2015-01-028-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also prevents the word "Model" from linking to the documentation of ActiveModel::Model because that's not intended. [ci skip]
| * | | [ci skip] :scissors: a blank line from code (Active Job Guide).Juanito Fatas2015-01-021-1/+0
| | | |
| * | | Fix doc formatting for `count_by_sql`claudiob2015-01-011-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ![before](https://cloud.githubusercontent.com/assets/10076/5592809/25ce08e8-9199-11e4-9dfe-5baa8bd6b658.png) After: ![after](https://cloud.githubusercontent.com/assets/10076/5592810/25ceef9c-9199-11e4-88f4-d286203d7f6f.png) [ci skip]
| * | | Fix "Rendering" not to link to AV::Renderingclaudiob2014-12-251-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The "Rendering" word in the titles is not meant to be a link to the documentation for ActionView::Rendering. [ci skip]
| * | | Better docs for NameErrorclaudiob2014-12-251-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | Add examples for missing_name, missing_name? [ci skip]
| * | | Better docs for AbstractControllerclaudiob2014-12-223-18/+24
| | | | | | | | | | | | | | | | | | | | | | | | Fixes internal links, adds examples and set fixed-width fonts. [ci skip]
| * | | Add docs for `Rails.env` and `Rails.env=`claudiob2014-12-221-0/+8
| | | | | | | | | | | | | | | | [ci skip]
| * | | Add docs for `Object.nil!`claudiob2014-12-221-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | Also add doc examples for `Object.nil`. [ci skip]
* | | | Merge pull request #18310 from robin850/guides-improvementsXavier Noria2015-01-036-7/+15
|\ \ \ \ | | | | | | | | | | Some guides improvements
| * | | | Avoid displaying new lines inside note paragraphsRobin Dupret2015-01-033-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 65a2977 added a `pre-wrap` style for white spaces on `.note` paragraphs. However, this is first inconsistent as other notes like warnings don't have this style applied. Furthermore, it seems to be unneeded for mobile devices. Also revert changes made in #18147 since they aren't needed anymore. Cross-refs #18138. [ci skip]
| * | | | Consider `html+erb` as a valid language for snippetsRobin Dupret2015-01-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To highlight ERB snippets, both `erb` and `html+erb` are used as a language passed to the code block. However, only the former will be correctly highlighted.
| * | | | Update Redcarpet to version 3.2.2Robin Dupret2015-01-032-3/+3
|/ / / /
* | | | Merge pull request #18309 from PaBLoX-CL/fix-fixtures-referencesRafael Mendonça França2015-01-023-5/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Generated fixtures won't use parent_id when generated with parent:references
| * | | | Generated fixtures won't use parent_id when generated with parent:referencesPablo Olmos de Aguilera Corradini2015-01-022-5/+7
|/ / / / | | | | | | | | | | | | Fix #18301
* | | | Merge pull request #10380 from JonRowe/test_all_domain_2_letter_tldRafael Mendonça França2015-01-021-0/+7
|\ \ \ \ | | | | | | | | | | | | | | | Assert that 2 letter tlds with 3 letter domain names work when option specified.
| * | | | add test asserting that 2 letter tlds with 3 letter domain names work when ↵Jon Rowe2013-04-301-0/+7
| | | | | | | | | | | | | | | | | | | | option specified
* | | | | Merge pull request #18307 from brainopia/datetime_regressionRafael Mendonça França2015-01-022-1/+13
|\ \ \ \ \ | | | | | | | | | | | | Fully support datetime values in AR::Type::DateTime#type_cast_for_database
| * | | | | Support datetime values in AR::Type::DateTime#type_cast_for_databasebrainopia2015-01-032-1/+13
| | | | | |
* | | | | | Merge pull request #18308 from jcoyne/i18n_translate_safetyRafael Mendonça França2015-01-023-19/+20
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Unsafe default translations should not be marked html_safe
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-05 22:57:18 +0000