aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXavier Noria <fxn@hashref.com>2015-01-03 13:53:17 +0100
committerXavier Noria <fxn@hashref.com>2015-01-03 13:53:17 +0100
commit02e72a49d1c99084fef2c78c3a194e03b879099d (patch)
treed53a2adb5e7e8274dc8a81a3f3e56539be7e9ada
parenta699f5d3e18e87e802bc460b6e4d2b6fd4921884 (diff)
parentd0703280c7c4a3d958fe5c5743def7808383ad75 (diff)
downloadrails-02e72a49d1c99084fef2c78c3a194e03b879099d.tar.gz
rails-02e72a49d1c99084fef2c78c3a194e03b879099d.tar.bz2
rails-02e72a49d1c99084fef2c78c3a194e03b879099d.zip
Merge pull request #18310 from robin850/guides-improvements
Some guides improvements
-rw-r--r--Gemfile2
-rw-r--r--guides/assets/stylesheets/main.css2
-rw-r--r--guides/rails_guides.rb4
-rw-r--r--guides/rails_guides/markdown/renderer.rb2
-rw-r--r--guides/source/active_record_querying.md3
-rw-r--r--guides/source/security.md9
6 files changed, 15 insertions, 7 deletions
diff --git a/Gemfile b/Gemfile
index ae68fba421..821a7b914e 100644
--- a/Gemfile
+++ b/Gemfile
@@ -27,7 +27,7 @@ gem 'uglifier', '>= 1.3.0', require: false
group :doc do
gem 'sdoc', '~> 0.4.0'
- gem 'redcarpet', '~> 3.1.2', platforms: :ruby
+ gem 'redcarpet', '~> 3.2.2', platforms: :ruby
gem 'w3c_validators'
gem 'kindlerb'
end
diff --git a/guides/assets/stylesheets/main.css b/guides/assets/stylesheets/main.css
index 318a1ef1c7..ed558e4793 100644
--- a/guides/assets/stylesheets/main.css
+++ b/guides/assets/stylesheets/main.css
@@ -34,7 +34,7 @@ pre, code {
overflow: auto;
color: #222;
}
-pre,tt,code,.note>p {
+pre, tt, code {
white-space: pre-wrap; /* css-3 */
white-space: -moz-pre-wrap !important; /* Mozilla, since 1999 */
white-space: -pre-wrap; /* Opera 4-6 */
diff --git a/guides/rails_guides.rb b/guides/rails_guides.rb
index 9d1d5567f6..762ab1c0e2 100644
--- a/guides/rails_guides.rb
+++ b/guides/rails_guides.rb
@@ -24,11 +24,11 @@ begin
require 'redcarpet'
rescue LoadError
# This can happen if doc:guides is executed in an application.
- $stderr.puts('Generating guides requires Redcarpet 3.1.2+.')
+ $stderr.puts('Generating guides requires Redcarpet 3.2.2+.')
$stderr.puts(<<ERROR) if bundler?
Please add
- gem 'redcarpet', '~> 3.1.2'
+ gem 'redcarpet', '~> 3.2.2'
to the Gemfile, run
diff --git a/guides/rails_guides/markdown/renderer.rb b/guides/rails_guides/markdown/renderer.rb
index c1968af64a..50a791cda5 100644
--- a/guides/rails_guides/markdown/renderer.rb
+++ b/guides/rails_guides/markdown/renderer.rb
@@ -48,7 +48,7 @@ HTML
case code_type
when 'ruby', 'sql', 'plain'
code_type
- when 'erb'
+ when 'erb', 'html+erb'
'ruby; html-script: true'
when 'html'
'xml' # HTML is understood, but there are .xml rules in the CSS
diff --git a/guides/source/active_record_querying.md b/guides/source/active_record_querying.md
index e0a9add2be..6cfb6c5ca5 100644
--- a/guides/source/active_record_querying.md
+++ b/guides/source/active_record_querying.md
@@ -1384,7 +1384,8 @@ WHERE people.name = 'John'
LIMIT 1
```
-NOTE: Remember that, if `find_by` returns more than one registry, it will take just the first and ignore the others. Note the `LIMIT 1` statement above.
+NOTE: Remember that, if `find_by` returns more than one registry, it will take
+just the first and ignore the others. Note the `LIMIT 1` statement above.
Find or Build a New Object
--------------------------
diff --git a/guides/source/security.md b/guides/source/security.md
index 4a80edbdad..e4cc79df55 100644
--- a/guides/source/security.md
+++ b/guides/source/security.md
@@ -249,7 +249,14 @@ protect_from_forgery with: :exception
This will automatically include a security token in all forms and Ajax requests generated by Rails. If the security token doesn't match what was expected, an exception will be thrown.
-NOTE: By default, Rails includes jQuery and an [unobtrusive scripting adapter for jQuery](https://github.com/rails/jquery-ujs), which adds a header called `X-CSRF-Token` on every non-GET Ajax call made by jQuery with the security token. Without this header, non-GET Ajax requests won't be accepted by Rails. When using another library to make Ajax calls, it is necessary to add the security token as a default header for Ajax calls in your library. To get the token, have a look at `<meta name='csrf-token' content='THE-TOKEN'>` tag printed by `<%= csrf_meta_tags %>` in your application view.
+NOTE: By default, Rails includes jQuery and an [unobtrusive scripting adapter for
+jQuery](https://github.com/rails/jquery-ujs), which adds a header called
+`X-CSRF-Token` on every non-GET Ajax call made by jQuery with the security token.
+Without this header, non-GET Ajax requests won't be accepted by Rails. When using
+another library to make Ajax calls, it is necessary to add the security token as
+a default header for Ajax calls in your library. To get the token, have a look at
+`<meta name='csrf-token' content='THE-TOKEN'>` tag printed by
+`<%= csrf_meta_tags %>` in your application view.
It is common to use persistent cookies to store user information, with `cookies.permanent` for example. In this case, the cookies will not be cleared and the out of the box CSRF protection will not be effective. If you are using a different cookie store than the session for this information, you must handle what to do with it yourself: