| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
morgoth/fix-automatic-maintaining-test-schema-for-sql-format
ActiveRecord::Migration.maintain_test_schema! doesn't work with structure.sql
Conflicts:
activerecord/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
schema format.
Additionally:
* It changes `purge` task on `sqlite3` adapter to recreate database file, to
be consistent with other adapters.
* Adds `purge` step when loading from `schema.rb`
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
zuhao/refactor_actionview_register_template_handler
Add unregister_template_handler to prevent leaks.
Conflicts:
actionview/CHANGELOG.md
|
| | | |
|
|\ \ \
| | | |
| | | | |
Removed variable shawdowing warning in actionpack url.rb
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before:
/Users/Juan/dev/rails/actionpack/lib/action_dispatch/http/url.rb:95: warning: shadowing outer local variable - port
After:
No warning
|
|\ \ \
| | | |
| | | | |
Remove unused require
|
| | | |
| | | |
| | | |
| | | | |
We're not longer using `ipaddr` in schema dumper
|
|\ \ \ \
| | | | |
| | | | | |
remove unnused method from test
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] There are 3 caveats to Local Precompilation including 1 config change
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
not 2 caveats with one of them being 2 config changes [ci skip]
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
[ci skip] Updating argument names in default matcher for compiling files
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
to match arguments used in sprockets-rails [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
extract_subdomain always returns a string, and to_param calls to_s on a
string
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
irb(main):004:0> /foo/ !~ nil
=> true
irb(main):005:0> /foo/ !~ 'bar'
=> true
irb(main):006:0> /foo/ !~ 'foo'
=> false
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
remove the default parameter since the methods are always called with a
parameter
|
|\ \ \ \
| | | | |
| | | | | |
Pluck should work with columns of the same name from different tables
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The column name given by the adapter doesn't include the table
namespace, so going through the hashed version of the result set causes
overridden keys.
Fixes #15649
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 79469b4b0c05a50e19699bc9b568042add2d4987.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
require `to_param`"
Revert "No need to require to_param, it is already required in to_query.rb"
This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561
and d697ee14264a90a39cdbe87857656d8b314ac9b7.
Reason by @jeremy: These requires are not for implementation dependency.
They ensure that requiring array conversions provides to_query, to_param,
and other array conversion behaviors.
The fact that to_query is implemented in terms of to_param is just a
coincidence. If to_query removed its to_param require, then someone
requiring array conversions would no longer have to_param available.
This change removes these intentional dependencies on to_param in favor
of implementation side effects—an undesirable move that's susceptible to
regression.
|
|\ \ \ \
| | | | |
| | | | | |
remove unnecssary require of `to_param`, as `to_query` is already require `to_param`
|
| | | | |
| | | | |
| | | | |
| | | | | |
`to_param`
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
remove warnings
|
| | | | |
| | | | |
| | | | |
| | | | | |
warning: assigned but unused variable - scope_called, path and strexp
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |/ / /
|/| | | |
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip] correct docs for conversion
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
No need to require to_param, it is already required in object/to_query.rb
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] add test for ActionModel::Conversion
|
|/ / / / |
|
|\| | |
| | | |
| | | | |
Move tests for blank.rb under Object
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Refactor determination of max updated timestamp
|
| | | |
| | | |
| | | |
| | | | |
`[].max # => nil`
|
|\ \ \ \
| | | | |
| | | | | |
begin refactoring add_constraints by moving join keys
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
add_constraints is complicated and difficult to read. This is the
beginning of a long process of refactoring this code. First step:
moved the join keys out of AssociationScope and into reflection.
We then don't need to call `reflection` because now reflection is
`self`.
`foreign_key` must be named something else because reflection already has a
`foreign_key` method and when passed into `JoinKeys` it was getting the
wrong assignment. `reflection_foreign_key` seemed to be an appropriate name.
I also named `key` `reflection_key` to match `reflection_foreign_key`.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
rm cached attributes
|