aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | add line break between method of generated channel jsyuuji.yaginuma2015-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` ``` # after App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ```
* | | | | | | | Merge pull request #22665 from akshay-vishnoi/base_test_caseRafael França2015-12-181-0/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ActionCable] Test available actions on Channel
| * | | | | | | | [ActionCable] Test available actions on ChannelAkshay Vishnoi2015-12-181-0/+4
| | | | | | | | |
* | | | | | | | | Do not check the version anymoreRafael Mendonça França2015-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our logic is complex now and we don't need to check the version to asset the behavior so I'm removing the checking here.
* | | | | | | | | Merge pull request #22657 from matthewd/loosen-versionRafael Mendonça França2015-12-184-3/+32
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | Allow normal version updates within a release series
| * | | | | | | | Allow normal version updates within a release seriesMatthew Draper2015-12-184-3/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We originally chose to apply very strict versioning on the `rails` entry in the Gemfile, because our future versioning policy was not strongly defined. Now it is, and our policy is very much designed on the expectation that people will regularly update to the latest patch level in their release series... so we should encourage that. Of course, Gemfile.lock will do its job and prevent unplanned updates, just as it does for every other gem in the bundle... but if you run `bundle update`, we want to get you the latest bug/security fixes without requiring a manual edit of the Gemfile entry. Our current version could be a few different shapes, so it takes a bit of work to find the right specifier, but in principle, we match anything of the form x.y.*, where x.y matches our current release series.
* | | | | | | | | Same gemspec formats everywhereDavid Heinemeier Hansson2015-12-182-2/+2
| | | | | | | | |
* | | | | | | | | Stray lineDavid Heinemeier Hansson2015-12-181-1/+2
| | | | | | | | |
* | | | | | | | | SimplifyDavid Heinemeier Hansson2015-12-181-9/+2
| | | | | | | | |
* | | | | | | | | Now available in action_cableDavid Heinemeier Hansson2015-12-181-2/+2
| | | | | | | | |
* | | | | | | | | Refer to rails command instead of rake in a bunch of placesDavid Heinemeier Hansson2015-12-1816-40/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still more to do. Please assist!
* | | | | | | | | Explain reason for eager loadingDavid Heinemeier Hansson2015-12-181-0/+1
| | | | | | | | |
* | | | | | | | | Explain Redis' role in Action CableDavid Heinemeier Hansson2015-12-181-0/+1
| | | | | | | | |
* | | | | | | | | [ci skip] Revert most of ff851017Kasper Timm Hansen2015-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | We went back to `Thread.current[]` in 33e11e59.
* | | | | | | | | Merge pull request #22656 from akshay-vishnoi/fix-typosKasper Timm Hansen2015-12-183-5/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [ci skip] Fix grammar
| * | | | | | | | | [ci skip] Fix grammarAkshay Vishnoi2015-12-183-5/+5
| | | | | | | | | |
* | | | | | | | | | Bring comment in line with rest of initializersDavid Heinemeier Hansson2015-12-181-2/+2
| | | | | | | | | |
* | | | | | | | | | Explain the concept of config initializers for backwards compatibilityDavid Heinemeier Hansson2015-12-183-2/+5
| | | | | | | | | |
* | | | | | | | | | Fix spacingDavid Heinemeier Hansson2015-12-181-1/+1
| | | | | | | | | |
* | | | | | | | | | These options are not changed nearly often enough to warrant inclusion like ↵David Heinemeier Hansson2015-12-181-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this at a high level
* | | | | | | | | | Better explanationDavid Heinemeier Hansson2015-12-181-2/+6
| | | | | | | | | |
* | | | | | | | | | Use the rails command, not rake, for all rails commandsDavid Heinemeier Hansson2015-12-182-6/+6
| | | | | | | | | |
* | | | | | | | | | README.md in the app is now used to describe the app itself, not RailsDavid Heinemeier Hansson2015-12-181-1/+0
| | | | | | | | | |
* | | | | | | | | | More sensible ordering with the more important options firstDavid Heinemeier Hansson2015-12-181-12/+12
| | | | | | | | | |
* | | | | | | | | | List the major frameworks you can remove togetherDavid Heinemeier Hansson2015-12-181-3/+3
| | | | | | | | | |
* | | | | | | | | | Revert "Use Thread.current.thread_variable_set/get insetad of the direct ↵David Heinemeier Hansson2015-12-181-4/+4
| |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | accessors" This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
* | | | | | | | | Merge pull request #22659 from y-yagi/fix_indent_in_controller_testKasper Timm Hansen2015-12-182-3/+3
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / |/| | | | | | | | fix indentation of generated controller test
| * | | | | | | | fix indentation of generated controller testyuuji.yaginuma2015-12-182-3/+3
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before module Bukkits class UsersControllerTest < ActionDispatch::IntegrationTest include Engine.routes.url_helpers setup do @user = bukkits_users(:one) end ``` ``` # after module Bukkits class UsersControllerTest < ActionDispatch::IntegrationTest include Engine.routes.url_helpers setup do @user = bukkits_users(:one) end ```
* / / / / / / / Ignore Byebug command history fileAkira Matsuda2015-12-181-0/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This file is generated by a gem that is bundled by default in the generated Rails app, just like .sqlite3 files. Hence it might be natural to be ignored here rather than in each developer's .gitignore_global.
* | | | | | | Use released rackRafael Mendonça França2015-12-183-14/+3
| | | | | | |
* | | | | | | Merge pull request #22649 from derekprior/dp-redirect-back-docsKasper Timm Hansen2015-12-181-2/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Document when fallback_location is used [ci-skip]
| * | | | | | | Document when fallback_location is used [ci-skip]Derek Prior2015-12-171-2/+8
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you're not familiar with how the `Referer` header works, you likely won't understand why you need to provide a fallback or under what circumstances it would be used. Hopefully this clarifies things a bit.
* | | | | | | Merge pull request #22655 from akshay-vishnoi/fix-typosRafael França2015-12-181-1/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Fix typo
| * | | | | | [ci skip] Fix typoAkshay Vishnoi2015-12-181-1/+1
|/ / / / / /
* | | | | | Install jquery-railsRafael Mendonça França2015-12-182-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It will make sure that the generated application in the tests get the gem.
* | | | | | Merge pull request #22653 from matthewd/find_array_orderedMatthew Draper2015-12-184-2/+100
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base#find(array) returning result in the same order as the array passed
| * | | | | | Implement limit & offset for ourselvesMatthew Draper2015-12-182-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We know the query will return exactly one row for each entry in the `ids` array, so we can do all the limit/offset calculations on that array, in advance. I also split our new ordered-ids behaviour out of the existing `find_some` method: especially with this change, the conditionals were overwhelming the actual logic.
| * | | | | | Adding a new test using chained where, limit and find([pks])Miguel Grazziotin2015-08-071-2/+12
| | | | | | |
| * | | | | | using order_values method instead of relying on ActiveRecord::Relation ↵Miguel Grazziotin2015-06-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | @values hash
| * | | | | | WIP: fixing the limit bug and introducing new tests (failing for now) on ↵Miguel Grazziotin2015-06-192-7/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | .find(array) with offset
| * | | | | | do not change the order of the result if the object was already ordered by ↵Miguel Grazziotin2015-06-052-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | the user via :order clause
| * | | | | | adding a test to ensure the find is obbeying the limitMiguel Grazziotin2015-06-031-0/+7
| | | | | | |
| * | | | | | [#20338] adding tests to ensure the order clause takes precedenceMiguel Grazziotin2015-06-031-0/+18
| | | | | | |
| * | | | | | [#20338] improving implementation, fixing and adding some more specsMiguel Grazziotin2015-06-032-6/+4
| | | | | | |
| * | | | | | [#20338] WIP: first basic implementation and specsMiguel Grazziotin2015-05-292-1/+17
| | | | | | |
* | | | | | | These limits are now implicitMatthew Draper2015-12-182-2/+2
| | | | | | |
* | | | | | | Merge pull request #20815 from ↵Matthew Draper2015-12-183-3/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | byroot/do-not-include-column-limit-if-it-is-default Do not include column limit in schema.rb if it matches the default
| * | | | | | | Do not include column limit in schema.rb if it matches the defaultJean Boussier2015-07-082-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working on engines that supports multiple databases, it's very annoying to have a different schema.rb output based on which database you use. MySQL being the primary offender. This patch should reduce the disparities a bit.
* | | | | | | | Merge pull request #21914 from zachalewel/zachalewel-patch-1Matthew Draper2015-12-181-8/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Update CHANGELOG.md for readability
| * | | | | | | | Update CHANGELOG.mdZach Alewel2015-10-081-1/+1
| | | | | | | | |