| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Use appropriate assertion based on expectation
|
|/
|
|
|
|
|
| |
This resolves a stern Minitest “warning” about an upcoming
behavior change in MiniTest 6 that will result in the test failing.
https://github.com/seattlerb/minitest/issues/666
|
|
|
|
| |
We don't want to leak the extra migration path to other railties tests.
|
|
|
|
| |
We don't want to leak the extra migration path to other railties tests.
|
|\
| |
| | |
Generate migrations at path set by `config.paths["db/migrate"]`
|
| | |
|
|\ \
| | |
| | | |
Remove meaningless line from adapter_test.rb
|
| | | |
|
|\ \ \
| | | |
| | | | |
SQLite: Foreign Key Support
|
| | | |
| | | |
| | | |
| | | | |
https://www.sqlite.org/foreignkeys.html
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
statement
If an adapter does not support foreign key feature, should be noop.
https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/foreign_key_test.rb#L288-L294
https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/references_foreign_key_test.rb#L208-L214
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
that as a dependency for assets:precompile
|
| | | |
| | | |
| | | |
| | | | |
we call them only in the tests
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Raise ArgumentError if attempting to transliterate nil
|
| | | |
| | | |
| | | |
| | | | |
than a string
|
| | |/
| |/| |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
Translate Foreign Key violation to the specific exception for SQLite3 adapter
|
| | |
| | |
| | |
| | |
| | |
| | | |
Raise `ActiveRecord::InvalidForeignKey` when a record cannot be inserted
or updated because it references a non-existent record for SQLite3
adapter.
|
|\ \ \
| | | |
| | | | |
make `render` work with AC::Params
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In 4.2, since AC::Params inherited `Hash`, processing in the case of
`Hash` was done. But in 5.x, since AC::Params does not inherit `Hash`,
need to add care for AC::Params.
Related to 00285e7cf75c96553719072a27c27e4ab7d25b40
|
|\ \ \ \
| | | | |
| | | | | |
Allow SQLServerAdapter To Opt Into A Few Tests
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |/ / /
|/| | | |
Update comment for Scrubber usage [ci skip]
|
| | |/
| |/| |
|
| | |
| | |
| | |
| | | |
the speed-up from 26dd9b26ab7317f94fd285245879e888344143b2 (cc: @fxn)
|
| | |
| | |
| | |
| | | |
[26dd9b26ab7317f94fd285245879e888344143b2] as it broke Parameters#to_h on at least fields_for-style nested params.
|
|/ /
| |
| |
| | |
This was preventing the test suite from being run in isolation
|
| | |
|
|\ \
| | |
| | | |
Add test for update_counters with empty touch array
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
This is a regression test for a fix included in
https://github.com/rails/rails/commit/bad9bfbea6d6af9dc28583e08a49492668087393.
Without that change, this test would fail with:
ActiveRecord::StatementInvalid: SQLite3::SQLException: near "WHERE": syntax error: UPDATE "topics" SET "replies_count" = COALESCE("replies_count", 0) - 1, WHERE "topics"."id" = ?
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`timestamp_attributes_for_updates_in_model` returns an empty
array when a model has no `updated_at` or `updated_on`.
So my previously thought uncommon case is a lot more likely
now.
This reverts commit a0a1ede8c2eb6436571eae8778033162d1f9dcc3.
|
|\ \
| | |
| | | |
Make all rails commands work in engine
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This test was added in 221b4ae.
221b4ae modified to return the same result even if `Rails::Server#default_options`
is called more than once. Therefore, also use `Rails::Server#default_options`
instead of `ServerCommand#default_options` in test.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, all rails commands can be executed in engine,
but `server`, `console`, `dbconsole` and `runner` do not work.
This make all rails commands work in engine.
Related to #22588
|
|\ \ \
| | | |
| | | | |
Fix UUID primary key with default nil in legacy migration
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
UUID primary key with no default value feature (#10404, #18206) was lost
in legacy migration caused by #25395 got merged. Restore the feature
again in legacy migration.
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The exact inspect output of a BigDecimal is out of scope for what we're trying
to communicate about `dup` and `duplicable?` here.
Adding two examples distracts is disctracting, so keep the docs from before
since our minimal version is Ruby 2.2.2.
[ Koichi ITO, Jon Moss, Kasper Timm Hansen ]
This reverts commit 2163874dedaf83e67599c2930c2686caa165fbad, reversing
changes made to 46fdbc5290335ed38fa9fe2b6b0ef8abe4eccb1b.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #27683.
Seeing a code sample that leads to what we're guarding against:
```ruby
Topic.update_counters(1, replies_count: 1, touch: [])
```
It doesn't look like a case people would ever intentionally end
up with. Thus we're better off sparing the conditional.
Note: it could happen if a method returns an empty array
that's then passed to `update_counters` and its touchy friends.
But `[].presence` can fix that once people see their query blow
up.
[ Eugene Kenny & Kasper Timm Hansen ]
|
|\ \ \
| | | |
| | | | |
remove unused require
|
| | |/
| |/|
| | |
| | | |
`InlineAdapter` is not used from 1f8558f.
|
|\ \ \
| | | |
| | | | |
Several representation of BigDecimal has changed in Ruby 2.4.0+ [ci skip]
|
| |/ /
| | |
| | |
| | | |
cf. https://github.com/ruby/bigdecimal/pull/42
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 66e5b9d3f47cd52143be0e6a216ade34bb52b9cc.
We're seeing some test failures in AR postgresql tests
|