diff options
author | Kasper Timm Hansen <kaspth@gmail.com> | 2017-01-15 19:49:34 +0100 |
---|---|---|
committer | Kasper Timm Hansen <kaspth@gmail.com> | 2017-01-15 19:49:34 +0100 |
commit | 7c3a99eeca07f602bb1e5659656e8eab0a4eacfe (patch) | |
tree | 053be53206aaf7bc2043a7283bce9b772b535ff8 | |
parent | a0a1ede8c2eb6436571eae8778033162d1f9dcc3 (diff) | |
download | rails-7c3a99eeca07f602bb1e5659656e8eab0a4eacfe.tar.gz rails-7c3a99eeca07f602bb1e5659656e8eab0a4eacfe.tar.bz2 rails-7c3a99eeca07f602bb1e5659656e8eab0a4eacfe.zip |
Revert "Merge pull request #27686 from koic/friendly_bigdecimal_inspect"
The exact inspect output of a BigDecimal is out of scope for what we're trying
to communicate about `dup` and `duplicable?` here.
Adding two examples distracts is disctracting, so keep the docs from before
since our minimal version is Ruby 2.2.2.
[ Koichi ITO, Jon Moss, Kasper Timm Hansen ]
This reverts commit 2163874dedaf83e67599c2930c2686caa165fbad, reversing
changes made to 46fdbc5290335ed38fa9fe2b6b0ef8abe4eccb1b.
-rw-r--r-- | activesupport/lib/active_support/core_ext/object/duplicable.rb | 7 | ||||
-rw-r--r-- | guides/source/active_support_core_extensions.md | 10 |
2 files changed, 1 insertions, 16 deletions
diff --git a/activesupport/lib/active_support/core_ext/object/duplicable.rb b/activesupport/lib/active_support/core_ext/object/duplicable.rb index ed0df42b0a..ea81df2bd8 100644 --- a/activesupport/lib/active_support/core_ext/object/duplicable.rb +++ b/activesupport/lib/active_support/core_ext/object/duplicable.rb @@ -107,13 +107,6 @@ class BigDecimal # BigDecimals are duplicable: # # BigDecimal.new("1.2").duplicable? # => true - # - # In Ruby 2.4.0: - # - # BigDecimal.new("1.2").dup # => 0.12e1 - # - # Whereas in Ruby 2.2 and 2.3: - # # BigDecimal.new("1.2").dup # => #<BigDecimal:...,'0.12E1',18(18)> def duplicable? true diff --git a/guides/source/active_support_core_extensions.md b/guides/source/active_support_core_extensions.md index b9f096b82a..67bed4c8da 100644 --- a/guides/source/active_support_core_extensions.md +++ b/guides/source/active_support_core_extensions.md @@ -1980,15 +1980,7 @@ and that symbol specifiers are also supported: BigDecimal.new(5.00, 6).to_s(:db) # => "5.0" ``` -Engineering notation is still supported. - -In Ruby 2.4: - -```ruby -BigDecimal.new(5.00, 6).to_s("e") # => "0.5e1" -``` - -Whereas in Ruby 2.2 and 2.3: +Engineering notation is still supported: ```ruby BigDecimal.new(5.00, 6).to_s("e") # => "0.5E1" |