aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* use public API to fetch the parameter filterAaron Patterson2015-08-211-2/+2
| | | | | now the parameter filter doesn't need to know about the env hash in these two methds.
* use methods on the request object to implement `fetch`Aaron Patterson2015-08-211-2/+8
| | | | Now the Headers internals don't depend on the env hash.
* dup the env hash on Header#envAaron Patterson2015-08-211-1/+1
| | | | | This prevents external mutations from impacting the internals of the request or the Header object.
* use accessors on the request object for manipulating envAaron Patterson2015-08-211-3/+3
| | | | | this reduces the API footprint for the env hash so that we can be more flexible when changing API in the future
* use `set_header` rather than []=Aaron Patterson2015-08-211-1/+1
| | | | This allows us to avoid calling `env_name` twice.
* dup the request and mutate its headers object.Aaron Patterson2015-08-212-5/+5
| | | | duping the request will dup it's underlying env hash.
* JSON is still an adapter specific type.Sean Griffin2015-08-218-36/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several changes were made in #21110 which I am strongly opposed to. (this is what I get for going on vacation. :trollface:) No type should be introduced into the generic `ActiveRecord::Type` namespace, and *certainly* should not be registered into the registry unconstrained unless it is supported by *all* adapters (which basically means that it was specified in the ANSI SQL standard). I do not think `# :nodoc:` ing the type is sufficient, as it still makes the code of Rails itself very unclear as to what the role of that class is. While I would argue that this shouldn't even be a super class, and that MySql and PG's JSON types are only superficially duplicated (they might look the same but will change for different reasons in the future). However, I don't feel strongly enough about it as a point of contention (and the biggest cost of harming the blameability has already occured), so I simply moved the superclass into a namespace where its role is absolutely clear. After this change, `attribute :foo, :json` will once again work with MySQL and PG, but not with Sqlite3 or any third party adapters. Unresolved questions -------------------- The types that and adapter publishes (at least those are unique to that adapter, and not adding additional behavior like `MysqlString` should probably be part of the adapter's public API. Should we standardize the namespace for these, and document them?
* Move the CoC text to the Rails websiteGodfrey Chan2015-08-212-16/+6
|
* Remove unnecessary cachingeileencodes2015-08-211-5/+1
| | | | | | | `ActiveSupport::Dependencies.constantize(const_name)` calls `Reference.new` which is defined as `ActiveSupport::Dependencies.constantize(const_name)` meaning this call is already cached and we're doing caching that isn't necessary.
* pass a request object to the headers objectAaron Patterson2015-08-214-13/+19
|
* move header allocation to a helper methodAaron Patterson2015-08-211-5/+9
| | | | | I'm going to change the constructor, so it's easier to do it in one place.
* Merge pull request #21106 from amitsuroliya/fix_routing_testAndrew White2015-08-211-6/+0
|\ | | | | Remove duplicity in tests
| * Remove duplicity in testsamitkumarsuroliya2015-08-031-6/+0
| |
* | better docs for `disable_ddl_transaction!`. Closes #21044.Yves Senn2015-08-211-1/+4
| |
* | Merge pull request #21312 from piton4eg/patch-7Yves Senn2015-08-211-12/+6
|\ \ | | | | | | Small fixes [ci skip]
| * | Add bold to lists' titles [ci skip]Alexey Markov2015-08-211-6/+6
| | |
| * | Small fixes [ci skip]Alexey Markov2015-08-201-12/+6
| | |
* | | Merge pull request #21313 from reshleman/re-punctuationYves Senn2015-08-211-2/+2
|\ \ \ | | | | | | | | Fix Punctuation in `AutosaveAssociation` RDoc [ci skip]
| * | | Fix Punctuation in `AutosaveAssociation` RDocRobert Eshleman2015-08-201-2/+2
| | | | | | | | | | | | | | | | [ci skip]
* | | | set route precedence at allocation timeAaron Patterson2015-08-202-8/+6
| | | | | | | | | | | | | | | | This way we can make the Route object a read-only data structure.
* | | | argh!!!Aaron Patterson2015-08-203-0/+3
| | | |
* | | | smooth move aaron.... :bomb:Aaron Patterson2015-08-201-2/+2
| | | |
* | | | point at rack masterAaron Patterson2015-08-206-31/+34
|/ / /
* | | Merge pull request #21306 from ronakjangir47/remove_mocha_actionmailerKasper Timm Hansen2015-08-204-55/+100
|\ \ \ | |/ / |/| | Removed mocha from ActionMailer
| * | Removed mocha from ActionMailerRonak Jangir2015-08-204-55/+100
| | |
* | | Merge pull request #16245 from byroot/more-atomic-writeMatthew Draper2015-08-211-27/+29
|\ \ \ | | | | | | | | File renaming should be the last operation of an atomic write
| * | | File renaming should be the last operation of an atomic writeJean Boussier2015-08-201-27/+29
| | | |
* | | | Merge pull request #21310 from y-yagi/fix_file_pathYves Senn2015-08-201-1/+1
|\ \ \ \ | | | | | | | | | | fix path of annotations.rake [ci skip]
| * | | | fix path of annotations.rake [ci skip]yuuji.yaginuma2015-08-201-1/+1
|/ / / /
* | | | uniqueness validation raises error for persisted record without pk.Yves Senn2015-08-204-4/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #21304. While we can validate uniqueness for record without primary key on creation, there is no way to exclude the current record when updating. (The update itself will need a primary key to work correctly).
* | | | Merge pull request #21300 from jonahb/cacheYves Senn2015-08-201-1/+1
|\ \ \ \ | |_|/ / |/| | | Correct cache store superclass in comment [ci skip]
| * | | Correct cache store superclass in commentJonah Burke2015-08-191-1/+1
| | | |
* | | | Merge pull request #21279 from ronakjangir47/test_cleanupKasper Timm Hansen2015-08-205-45/+30
|\ \ \ \ | | | | | | | | | | Cleaned up generators tests using internal assertion helper
| * | | | Cleaned up generators tests using internal assertion helperRonak Jangir2015-08-205-45/+30
| | | | |
* | | | | Merge pull request #21132 from Andreis13/sprockets-4Rafael Mendonça França2015-08-199-22/+85
|\ \ \ \ \ | |_|/ / / |/| | | | Migrate to Sprockets 4.
| * | | | Migrate to Sprockets 4.Andrei Istratii2015-08-199-22/+85
|/ / / /
* | | | Merge pull request #21294 from maclover7/codeofconductGuillermo Iguaran2015-08-193-0/+9
|\ \ \ \ | | | | | | | | | | Add code of conduct info to README.md and to contributing guide
| * | | | Add code of conduct to README.md and to contributing guide [ci skip]maclover72015-08-183-0/+9
| | | | |
* | | | | Merge pull request #21292 from CoralineAda/cocDavid Heinemeier Hansson2015-08-191-0/+22
|\ \ \ \ \ | | | | | | | | | | | | Adds a code of conduct
| * | | | | Adds a code of conductCoralineAda2015-08-181-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An easy way to begin addressing the problem of inclusivity is to be overt in our openness, welcoming all people to contribute, and pledging in return to value them as human beings and to foster an atmosphere of kindness, cooperation, and understanding. A code of conduct is one way to express these values. It lets us pledge our respect and appreciation for contributors and participants to the project.
* | | | | | Merge pull request #21282 from sjain1107/added_docsYves Senn2015-08-191-0/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Added docs for TableDefinition #coloumns & #remove_column [ci skip]
| * | | | | | Added docs for TableDefinition #coloumns & #remove_column [ci skip]sjain11072015-08-181-0/+3
| | | | | | |
* | | | | | | make the routes reader privateAaron Patterson2015-08-182-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nobody should be touching the routes hash without going through the NamedRouteCollection object.
* | | | | | | don't touch internalsAaron Patterson2015-08-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We shouldn't be messing with the NamedRouteCollection internals. Just ask the object if the named route is in there.
* | | | | | | drop array allocations when building pathsAaron Patterson2015-08-182-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby require 'action_pack' require 'action_dispatch' require 'benchmark/ips' route_set = ActionDispatch::Routing::RouteSet.new routes = ActionDispatch::Routing::Mapper.new route_set ObjectSpace::AllocationTracer.setup(%i{path line type}) result = ObjectSpace::AllocationTracer.trace do 500.times do routes.resources :foo end end sorted = ObjectSpace::AllocationTracer.allocated_count_table.sort_by(&:last) sorted.each do |k,v| next if v == 0 p k => v end __END__ Before: {:T_SYMBOL=>11} {:T_REGEXP=>17} {:T_STRUCT=>6500} {:T_MATCH=>12004} {:T_OBJECT=>99009} {:T_DATA=>100088} {:T_HASH=>122015} {:T_STRING=>159637} {:T_IMEMO=>363134} {:T_ARRAY=>433056} After: {:T_SYMBOL=>11} {:T_REGEXP=>17} {:T_STRUCT=>6500} {:T_MATCH=>12004} {:T_OBJECT=>91009} {:T_DATA=>100088} {:T_HASH=>114013} {:T_STRING=>159637} {:T_ARRAY=>321056} {:T_IMEMO=>351133} ```
* | | | | | | symbols will always be constructed with strings. :bomb:Aaron Patterson2015-08-181-1/+1
| | | | | | |
* | | | | | | drop string allocations for each resourceAaron Patterson2015-08-181-0/+2
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eagerly calculate and cache the name of Symbol objects in the path AST. This drops about 26 string allocations per resource: ```ruby require 'action_pack' require 'action_dispatch' require 'benchmark/ips' route_set = ActionDispatch::Routing::RouteSet.new routes = ActionDispatch::Routing::Mapper.new route_set ObjectSpace::AllocationTracer.setup(%i{path line type}) result = ObjectSpace::AllocationTracer.trace do 500.times do routes.resources :foo end end sorted = ObjectSpace::AllocationTracer.allocated_count_table.sort_by(&:last) sorted.each do |k,v| next if v == 0 p k => v end __END__ Before: {:T_SYMBOL=>11} {:T_REGEXP=>17} {:T_STRUCT=>6500} {:T_MATCH=>12004} {:T_OBJECT=>99009} {:T_DATA=>116084} {:T_HASH=>122015} {:T_STRING=>172647} {:T_IMEMO=>371132} {:T_ARRAY=>433056} After: {:T_SYMBOL=>11} {:T_REGEXP=>17} {:T_STRUCT=>6500} {:T_MATCH=>12004} {:T_OBJECT=>99009} {:T_DATA=>100088} {:T_HASH=>122015} {:T_STRING=>159637} {:T_IMEMO=>363134} {:T_ARRAY=>433056} ```
* | | | | | Merge pull request #21110 from kamipo/mysql_json_supportRafael Mendonça França2015-08-1811-50/+258
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add a native JSON data type support in MySQL
| * | | | | Add a native JSON data type support in MySQLRyuta Kamizono2015-08-1811-50/+258
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of MySQL 5.7.8, MySQL supports a native JSON data type. Example: create_table :json_data_type do |t| t.json :settings end
* | | | | Merge pull request #21283 from ravindrakumawat/add_docs_for_pending_migrationYves Senn2015-08-181-0/+1
|\ \ \ \ \ | | | | | | | | | | | | Add Docs for ActiveRecord #check_pending [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 08:49:18 +0000