diff options
author | Aaron Patterson <aaron.patterson@gmail.com> | 2015-08-18 16:33:18 -0700 |
---|---|---|
committer | Aaron Patterson <aaron.patterson@gmail.com> | 2015-08-18 16:33:18 -0700 |
commit | 7187339854d8454fdb3338b3041f89c6ce7e1e41 (patch) | |
tree | db4a8e9a40ea6ea1c464fcb24b07e326c4ba13df | |
parent | 62383ddecc235334fdeff3995ab0e0470d055526 (diff) | |
download | rails-7187339854d8454fdb3338b3041f89c6ce7e1e41.tar.gz rails-7187339854d8454fdb3338b3041f89c6ce7e1e41.tar.bz2 rails-7187339854d8454fdb3338b3041f89c6ce7e1e41.zip |
make the routes reader private
nobody should be touching the routes hash without going through the
NamedRouteCollection object.
-rw-r--r-- | actionpack/lib/action_dispatch/routing/route_set.rb | 1 | ||||
-rw-r--r-- | actionpack/test/dispatch/mount_test.rb | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb index 30e308119d..20926012b4 100644 --- a/actionpack/lib/action_dispatch/routing/route_set.rb +++ b/actionpack/lib/action_dispatch/routing/route_set.rb @@ -89,6 +89,7 @@ module ActionDispatch class NamedRouteCollection include Enumerable attr_reader :routes, :url_helpers_module, :path_helpers_module + private :routes def initialize @routes = {} diff --git a/actionpack/test/dispatch/mount_test.rb b/actionpack/test/dispatch/mount_test.rb index 6a439be2b5..d027f09762 100644 --- a/actionpack/test/dispatch/mount_test.rb +++ b/actionpack/test/dispatch/mount_test.rb @@ -49,7 +49,7 @@ class TestRoutingMount < ActionDispatch::IntegrationTest def test_app_name_is_properly_generated_when_engine_is_mounted_in_resources assert Router.mounted_helpers.method_defined?(:user_fake_mounted_at_resource), "A mounted helper should be defined with a parent's prefix" - assert Router.named_routes.routes[:user_fake_mounted_at_resource], + assert Router.named_routes.key?(:user_fake_mounted_at_resource), "A named route should be defined with a parent's prefix" end |