| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Improve assert_response helper
|
| | |_|_|/ / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
When the check is failed, print the actual response body if it's not too large.
This could improve productivity when writing new tests.
Before:
```
ThemeEditorIntegrationTest#test_whatever
Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
Expected: 200
Actual: 422
```
After:
```
ThemeEditorIntegrationTest#test_whatever
Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
Expected: 200
Actual: 422
Response body: {"errors":["Invalid settings object for section '1'"]}
```
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Move comment about disconnecting pool close to comment about preload
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- These two comments are connected to each other so kept them back to back.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
fix broken generators test
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
|
| | | | | | | | |
|
| |_|_|/ / / /
|/| | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix broken comments indentation caused by rubocop auto-correct [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772.
But comments was still kept absolute position. This commit aligns
comments with method definitions for consistency.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Master based applications should be pointing to master
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Address warning: ambiguous first argument
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
after `/' operator`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
close it (#26473)
* activerecord/mysql2: Avoid setting @connection to nil, just close it
Backport of https://github.com/rails/rails/pull/26434
* Add a CHANGELOG entry
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Disconnects all connections in the pool before forking.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
See discussion in https://github.com/puma/puma/issues/1001
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
remove duplicated fixture set names
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
If using namespaced fixtures, get following Ruby warning.
```
activerecord/lib/active_record/fixtures.rb:922: warning: method redefined; discarding old admin_foos
activerecord/lib/active_record/fixtures.rb:922: warning: previous definition of admin_foos was here
```
This is happening because of the multiple set the same path when setting the
fixture name. Fix to remove the duplicate path.
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
fixed guide to add correct documentation for partial render 'as' option
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Lacks some proper creds to the homies who went the... distance ;)
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
kamipo/remove_useless_test_string_with_crazy_column
Remove useless `test_string_with_crazy_column`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Passing `FakeColumn` was removed at #15336 therefore
`test_string_with_crazy_column` is duplicated with
`test_quote_string_no_column`.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
activerecord/mysql2: Avoid setting @connection to nil, just close it
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
By doing `@connection = nil` that means that we need nil checks before it
is used anywhere, but we weren't doing those checks. Instead, we get a
NoMethodError after using a connection after it fails to reconnect.
Neither of the other adapters set @connection to nil, just the mysql2
adapter. By just closing it, we avoid the need to check if we have a
connection object and it will produce an appropriate exception when used.
|
|\ \ \ \ \ \ \ \ \
| |_|_|_|_|_|/ / /
|/| | | | | | | | |
Add tests for ActiveRecord::Enum#enum when suffix specified
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
Make name of attribute medium instead of normal
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove unused `require "thread"` in `test/cases/attribute_methods/read_test.rb`
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`Mutex` was removed at 8eb7561ac6e8f020ec09608532de310c6b0b8dcd.
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Remove duplicated `elsif` branch
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
The `elsif` branch is completely duplicated with `else` branch.
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Use :git for specifying dependencies from github with https protocol
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- This is required for bundler 1.13.0 because of which lot of specs are
failing on Travis CI.
- Similar to https://travis-ci.org/rails/rails/jobs/158905576#L559
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
use correct Gemfile in `bin/setup` test
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a
file to be used in Rails application.
Add a Gemfile to Rails application that is created for test, it has been
modified to use the Gemfile.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Do not mutate AC::TestRequest::DEFAULT_OPTIONS
|
| |/ / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove outdated "#TODO: Fix for binds." comment [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
This comment was added at eaf5486 but already implemented.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Pass `set_inverse_instance` block to `sc.execute` for `SingularAssociation`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to caa178c.
caa178c updated all code which sets inverse instances on newly loaded
associations to use block. But `SingularAssociation` was forgotten it.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix table name typos [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
update doc about default `cache_store` [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The default `cache_store` has changed in 8f0e0b6 to use `file_store`.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
call `.to_h` to avoid using deprecated method
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`ActionController::Parameters#merge` call `HashWithIndifferentAccess#merge`.
In addition, it calls `HashWithIndifferentAccess#update` from
`HashWithIndifferentAccess#merge`, where it is called the `#to_hash` of argument.
But `ActionController::Parameters#to_hash` is deprecated, warning message is
displayed.
To avoid this, modify to convert object to `Hash`.
Fixes #26415
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Clarify expires_now documentation
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Simply formatting documents
|