diff options
| author | Kir Shatrov <shatrov@me.com> | 2016-09-09 22:17:10 -0400 |
|---|---|---|
| committer | Kir Shatrov <shatrov@me.com> | 2016-09-10 11:13:12 -0400 |
| commit | 040ca9cf5b7e193f0fb15166135643daa60f9237 (patch) | |
| tree | ac4c24aeade3a3ece8b88bdc37c083f7f7cc1dab | |
| parent | cf5f55cd30aef0f90300c7c8f333060fe258cd8a (diff) | |
| download | rails-040ca9cf5b7e193f0fb15166135643daa60f9237.tar.gz rails-040ca9cf5b7e193f0fb15166135643daa60f9237.tar.bz2 rails-040ca9cf5b7e193f0fb15166135643daa60f9237.zip | |
Do not mutate AC::TestRequest::DEFAULT_OPTIONS
| -rw-r--r-- | actionpack/lib/action_controller/test_case.rb | 2 | ||||
| -rw-r--r-- | actionpack/test/controller/request/test_request_test.rb | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/actionpack/lib/action_controller/test_case.rb b/actionpack/lib/action_controller/test_case.rb index 16ddd3b304..09f2a79d85 100644 --- a/actionpack/lib/action_controller/test_case.rb +++ b/actionpack/lib/action_controller/test_case.rb @@ -51,7 +51,7 @@ module ActionController super(env) self.session = session - self.session_options = TestSession::DEFAULT_OPTIONS + self.session_options = TestSession::DEFAULT_OPTIONS.dup @controller_class = controller_class @custom_param_parsers = { xml: lambda { |raw_post| Hash.from_xml(raw_post)["hash"] } diff --git a/actionpack/test/controller/request/test_request_test.rb b/actionpack/test/controller/request/test_request_test.rb index 6e0ca957c3..fa049fbc9f 100644 --- a/actionpack/test/controller/request/test_request_test.rb +++ b/actionpack/test/controller/request/test_request_test.rb @@ -6,6 +6,11 @@ class ActionController::TestRequestTest < ActionController::TestCase assert @request.session_options end + def test_mutating_session_options_does_not_affect_default_options + @request.session_options[:myparam] = 123 + assert_equal nil, ActionController::TestSession::DEFAULT_OPTIONS[:myparam] + end + ActionDispatch::Session::AbstractStore::DEFAULT_OPTIONS.each_key do |option| test "rack default session options #{option} exists in session options and is default" do assert_equal(ActionDispatch::Session::AbstractStore::DEFAULT_OPTIONS[option], |